Skip to content

Commit 4e37274

Browse files
lauritlaurit
authored
End metric description with dot (#13559)
1 parent e207579 commit 4e37274

File tree

5 files changed

+26
-26
lines changed

5 files changed

+26
-26
lines changed

‎instrumentation-api-incubator/src/main/java/io/opentelemetry/instrumentation/api/incubator/semconv/genai/GenAiClientMetrics.java‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,15 +64,15 @@ private GenAiClientMetrics(Meter meter) {
6464
.histogramBuilder("gen_ai.client.token.usage")
6565
.ofLongs()
6666
.setUnit("{token}")
67-
.setDescription("Measures number of input and output tokens used")
67+
.setDescription("Measures number of input and output tokens used.")
6868
.setExplicitBucketBoundariesAdvice(GenAiMetricsAdvice.CLIENT_TOKEN_USAGE_BUCKETS);
6969
GenAiMetricsAdvice.applyClientTokenUsageAdvice(tokenUsageBuilder);
7070
this.tokenUsage = tokenUsageBuilder.build();
7171
DoubleHistogramBuilder operationDurationBuilder =
7272
meter
7373
.histogramBuilder("gen_ai.client.operation.duration")
7474
.setUnit("s")
75-
.setDescription("GenAI operation duration")
75+
.setDescription("GenAI operation duration.")
7676
.setExplicitBucketBoundariesAdvice(
7777
GenAiMetricsAdvice.CLIENT_OPERATION_DURATION_BUCKETS);
7878
GenAiMetricsAdvice.applyClientOperationDurationAdvice(operationDurationBuilder);

‎instrumentation-api-incubator/src/main/java/io/opentelemetry/instrumentation/api/incubator/semconv/rpc/RpcClientMetrics.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ private RpcClientMetrics(Meter meter) {
4040
DoubleHistogramBuilder durationBuilder =
4141
meter
4242
.histogramBuilder("rpc.client.duration")
43-
.setDescription("The duration of an outbound RPC invocation")
43+
.setDescription("The duration of an outbound RPC invocation.")
4444
.setUnit("ms");
4545
RpcMetricsAdvice.applyClientDurationAdvice(durationBuilder);
4646
clientDurationHistogram = durationBuilder.build();

‎instrumentation-api-incubator/src/main/java/io/opentelemetry/instrumentation/api/incubator/semconv/rpc/RpcServerMetrics.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ private RpcServerMetrics(Meter meter) {
4040
DoubleHistogramBuilder durationBuilder =
4141
meter
4242
.histogramBuilder("rpc.server.duration")
43-
.setDescription("The duration of an inbound RPC invocation")
43+
.setDescription("The duration of an inbound RPC invocation.")
4444
.setUnit("ms");
4545
RpcMetricsAdvice.applyServerDurationAdvice(durationBuilder);
4646
serverDurationHistogram = durationBuilder.build();

‎instrumentation/aws-sdk/aws-sdk-2.2/library/src/testBedrockRuntime/java/io/opentelemetry/instrumentation/awssdk/v2_2/internal/Aws2BedrockRuntimeTest.java‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ void testConverseToolCallNoMessageContent() {
169169
metric
170170
.hasName("gen_ai.client.token.usage")
171171
.hasUnit("{token}")
172-
.hasDescription("Measures number of input and output tokens used")
172+
.hasDescription("Measures number of input and output tokens used.")
173173
.hasHistogramSatisfying(
174174
histogram ->
175175
histogram.hasPointsSatisfying(
@@ -207,7 +207,7 @@ void testConverseToolCallNoMessageContent() {
207207
metric
208208
.hasName("gen_ai.client.operation.duration")
209209
.hasUnit("s")
210-
.hasDescription("GenAI operation duration")
210+
.hasDescription("GenAI operation duration.")
211211
.hasHistogramSatisfying(
212212
histogram ->
213213
histogram.hasPointsSatisfying(
@@ -322,7 +322,7 @@ void testConverseToolCallNoMessageContent() {
322322
metric
323323
.hasName("gen_ai.client.token.usage")
324324
.hasUnit("{token}")
325-
.hasDescription("Measures number of input and output tokens used")
325+
.hasDescription("Measures number of input and output tokens used.")
326326
.hasHistogramSatisfying(
327327
histogram ->
328328
histogram.hasPointsSatisfying(
@@ -360,7 +360,7 @@ void testConverseToolCallNoMessageContent() {
360360
metric
361361
.hasName("gen_ai.client.operation.duration")
362362
.hasUnit("s")
363-
.hasDescription("GenAI operation duration")
363+
.hasDescription("GenAI operation duration.")
364364
.hasHistogramSatisfying(
365365
histogram ->
366366
histogram.hasPointsSatisfying(
@@ -550,7 +550,7 @@ void testConverseToolCallStreamNoMessageContent()
550550
metric
551551
.hasName("gen_ai.client.token.usage")
552552
.hasUnit("{token}")
553-
.hasDescription("Measures number of input and output tokens used")
553+
.hasDescription("Measures number of input and output tokens used.")
554554
.hasHistogramSatisfying(
555555
histogram ->
556556
histogram.hasPointsSatisfying(
@@ -588,7 +588,7 @@ void testConverseToolCallStreamNoMessageContent()
588588
metric
589589
.hasName("gen_ai.client.operation.duration")
590590
.hasUnit("s")
591-
.hasDescription("GenAI operation duration")
591+
.hasDescription("GenAI operation duration.")
592592
.hasHistogramSatisfying(
593593
histogram ->
594594
histogram.hasPointsSatisfying(
@@ -722,7 +722,7 @@ void testConverseToolCallStreamNoMessageContent()
722722
metric
723723
.hasName("gen_ai.client.token.usage")
724724
.hasUnit("{token}")
725-
.hasDescription("Measures number of input and output tokens used")
725+
.hasDescription("Measures number of input and output tokens used.")
726726
.hasHistogramSatisfying(
727727
histogram ->
728728
histogram.hasPointsSatisfying(
@@ -760,7 +760,7 @@ void testConverseToolCallStreamNoMessageContent()
760760
metric
761761
.hasName("gen_ai.client.operation.duration")
762762
.hasUnit("s")
763-
.hasDescription("GenAI operation duration")
763+
.hasDescription("GenAI operation duration.")
764764
.hasHistogramSatisfying(
765765
histogram ->
766766
histogram.hasPointsSatisfying(

‎instrumentation/aws-sdk/aws-sdk-2.2/testing/src/main/java/io/opentelemetry/instrumentation/awssdk/v2_2/AbstractAws2BedrockRuntimeTest.java‎

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@ void testConverseBasic() {
144144
metric
145145
.hasName("gen_ai.client.token.usage")
146146
.hasUnit("{token}")
147-
.hasDescription("Measures number of input and output tokens used")
147+
.hasDescription("Measures number of input and output tokens used.")
148148
.hasHistogramSatisfying(
149149
histogram ->
150150
histogram.hasPointsSatisfying(
@@ -182,7 +182,7 @@ void testConverseBasic() {
182182
metric
183183
.hasName("gen_ai.client.operation.duration")
184184
.hasUnit("s")
185-
.hasDescription("GenAI operation duration")
185+
.hasDescription("GenAI operation duration.")
186186
.hasHistogramSatisfying(
187187
histogram ->
188188
histogram.hasPointsSatisfying(
@@ -278,7 +278,7 @@ void testConverseOptions() {
278278
metric
279279
.hasName("gen_ai.client.token.usage")
280280
.hasUnit("{token}")
281-
.hasDescription("Measures number of input and output tokens used")
281+
.hasDescription("Measures number of input and output tokens used.")
282282
.hasHistogramSatisfying(
283283
histogram ->
284284
histogram.hasPointsSatisfying(
@@ -316,7 +316,7 @@ void testConverseOptions() {
316316
metric
317317
.hasName("gen_ai.client.operation.duration")
318318
.hasUnit("s")
319-
.hasDescription("GenAI operation duration")
319+
.hasDescription("GenAI operation duration.")
320320
.hasHistogramSatisfying(
321321
histogram ->
322322
histogram.hasPointsSatisfying(
@@ -421,7 +421,7 @@ void testConverseToolCall() {
421421
metric
422422
.hasName("gen_ai.client.token.usage")
423423
.hasUnit("{token}")
424-
.hasDescription("Measures number of input and output tokens used")
424+
.hasDescription("Measures number of input and output tokens used.")
425425
.hasHistogramSatisfying(
426426
histogram ->
427427
histogram.hasPointsSatisfying(
@@ -459,7 +459,7 @@ void testConverseToolCall() {
459459
metric
460460
.hasName("gen_ai.client.operation.duration")
461461
.hasUnit("s")
462-
.hasDescription("GenAI operation duration")
462+
.hasDescription("GenAI operation duration.")
463463
.hasHistogramSatisfying(
464464
histogram ->
465465
histogram.hasPointsSatisfying(
@@ -588,7 +588,7 @@ void testConverseToolCall() {
588588
metric
589589
.hasName("gen_ai.client.token.usage")
590590
.hasUnit("{token}")
591-
.hasDescription("Measures number of input and output tokens used")
591+
.hasDescription("Measures number of input and output tokens used.")
592592
.hasHistogramSatisfying(
593593
histogram ->
594594
histogram.hasPointsSatisfying(
@@ -626,7 +626,7 @@ void testConverseToolCall() {
626626
metric
627627
.hasName("gen_ai.client.operation.duration")
628628
.hasUnit("s")
629-
.hasDescription("GenAI operation duration")
629+
.hasDescription("GenAI operation duration.")
630630
.hasHistogramSatisfying(
631631
histogram ->
632632
histogram.hasPointsSatisfying(
@@ -836,7 +836,7 @@ void testConverseToolCallStream() throws InterruptedException, ExecutionExceptio
836836
metric
837837
.hasName("gen_ai.client.token.usage")
838838
.hasUnit("{token}")
839-
.hasDescription("Measures number of input and output tokens used")
839+
.hasDescription("Measures number of input and output tokens used.")
840840
.hasHistogramSatisfying(
841841
histogram ->
842842
histogram.hasPointsSatisfying(
@@ -874,7 +874,7 @@ void testConverseToolCallStream() throws InterruptedException, ExecutionExceptio
874874
metric
875875
.hasName("gen_ai.client.operation.duration")
876876
.hasUnit("s")
877-
.hasDescription("GenAI operation duration")
877+
.hasDescription("GenAI operation duration.")
878878
.hasHistogramSatisfying(
879879
histogram ->
880880
histogram.hasPointsSatisfying(
@@ -1022,7 +1022,7 @@ void testConverseToolCallStream() throws InterruptedException, ExecutionExceptio
10221022
metric
10231023
.hasName("gen_ai.client.token.usage")
10241024
.hasUnit("{token}")
1025-
.hasDescription("Measures number of input and output tokens used")
1025+
.hasDescription("Measures number of input and output tokens used.")
10261026
.hasHistogramSatisfying(
10271027
histogram ->
10281028
histogram.hasPointsSatisfying(
@@ -1060,7 +1060,7 @@ void testConverseToolCallStream() throws InterruptedException, ExecutionExceptio
10601060
metric
10611061
.hasName("gen_ai.client.operation.duration")
10621062
.hasUnit("s")
1063-
.hasDescription("GenAI operation duration")
1063+
.hasDescription("GenAI operation duration.")
10641064
.hasHistogramSatisfying(
10651065
histogram ->
10661066
histogram.hasPointsSatisfying(
@@ -1252,7 +1252,7 @@ void testConverseStream() throws InterruptedException, ExecutionException {
12521252
metric
12531253
.hasName("gen_ai.client.token.usage")
12541254
.hasUnit("{token}")
1255-
.hasDescription("Measures number of input and output tokens used")
1255+
.hasDescription("Measures number of input and output tokens used.")
12561256
.hasHistogramSatisfying(
12571257
histogram ->
12581258
histogram.hasPointsSatisfying(
@@ -1290,7 +1290,7 @@ void testConverseStream() throws InterruptedException, ExecutionException {
12901290
metric
12911291
.hasName("gen_ai.client.operation.duration")
12921292
.hasUnit("s")
1293-
.hasDescription("GenAI operation duration")
1293+
.hasDescription("GenAI operation duration.")
12941294
.hasHistogramSatisfying(
12951295
histogram ->
12961296
histogram.hasPointsSatisfying(

0 commit comments

Comments
 (0)