Skip to content

Commit 5154017

Browse files
committed
rename
1 parent d94180e commit 5154017

File tree

13 files changed

+42
-43
lines changed

13 files changed

+42
-43
lines changed

declarative-config-bridge/src/main/java/io/opentelemetry/instrumentation/config/bridge/ConfigPropertiesUtil.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ public static String propertyYamlPath(String propertyName) {
1313
}
1414

1515
static String yamlPath(String property) {
16-
String[] segments = SimpleDeclarativeConfigPropertiesBridge.getSegments(property);
16+
String[] segments = DeclarativeConfigPropertiesApiBridge.getSegments(property);
1717
if (segments.length == 0) {
1818
throw new IllegalArgumentException("Invalid property: " + property);
1919
}
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,14 +17,14 @@
1717
import java.util.function.BiFunction;
1818
import javax.annotation.Nullable;
1919

20-
public class SimpleDeclarativeConfigPropertiesBridge {
20+
public class DeclarativeConfigPropertiesApiBridge {
2121
private static final String OTEL_INSTRUMENTATION_PREFIX = "otel.instrumentation.";
2222
protected final DeclarativeConfigProperties baseNode;
2323
// lookup order matters - we choose the first match
2424
protected final Map<String, String> mappings;
2525
protected final Map<String, Object> overrideValues;
2626

27-
public SimpleDeclarativeConfigPropertiesBridge(
27+
public DeclarativeConfigPropertiesApiBridge(
2828
DeclarativeConfigProperties baseNode,
2929
Map<String, String> mappings,
3030
Map<String, Object> overrideValues) {

declarative-config-bridge/src/main/java/io/opentelemetry/instrumentation/config/bridge/DeclarativeConfigPropertiesBridge.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
* string_key: value
3939
* </pre>
4040
*/
41-
final class DeclarativeConfigPropertiesBridge extends SimpleDeclarativeConfigPropertiesBridge
41+
final class DeclarativeConfigPropertiesBridge extends DeclarativeConfigPropertiesApiBridge
4242
implements ConfigProperties {
4343

4444
DeclarativeConfigPropertiesBridge(

declarative-config-bridge/src/main/java/io/opentelemetry/instrumentation/config/bridge/DeclarativeConfigPropertiesBridgeBuilder.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -90,9 +90,9 @@ public ConfigProperties build(@Nullable DeclarativeConfigProperties node) {
9090
node == null ? empty() : node, mappings, overrideValues);
9191
}
9292

93-
public SimpleDeclarativeConfigPropertiesBridge buildSimple(
93+
public DeclarativeConfigPropertiesApiBridge buildApiBridge(
9494
@Nullable DeclarativeConfigProperties node) {
95-
return new SimpleDeclarativeConfigPropertiesBridge(
95+
return new DeclarativeConfigPropertiesApiBridge(
9696
node == null ? empty() : node, mappings, overrideValues);
9797
}
9898

@@ -112,9 +112,9 @@ public ConfigProperties buildFromInstrumentationConfig(
112112
instrumentationConfig == null ? null : instrumentationConfig.getStructured("java"));
113113
}
114114

115-
public SimpleDeclarativeConfigPropertiesBridge buildSimpleFromInstrumentationConfig(
115+
public DeclarativeConfigPropertiesApiBridge buildApiBridgeFromInstrumentationConfig(
116116
@Nullable DeclarativeConfigProperties instrumentationConfig) {
117-
return buildSimple(
117+
return buildApiBridge(
118118
instrumentationConfig == null ? null : instrumentationConfig.getStructured("java"));
119119
}
120120
}

instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/instrumenter/InstrumenterBuilder.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
import io.opentelemetry.context.Context;
2020
import io.opentelemetry.context.propagation.TextMapGetter;
2121
import io.opentelemetry.context.propagation.TextMapSetter;
22+
import io.opentelemetry.instrumentation.api.internal.ApiConfigProperties;
2223
import io.opentelemetry.instrumentation.api.internal.EmbeddedInstrumentationProperties;
2324
import io.opentelemetry.instrumentation.api.internal.Experimental;
2425
import io.opentelemetry.instrumentation.api.internal.InstrumenterBuilderAccess;
@@ -27,7 +28,6 @@
2728
import io.opentelemetry.instrumentation.api.internal.InternalInstrumenterCustomizerProvider;
2829
import io.opentelemetry.instrumentation.api.internal.InternalInstrumenterCustomizerUtil;
2930
import io.opentelemetry.instrumentation.api.internal.SchemaUrlProvider;
30-
import io.opentelemetry.instrumentation.api.internal.SimpleConfigPropertiesBridge;
3131
import io.opentelemetry.instrumentation.api.internal.SpanKey;
3232
import io.opentelemetry.instrumentation.api.internal.SpanKeyProvider;
3333
import java.util.ArrayList;
@@ -370,7 +370,7 @@ private String getSchemaUrl() {
370370
SpanSuppressor buildSpanSuppressor() {
371371
return new SpanSuppressors.ByContextKey(
372372
SpanSuppressionStrategy.fromConfig(
373-
new SimpleConfigPropertiesBridge(openTelemetry)
373+
new ApiConfigProperties(openTelemetry)
374374
.getString("otel.instrumentation.experimental.span-suppression-strategy"))
375375
.create(getSpanKeysFromAttributesExtractors()));
376376
}
Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@
88
import io.opentelemetry.api.OpenTelemetry;
99
import io.opentelemetry.api.incubator.ExtendedOpenTelemetry;
1010
import io.opentelemetry.api.incubator.config.ConfigProvider;
11+
import io.opentelemetry.instrumentation.config.bridge.DeclarativeConfigPropertiesApiBridge;
1112
import io.opentelemetry.instrumentation.config.bridge.DeclarativeConfigPropertiesBridgeBuilder;
12-
import io.opentelemetry.instrumentation.config.bridge.SimpleDeclarativeConfigPropertiesBridge;
1313
import java.util.Arrays;
1414
import java.util.List;
1515
import java.util.stream.Collectors;
@@ -19,17 +19,17 @@
1919
* This class is internal and is hence not for public use. Its APIs are unstable and can change at
2020
* any time.
2121
*/
22-
public final class SimpleConfigPropertiesBridge {
22+
public final class ApiConfigProperties {
2323

24-
@Nullable private final SimpleDeclarativeConfigPropertiesBridge bridge;
24+
@Nullable private final DeclarativeConfigPropertiesApiBridge bridge;
2525

26-
public SimpleConfigPropertiesBridge(OpenTelemetry openTelemetry) {
26+
public ApiConfigProperties(OpenTelemetry openTelemetry) {
2727
if (openTelemetry instanceof ExtendedOpenTelemetry) {
2828
ExtendedOpenTelemetry extendedOpenTelemetry = (ExtendedOpenTelemetry) openTelemetry;
2929
ConfigProvider configProvider = extendedOpenTelemetry.getConfigProvider();
3030
this.bridge =
3131
new DeclarativeConfigPropertiesBridgeBuilder()
32-
.buildSimpleFromInstrumentationConfig(configProvider.getInstrumentationConfig());
32+
.buildApiBridgeFromInstrumentationConfig(configProvider.getInstrumentationConfig());
3333
} else {
3434
this.bridge = null;
3535
}

instrumentation/aws-sdk/aws-sdk-1.11/library-autoconfigure/src/main/java/io/opentelemetry/instrumentation/awssdk/v1_11/autoconfigure/TracingRequestHandler.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
import com.amazonaws.handlers.RequestHandler2;
1414
import io.opentelemetry.api.GlobalOpenTelemetry;
1515
import io.opentelemetry.api.OpenTelemetry;
16-
import io.opentelemetry.instrumentation.api.internal.SimpleConfigPropertiesBridge;
16+
import io.opentelemetry.instrumentation.api.internal.ApiConfigProperties;
1717
import io.opentelemetry.instrumentation.awssdk.v1_11.AwsSdkTelemetry;
1818

1919
/**
@@ -24,15 +24,15 @@ public class TracingRequestHandler extends RequestHandler2 {
2424
private static final RequestHandler2 DELEGATE = buildDelegate(GlobalOpenTelemetry.get());
2525

2626
private static RequestHandler2 buildDelegate(OpenTelemetry openTelemetry) {
27-
SimpleConfigPropertiesBridge bridge = new SimpleConfigPropertiesBridge(openTelemetry);
27+
ApiConfigProperties config = new ApiConfigProperties(openTelemetry);
2828
return AwsSdkTelemetry.builder(openTelemetry)
2929
.setCaptureExperimentalSpanAttributes(
30-
bridge.getBoolean("otel.instrumentation.aws-sdk.experimental-span-attributes", false))
30+
config.getBoolean("otel.instrumentation.aws-sdk.experimental-span-attributes", false))
3131
.setMessagingReceiveInstrumentationEnabled(
32-
bridge.getBoolean(
32+
config.getBoolean(
3333
"otel.instrumentation.messaging.experimental.receive-telemetry.enabled", false))
3434
.setCapturedHeaders(
35-
bridge.getList(
35+
config.getList(
3636
"otel.instrumentation.messaging.experimental.capture-headers", emptyList()))
3737
.build()
3838
.newRequestHandler();

instrumentation/aws-sdk/aws-sdk-2.2/library-autoconfigure/src/main/java/io/opentelemetry/instrumentation/awssdk/v2_2/autoconfigure/AwsSdkSingletons.java

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
import static java.util.Collections.emptyList;
99

1010
import io.opentelemetry.api.GlobalOpenTelemetry;
11-
import io.opentelemetry.instrumentation.api.internal.SimpleConfigPropertiesBridge;
11+
import io.opentelemetry.instrumentation.api.internal.ApiConfigProperties;
1212
import io.opentelemetry.instrumentation.awssdk.v2_2.AwsSdkTelemetry;
1313
import io.opentelemetry.instrumentation.awssdk.v2_2.internal.AbstractAwsSdkTelemetryFactory;
1414
import java.util.List;
@@ -23,24 +23,23 @@ public static AwsSdkTelemetry telemetry() {
2323

2424
private static class AwsSdkTelemetryFactory extends AbstractAwsSdkTelemetryFactory {
2525

26-
private final SimpleConfigPropertiesBridge bridge =
27-
new SimpleConfigPropertiesBridge(GlobalOpenTelemetry.get());
26+
private final ApiConfigProperties config = new ApiConfigProperties(GlobalOpenTelemetry.get());
2827

2928
@Override
3029
protected List<String> getCapturedHeaders() {
31-
return bridge.getList(
30+
return config.getList(
3231
"otel.instrumentation.messaging.experimental.capture-headers", emptyList());
3332
}
3433

3534
@Override
3635
protected boolean messagingReceiveInstrumentationEnabled() {
37-
return bridge.getBoolean(
36+
return config.getBoolean(
3837
"otel.instrumentation.messaging.experimental.receive-telemetry.enabled", false);
3938
}
4039

4140
@Override
4241
protected boolean getBoolean(String name, boolean defaultValue) {
43-
return bridge.getBoolean(name, defaultValue);
42+
return config.getBoolean(name, defaultValue);
4443
}
4544
}
4645

instrumentation/jdbc/library/src/main/java/io/opentelemetry/instrumentation/jdbc/internal/JdbcInstrumenterFactory.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
import io.opentelemetry.instrumentation.api.instrumenter.AttributesExtractor;
1717
import io.opentelemetry.instrumentation.api.instrumenter.Instrumenter;
1818
import io.opentelemetry.instrumentation.api.instrumenter.SpanKindExtractor;
19-
import io.opentelemetry.instrumentation.api.internal.SimpleConfigPropertiesBridge;
19+
import io.opentelemetry.instrumentation.api.internal.ApiConfigProperties;
2020
import io.opentelemetry.instrumentation.api.semconv.network.ServerAttributesExtractor;
2121
import io.opentelemetry.instrumentation.jdbc.internal.dbinfo.DbInfo;
2222
import java.util.List;
@@ -33,7 +33,7 @@ public final class JdbcInstrumenterFactory {
3333
new JdbcNetworkAttributesGetter();
3434

3535
public static boolean captureQueryParameters(OpenTelemetry openTelemetry) {
36-
return new SimpleConfigPropertiesBridge(openTelemetry)
36+
return new ApiConfigProperties(openTelemetry)
3737
.getBoolean("otel.instrumentation.jdbc.experimental.capture-query-parameters", false);
3838
}
3939

@@ -48,7 +48,7 @@ static Instrumenter<DbRequest, Void> createStatementInstrumenter(
4848
openTelemetry,
4949
emptyList(),
5050
true,
51-
new SimpleConfigPropertiesBridge(openTelemetry)
51+
new ApiConfigProperties(openTelemetry)
5252
.getBoolean("otel.instrumentation.common.db-statement-sanitizer.enabled", true),
5353
captureQueryParameters);
5454
}
@@ -99,7 +99,7 @@ public static Instrumenter<DbRequest, Void> createTransactionInstrumenter(
9999
OpenTelemetry openTelemetry) {
100100
return createTransactionInstrumenter(
101101
openTelemetry,
102-
new SimpleConfigPropertiesBridge(openTelemetry)
102+
new ApiConfigProperties(openTelemetry)
103103
.getBoolean("otel.instrumentation.jdbc.experimental.transaction.enabled", false));
104104
}
105105

instrumentation/kafka/kafka-clients/kafka-clients-2.6/library/src/main/java/io/opentelemetry/instrumentation/kafkaclients/v2_6/TracingConsumerInterceptor.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
import io.opentelemetry.api.GlobalOpenTelemetry;
1212
import io.opentelemetry.api.OpenTelemetry;
1313
import io.opentelemetry.context.Context;
14-
import io.opentelemetry.instrumentation.api.internal.SimpleConfigPropertiesBridge;
14+
import io.opentelemetry.instrumentation.api.internal.ApiConfigProperties;
1515
import io.opentelemetry.instrumentation.api.internal.Timer;
1616
import io.opentelemetry.instrumentation.kafkaclients.common.v0_11.internal.KafkaConsumerContext;
1717
import io.opentelemetry.instrumentation.kafkaclients.common.v0_11.internal.KafkaConsumerContextUtil;
@@ -37,13 +37,13 @@ public class TracingConsumerInterceptor<K, V> implements ConsumerInterceptor<K,
3737

3838
private static KafkaTelemetry buildTelemetry() {
3939
OpenTelemetry openTelemetry = GlobalOpenTelemetry.get();
40-
SimpleConfigPropertiesBridge bridge = new SimpleConfigPropertiesBridge(openTelemetry);
40+
ApiConfigProperties config = new ApiConfigProperties(openTelemetry);
4141
return KafkaTelemetry.builder(openTelemetry)
4242
.setMessagingReceiveInstrumentationEnabled(
43-
bridge.getBoolean(
43+
config.getBoolean(
4444
"otel.instrumentation.messaging.experimental.receive-telemetry.enabled", false))
4545
.setCapturedHeaders(
46-
bridge.getList(
46+
config.getList(
4747
"otel.instrumentation.messaging.experimental.capture-headers", emptyList()))
4848
.build();
4949
}

0 commit comments

Comments
 (0)