Skip to content

Commit 516aafa

Browse files
committed
refactor: clean up AsyncHttpClientHelper interface
1 parent c1887ae commit 516aafa

File tree

3 files changed

+1
-6
lines changed

3 files changed

+1
-6
lines changed

instrumentation/async-http-client/async-http-client-1-common/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/asynchttpclient/common/AsyncHttpClientHelper.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,6 @@
88
import com.ning.http.client.Request;
99
import javax.annotation.Nullable;
1010

11-
/**
12-
* Helper interface to abstract away differences between AsyncHttpClient versions. This allows
13-
* sharing common instrumentation code while handling version-specific API differences.
14-
*/
1511
public interface AsyncHttpClientHelper {
1612

1713
/**

instrumentation/async-http-client/async-http-client-1-common/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/asynchttpclient/common/ResponseInstrumentation.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,6 @@ public static Scope onEnter(
9393
}
9494
asyncHandlerDataField.set(handler, null);
9595

96-
// Get instrumenter directly from data - much cleaner!
9796
Instrumenter<Request, Response> instrumenter = data.getInstrumenter();
9897
if (instrumenter != null) {
9998
instrumenter.end(data.getContext(), data.getRequest(), null, throwable);

settings.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -189,9 +189,9 @@ include(":instrumentation:armeria:armeria-1.3:javaagent")
189189
include(":instrumentation:armeria:armeria-1.3:library")
190190
include(":instrumentation:armeria:armeria-1.3:testing")
191191
include(":instrumentation:armeria:armeria-grpc-1.14:javaagent")
192-
include(":instrumentation:async-http-client:async-http-client-1-common:javaagent")
193192
include(":instrumentation:async-http-client:async-http-client-1.8:javaagent")
194193
include(":instrumentation:async-http-client:async-http-client-1.9:javaagent")
194+
include(":instrumentation:async-http-client:async-http-client-1-common:javaagent")
195195
include(":instrumentation:async-http-client:async-http-client-2.0:javaagent")
196196
include(":instrumentation:avaje-jex-3.0:javaagent")
197197
include(":instrumentation:aws-lambda:aws-lambda-core-1.0:javaagent")

0 commit comments

Comments
 (0)