Skip to content

Commit 54ef7dd

Browse files
committed
Add missing getDbQuerySummary implementations
- GeodeDbAttributesGetter - LettuceDbAttributesGetter (lettuce-4.0) - ElasticsearchDbAttributesGetter These were missed when making the method required in DbClientAttributesGetter.
1 parent ab88b97 commit 54ef7dd

File tree

4 files changed

+61
-0
lines changed

4 files changed

+61
-0
lines changed

CI-PLAN.md

Lines changed: 43 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,43 @@
1+
# CI Failure Analysis Plan
2+
3+
## Failed Jobs Summary
4+
- Job: common / build (job ID: 57499706578)
5+
- Job: common / test0 (8, hotspot, indy false) (job ID: 57499706684)
6+
- Job: common / test1 (8, hotspot, indy false) (job ID: 57499706703)
7+
- Job: common / test2 (8, hotspot, indy false) (job ID: 57499706690)
8+
- Job: common / test3 (8, hotspot, indy false) (job ID: 57499706695)
9+
- Job: muzzle / muzzle (:instrumentation:muzzle1) (job ID: 57499706560)
10+
- Note: All test jobs across Java 8/11/17/21/25 versions failed with compilation errors
11+
- Note: Spotless job excluded from analysis (formatting only)
12+
13+
## Unique Failed Gradle Tasks
14+
**Note**: Spotless tasks are excluded from this analysis as they are formatting-only checks.
15+
16+
- [x] Task: :instrumentation:geode-1.4:javaagent:compileJava
17+
- Seen in: common / build
18+
- Log files: /tmp/common-build.log
19+
- Error: GeodeDbAttributesGetter does not override abstract method getDbQuerySummary(GeodeRequest)
20+
- Fixed: Added getDbQuerySummary method returning null
21+
22+
- [x] Task: :instrumentation:lettuce:lettuce-4.0:javaagent:compileJava
23+
- Seen in: common / test0
24+
- Log files: /tmp/test0-java8-indy-false.log
25+
- Error: LettuceDbAttributesGetter does not override abstract method getDbQuerySummary(RedisCommand)
26+
- Fixed: Added getDbQuerySummary method returning null
27+
28+
- [x] Task: :instrumentation:elasticsearch:elasticsearch-rest-common-5.0:library:compileJava
29+
- Seen in: common / test1, test2, test3, muzzle1
30+
- Log files: /tmp/test1-java8-indy-false.log, /tmp/test2-java8-indy-false.log, /tmp/test3-java8-indy-false.log, /tmp/muzzle1.log
31+
- Error: ElasticsearchDbAttributesGetter does not override abstract method getDbQuerySummary(ElasticsearchRestRequest)
32+
- Fixed: Added getDbQuerySummary method returning null
33+
34+
## Notes
35+
36+
The root cause is that when making `getDbQueryText`, `getDbQuerySummary`, and `getDbOperationName` required abstract methods in `DbClientAttributesGetter`, several implementations were not providing all three methods.
37+
38+
The failing implementations are:
39+
1. GeodeDbAttributesGetter - missing getDbQuerySummary
40+
2. LettuceDbAttributesGetter (lettuce-4.0) - missing getDbQuerySummary
41+
3. ElasticsearchDbAttributesGetter - missing getDbQuerySummary
42+
43+
These implementations need to add the missing method(s) returning null to satisfy the interface contract.

instrumentation/elasticsearch/elasticsearch-rest-common-5.0/library/src/main/java/io/opentelemetry/instrumentation/elasticsearch/rest/common/v5_0/internal/ElasticsearchDbAttributesGetter.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,12 @@ public String getDbOperationName(ElasticsearchRestRequest request) {
8080
return endpointDefinition != null ? endpointDefinition.getEndpointName() : null;
8181
}
8282

83+
@Override
84+
@Nullable
85+
public String getDbQuerySummary(ElasticsearchRestRequest request) {
86+
return null;
87+
}
88+
8389
@Nullable
8490
@Override
8591
public String getResponseStatusCode(@Nullable Response response, @Nullable Throwable error) {

instrumentation/geode-1.4/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/geode/GeodeDbAttributesGetter.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,12 @@ public String getDbQueryText(GeodeRequest request) {
3535
return sanitizer.sanitize(request.getQuery()).getFullStatement();
3636
}
3737

38+
@Override
39+
@Nullable
40+
public String getDbQuerySummary(GeodeRequest request) {
41+
return null;
42+
}
43+
3844
@Override
3945
@Nullable
4046
public String getDbOperationName(GeodeRequest request) {

instrumentation/lettuce/lettuce-4.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/lettuce/v4_0/LettuceDbAttributesGetter.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,12 @@ public String getDbQueryText(RedisCommand<?, ?, ?> request) {
3131
return null;
3232
}
3333

34+
@Override
35+
@Nullable
36+
public String getDbQuerySummary(RedisCommand<?, ?, ?> request) {
37+
return null;
38+
}
39+
3440
@Override
3541
@Nullable
3642
public String getDbOperationName(RedisCommand<?, ?, ?> request) {

0 commit comments

Comments
 (0)