Skip to content

Commit 553fbb3

Browse files
authored
Add body to http server concurrency test response (#13540)
1 parent 55e84f9 commit 553fbb3

File tree

31 files changed

+67
-51
lines changed

31 files changed

+67
-51
lines changed

instrumentation/akka/akka-http-10.0/javaagent/src/test/scala/io/opentelemetry/javaagent/instrumentation/akkahttp/AkkaHttpTestAsyncWebServer.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ object AkkaHttpTestAsyncWebServer {
4343
override def getParameter(name: String): String =
4444
uri.query().get(name).orNull
4545
})
46-
resp.withEntity("")
46+
resp.withEntity(endpoint.getBody)
4747
case QUERY_PARAM => resp.withEntity(uri.queryString().orNull)
4848
case REDIRECT =>
4949
resp.withHeaders(headers.Location(endpoint.getBody))

instrumentation/akka/akka-http-10.0/javaagent/src/test/scala/io/opentelemetry/javaagent/instrumentation/akkahttp/AkkaHttpTestSyncWebServer.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ object AkkaHttpTestSyncWebServer {
4040
override def getParameter(name: String): String =
4141
uri.query().get(name).orNull
4242
})
43-
resp.withEntity("")
43+
resp.withEntity(endpoint.getBody)
4444
case QUERY_PARAM => resp.withEntity(uri.queryString().orNull)
4545
case REDIRECT =>
4646
resp.withHeaders(headers.Location(endpoint.getBody))

instrumentation/akka/akka-http-10.0/javaagent/src/test/scala/io/opentelemetry/javaagent/instrumentation/akkahttp/AkkaHttpTestWebServer.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ object AkkaHttpTestWebServer {
3838
override def getParameter(name: String): String =
3939
map.get(name).orNull
4040
})
41-
""
41+
INDEXED_CHILD.getBody
4242
}
4343
}
4444
complete(AbstractHttpServerTest.controller(INDEXED_CHILD, supplier))

instrumentation/finagle-http-23.11/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/finaglehttp/v23_11/AbstractServerTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ public Future<Response> apply(Request request) {
7474
name ->
7575
new QueryStringDecoder(uri)
7676
.parameters().get(name).stream().findFirst().orElse(""));
77-
response.content(Buf.Empty());
77+
response.content(Buf.Utf8$.MODULE$.apply(endpoint.getBody()));
7878
} else if (QUERY_PARAM.equals(endpoint)) {
7979
response.content(Buf.Utf8$.MODULE$.apply(uri.getQuery()));
8080
} else if (REDIRECT.equals(endpoint)) {

instrumentation/grizzly-2.3/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/grizzly/GrizzlyTest.java

Lines changed: 6 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
import io.opentelemetry.instrumentation.testing.junit.http.HttpServerInstrumentationExtension;
2121
import io.opentelemetry.instrumentation.testing.junit.http.HttpServerTestOptions;
2222
import io.opentelemetry.instrumentation.testing.junit.http.ServerEndpoint;
23-
import java.io.IOException;
2423
import java.util.HashSet;
2524
import java.util.Set;
2625
import org.glassfish.grizzly.http.server.HttpHandler;
@@ -52,33 +51,18 @@ public void service(Request request, Response response) throws Exception {
5251
endpoint,
5352
() -> {
5453
if (endpoint.equals(SUCCESS)) {
55-
try {
56-
response.getWriter().write(endpoint.getBody());
57-
} catch (IOException e) {
58-
throw new RuntimeException(e);
59-
}
54+
response.getWriter().write(endpoint.getBody());
6055
} else if (endpoint.equals(INDEXED_CHILD)) {
61-
response.setStatus(endpoint.getStatus());
6256
endpoint.collectSpanAttributes(request::getParameter);
57+
response.setStatus(endpoint.getStatus());
58+
response.getWriter().write(endpoint.getBody());
6359
} else if (endpoint.equals(QUERY_PARAM)) {
6460
response.setStatus(endpoint.getStatus());
65-
try {
66-
response.getWriter().write(request.getQueryString());
67-
} catch (IOException e) {
68-
throw new RuntimeException(e);
69-
}
61+
response.getWriter().write(request.getQueryString());
7062
} else if (endpoint.equals(REDIRECT)) {
71-
try {
72-
response.sendRedirect(endpoint.getBody());
73-
} catch (IOException e) {
74-
throw new RuntimeException(e);
75-
}
63+
response.sendRedirect(endpoint.getBody());
7664
} else if (endpoint.equals(ERROR)) {
77-
try {
78-
response.sendError(endpoint.getStatus(), endpoint.getBody());
79-
} catch (IOException e) {
80-
throw new RuntimeException(e);
81-
}
65+
response.sendError(endpoint.getStatus(), endpoint.getBody());
8266
} else if (endpoint.equals(NOT_FOUND)) {
8367
response.setStatus(endpoint.getStatus());
8468
} else if (endpoint.equals(EXCEPTION)) {

instrumentation/jaxrs/jaxrs-2.0/jaxrs-2.0-common/testing/src/main/java/io/opentelemetry/instrumentation/jaxrs/v2_0/test/JaxRsTestResource.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ public void indexed_child(@Context UriInfo uriInfo, @Suspended AsyncResponse res
105105
INDEXED_CHILD,
106106
() -> {
107107
INDEXED_CHILD.collectSpanAttributes(parameters::getFirst);
108-
response.resume("");
108+
response.resume(INDEXED_CHILD.getBody());
109109
}));
110110
}
111111

instrumentation/jaxrs/jaxrs-3.0/jaxrs-3.0-common/testing/src/main/java/io/opentelemetry/instrumentation/jaxrs/v3_0/test/JaxRsTestResource.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ public void indexed_child(@Context UriInfo uriInfo, @Suspended AsyncResponse res
105105
INDEXED_CHILD,
106106
() -> {
107107
INDEXED_CHILD.collectSpanAttributes(parameters::getFirst);
108-
response.resume("");
108+
response.resume(INDEXED_CHILD.getBody());
109109
}));
110110
}
111111

instrumentation/netty/netty-3.8/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/netty/v3_8/server/Netty38ServerTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,8 @@ public void messageReceived(ChannelHandlerContext ctx, MessageEvent msg) {
127127
HTTP_1_1, HttpResponseStatus.valueOf(endpoint.getStatus()));
128128
response.setContent(responseContent);
129129
} else if (INDEXED_CHILD.equals(endpoint)) {
130-
responseContent = ChannelBuffers.EMPTY_BUFFER;
130+
responseContent =
131+
ChannelBuffers.copiedBuffer(endpoint.getBody(), CharsetUtil.UTF_8);
131132
endpoint.collectSpanAttributes(
132133
name ->
133134
new QueryStringDecoder(uri)

instrumentation/netty/netty-4.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/netty/v4_0/server/Netty40ServerTest.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,9 @@ protected void channelRead0(ChannelHandlerContext ctx, Object msg)
106106
HttpResponseStatus.valueOf(endpoint.getStatus()),
107107
content);
108108
} else if (endpoint.equals(INDEXED_CHILD)) {
109-
content = Unpooled.EMPTY_BUFFER;
109+
content =
110+
Unpooled.copiedBuffer(
111+
endpoint.getBody(), CharsetUtil.UTF_8);
110112
endpoint.collectSpanAttributes(
111113
it ->
112114
new QueryStringDecoder(uri)

instrumentation/netty/netty-4.1/testing/src/main/java/io/opentelemetry/instrumentation/netty/v4_1/AbstractNetty41ServerTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ private static Object handle(HttpRequest request, URI uri, ServerEndpoint endpoi
117117
new DefaultFullHttpResponse(
118118
HTTP_1_1, HttpResponseStatus.valueOf(endpoint.getStatus()), content);
119119
} else if (INDEXED_CHILD.equals(endpoint)) {
120-
content = Unpooled.EMPTY_BUFFER;
120+
content = Unpooled.copiedBuffer(endpoint.getBody(), CharsetUtil.UTF_8);
121121
endpoint.collectSpanAttributes(
122122
name ->
123123
new QueryStringDecoder(uri).parameters().get(name).stream().findFirst().orElse(""));

0 commit comments

Comments
 (0)