Skip to content

Commit 5a78cc4

Browse files
committed
fix tests
1 parent 3e2a20c commit 5a78cc4

File tree

3 files changed

+15
-9
lines changed

3 files changed

+15
-9
lines changed

instrumentation/kafka/kafka-streams-0.11/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/kafkastreams/KafkaStreamsBaseTest.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,9 @@ abstract class KafkaStreamsBaseTest {
6060
static Consumer<Integer, String> consumer;
6161
static CountDownLatch consumerReady = new CountDownLatch(1);
6262

63+
protected static final boolean isExperimental =
64+
Boolean.getBoolean("otel.instrumentation.kafka.experimental-span-attributes");
65+
6366
@BeforeAll
6467
static void setup() throws ExecutionException, InterruptedException, TimeoutException {
6568
kafka =

instrumentation/kafka/kafka-streams-0.11/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/kafkastreams/KafkaStreamsDefaultTest.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,9 +48,6 @@
4848

4949
class KafkaStreamsDefaultTest extends KafkaStreamsBaseTest {
5050

51-
private static final boolean isExperimental =
52-
Boolean.getBoolean("otel.instrumentation.kafka.experimental-span-attributes");
53-
5451
@SuppressWarnings("deprecation") // using deprecated semconv
5552
@DisplayName("test kafka produce and consume with streams in-between")
5653
@Test

instrumentation/kafka/kafka-streams-0.11/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/kafkastreams/KafkaStreamsSuppressReceiveSpansTest.java

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -124,10 +124,13 @@ void testKafkaProduceAndConsumeWithStreamsInBetween() throws Exception {
124124
k -> k.isInstanceOf(String.class)),
125125
equalTo(MESSAGING_KAFKA_MESSAGE_OFFSET, 0),
126126
equalTo(MESSAGING_KAFKA_MESSAGE_KEY, "10"),
127-
satisfies(
128-
longKey("kafka.record.queue_time_ms"),
129-
k -> k.isGreaterThanOrEqualTo(0)),
130127
equalTo(stringKey("asdf"), "testing")));
128+
if (isExperimental) {
129+
assertions.add(
130+
satisfies(
131+
longKey("kafka.record.queue_time_ms"),
132+
k -> k.isGreaterThanOrEqualTo(0)));
133+
}
131134
if (Boolean.getBoolean("testLatestDeps")) {
132135
assertions.add(equalTo(MESSAGING_KAFKA_CONSUMER_GROUP, "test-application"));
133136
}
@@ -170,10 +173,13 @@ void testKafkaProduceAndConsumeWithStreamsInBetween() throws Exception {
170173
k -> k.isInstanceOf(String.class)),
171174
equalTo(MESSAGING_KAFKA_MESSAGE_OFFSET, 0),
172175
equalTo(MESSAGING_KAFKA_MESSAGE_KEY, "10"),
173-
satisfies(
174-
longKey("kafka.record.queue_time_ms"),
175-
k -> k.isGreaterThanOrEqualTo(0)),
176176
equalTo(longKey("testing"), 123)));
177+
if (isExperimental) {
178+
assertions.add(
179+
satisfies(
180+
longKey("kafka.record.queue_time_ms"),
181+
k -> k.isGreaterThanOrEqualTo(0)));
182+
}
177183
if (Boolean.getBoolean("testLatestDeps")) {
178184
assertions.add(equalTo(MESSAGING_KAFKA_CONSUMER_GROUP, "test"));
179185
}

0 commit comments

Comments
 (0)