Skip to content

Commit 5a9814d

Browse files
committed
fix rebase
1 parent 7c79383 commit 5a9814d

File tree

17 files changed

+59
-78
lines changed

17 files changed

+59
-78
lines changed

instrumentation/akka/akka-http-10.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/akkahttp/server/AkkaHttpServerSingletons.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,20 +8,19 @@
88
import akka.http.scaladsl.model.HttpRequest;
99
import akka.http.scaladsl.model.HttpResponse;
1010
import io.opentelemetry.instrumentation.api.instrumenter.Instrumenter;
11-
import io.opentelemetry.javaagent.bootstrap.internal.JavaagentHttpServerInstrumenterBuilder;
11+
import io.opentelemetry.javaagent.bootstrap.internal.JavaagentHttpServerInstrumenters;
1212
import io.opentelemetry.javaagent.instrumentation.akkahttp.AkkaHttpUtil;
13-
import java.util.Optional;
1413

1514
public final class AkkaHttpServerSingletons {
1615

1716
private static final Instrumenter<HttpRequest, HttpResponse> INSTRUMENTER;
1817

1918
static {
2019
INSTRUMENTER =
21-
JavaagentHttpServerInstrumenterBuilder.create(
20+
JavaagentHttpServerInstrumenters.create(
2221
AkkaHttpUtil.instrumentationName(),
2322
new AkkaHttpServerAttributesGetter(),
24-
Optional.of(AkkaHttpServerHeaders.INSTANCE));
23+
AkkaHttpServerHeaders.INSTANCE);
2524
}
2625

2726
public static Instrumenter<HttpRequest, HttpResponse> instrumenter() {

instrumentation/grizzly-2.3/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/grizzly/GrizzlySingletons.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,8 @@
66
package io.opentelemetry.javaagent.instrumentation.grizzly;
77

88
import io.opentelemetry.instrumentation.api.instrumenter.Instrumenter;
9-
import io.opentelemetry.javaagent.bootstrap.internal.JavaagentHttpServerInstrumenterBuilder;
9+
import io.opentelemetry.javaagent.bootstrap.internal.JavaagentHttpServerInstrumenters;
1010
import io.opentelemetry.javaagent.bootstrap.servlet.AppServerBridge;
11-
import java.util.Optional;
1211
import org.glassfish.grizzly.http.HttpRequestPacket;
1312
import org.glassfish.grizzly.http.HttpResponsePacket;
1413

@@ -18,10 +17,10 @@ public final class GrizzlySingletons {
1817

1918
static {
2019
INSTRUMENTER =
21-
JavaagentHttpServerInstrumenterBuilder.createWithCustomizer(
20+
JavaagentHttpServerInstrumenters.create(
2221
"io.opentelemetry.grizzly-2.3",
2322
new GrizzlyHttpAttributesGetter(),
24-
Optional.of(HttpRequestHeadersGetter.INSTANCE),
23+
HttpRequestHeadersGetter.INSTANCE,
2524
builder ->
2625
builder
2726
.addContextCustomizer(

instrumentation/jetty/jetty-12.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/jetty/v12_0/Jetty12Singletons.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,8 @@
66
package io.opentelemetry.javaagent.instrumentation.jetty.v12_0;
77

88
import io.opentelemetry.instrumentation.api.instrumenter.Instrumenter;
9-
import io.opentelemetry.javaagent.bootstrap.internal.JavaagentHttpServerInstrumenterBuilder;
9+
import io.opentelemetry.javaagent.bootstrap.internal.JavaagentHttpServerInstrumenters;
1010
import io.opentelemetry.javaagent.bootstrap.servlet.AppServerBridge;
11-
import java.util.Optional;
1211
import org.eclipse.jetty.server.Request;
1312
import org.eclipse.jetty.server.Response;
1413

@@ -19,10 +18,10 @@ public final class Jetty12Singletons {
1918

2019
static {
2120
INSTRUMENTER =
22-
JavaagentHttpServerInstrumenterBuilder.createWithCustomizer(
21+
JavaagentHttpServerInstrumenters.create(
2322
INSTRUMENTATION_NAME,
2423
new Jetty12HttpAttributesGetter(),
25-
Optional.of(Jetty12TextMapGetter.INSTANCE),
24+
Jetty12TextMapGetter.INSTANCE,
2625
builder ->
2726
builder.addContextCustomizer(
2827
(context, request, attributes) ->

instrumentation/liberty/liberty-dispatcher-20.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/liberty/dispatcher/LibertyDispatcherSingletons.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,7 @@
66
package io.opentelemetry.javaagent.instrumentation.liberty.dispatcher;
77

88
import io.opentelemetry.instrumentation.api.instrumenter.Instrumenter;
9-
import io.opentelemetry.javaagent.bootstrap.internal.JavaagentHttpServerInstrumenterBuilder;
10-
import java.util.Optional;
9+
import io.opentelemetry.javaagent.bootstrap.internal.JavaagentHttpServerInstrumenters;
1110

1211
public final class LibertyDispatcherSingletons {
1312
private static final String INSTRUMENTATION_NAME = "io.opentelemetry.liberty-dispatcher-20.0";
@@ -16,10 +15,10 @@ public final class LibertyDispatcherSingletons {
1615

1716
static {
1817
INSTRUMENTER =
19-
JavaagentHttpServerInstrumenterBuilder.create(
18+
JavaagentHttpServerInstrumenters.create(
2019
INSTRUMENTATION_NAME,
2120
new LibertyDispatcherHttpAttributesGetter(),
22-
Optional.of(LibertyDispatcherRequestGetter.INSTANCE));
21+
LibertyDispatcherRequestGetter.INSTANCE);
2322
}
2423

2524
public static Instrumenter<LibertyRequest, LibertyResponse> instrumenter() {

instrumentation/netty/netty-3.8/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/netty/v3_8/server/NettyServerSingletons.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,8 @@
77

88
import io.opentelemetry.instrumentation.api.instrumenter.Instrumenter;
99
import io.opentelemetry.instrumentation.netty.common.internal.NettyErrorHolder;
10-
import io.opentelemetry.javaagent.bootstrap.internal.JavaagentHttpServerInstrumenterBuilder;
10+
import io.opentelemetry.javaagent.bootstrap.internal.JavaagentHttpServerInstrumenters;
1111
import io.opentelemetry.javaagent.instrumentation.netty.v3_8.HttpRequestAndChannel;
12-
import java.util.Optional;
1312
import org.jboss.netty.handler.codec.http.HttpResponse;
1413

1514
final class NettyServerSingletons {
@@ -18,10 +17,10 @@ final class NettyServerSingletons {
1817

1918
static {
2019
INSTRUMENTER =
21-
JavaagentHttpServerInstrumenterBuilder.createWithCustomizer(
20+
JavaagentHttpServerInstrumenters.create(
2221
"io.opentelemetry.netty-3.8",
2322
new NettyHttpServerAttributesGetter(),
24-
Optional.of(NettyHeadersGetter.INSTANCE),
23+
NettyHeadersGetter.INSTANCE,
2524
builder ->
2625
builder.addContextCustomizer(
2726
(context, requestAndChannel, startAttributes) ->

instrumentation/netty/netty-4-common/library/src/main/java/io/opentelemetry/instrumentation/netty/v4/common/internal/client/NettyClientInstrumenterBuilder.java

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
import io.opentelemetry.instrumentation.api.incubator.builder.internal.DefaultHttpClientInstrumenterBuilder;
1212
import io.opentelemetry.instrumentation.api.incubator.semconv.net.PeerServiceResolver;
1313
import io.opentelemetry.instrumentation.netty.v4.common.HttpRequestAndChannel;
14-
import java.util.Optional;
1514

1615
/**
1716
* This class is internal and is hence not for public use. Its APIs are unstable and can change at
@@ -22,11 +21,8 @@ public class NettyClientInstrumenterBuilder
2221
private PeerServiceResolver peerServiceResolver;
2322

2423
public NettyClientInstrumenterBuilder(String instrumentationName, OpenTelemetry openTelemetry) {
25-
super(
26-
instrumentationName,
27-
openTelemetry,
28-
new NettyHttpClientAttributesGetter(),
29-
Optional.of(HttpRequestHeadersSetter.INSTANCE));
24+
super(instrumentationName, openTelemetry, new NettyHttpClientAttributesGetter());
25+
setHeaderSetter(HttpRequestHeadersSetter.INSTANCE);
3026
}
3127

3228
@CanIgnoreReturnValue

instrumentation/netty/netty-4.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/netty/v4_0/server/NettyServerSingletons.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,16 +11,15 @@
1111
import io.opentelemetry.instrumentation.netty.v4.common.HttpRequestAndChannel;
1212
import io.opentelemetry.instrumentation.netty.v4.common.internal.server.HttpRequestHeadersGetter;
1313
import io.opentelemetry.instrumentation.netty.v4.common.internal.server.NettyHttpServerAttributesGetter;
14-
import io.opentelemetry.javaagent.bootstrap.internal.JavaagentHttpServerInstrumenterBuilder;
15-
import java.util.Optional;
14+
import io.opentelemetry.javaagent.bootstrap.internal.JavaagentHttpServerInstrumenters;
1615

1716
public final class NettyServerSingletons {
1817

1918
private static final Instrumenter<HttpRequestAndChannel, HttpResponse> INSTRUMENTER =
20-
JavaagentHttpServerInstrumenterBuilder.createWithCustomizer(
19+
JavaagentHttpServerInstrumenters.create(
2120
"io.opentelemetry.netty-4.0",
2221
new NettyHttpServerAttributesGetter(),
23-
Optional.of(HttpRequestHeadersGetter.INSTANCE),
22+
HttpRequestHeadersGetter.INSTANCE,
2423
builder ->
2524
builder.addContextCustomizer(
2625
(context, requestAndChannel, startAttributes) -> NettyErrorHolder.init(context)));

instrumentation/pekko/pekko-http-1.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/pekkohttp/v1_0/server/PekkoHttpServerSingletons.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,8 @@
66
package io.opentelemetry.javaagent.instrumentation.pekkohttp.v1_0.server;
77

88
import io.opentelemetry.instrumentation.api.instrumenter.Instrumenter;
9-
import io.opentelemetry.javaagent.bootstrap.internal.JavaagentHttpServerInstrumenterBuilder;
9+
import io.opentelemetry.javaagent.bootstrap.internal.JavaagentHttpServerInstrumenters;
1010
import io.opentelemetry.javaagent.instrumentation.pekkohttp.v1_0.PekkoHttpUtil;
11-
import java.util.Optional;
1211
import org.apache.pekko.http.scaladsl.model.HttpRequest;
1312
import org.apache.pekko.http.scaladsl.model.HttpResponse;
1413

@@ -18,10 +17,10 @@ public final class PekkoHttpServerSingletons {
1817

1918
static {
2019
INSTRUMENTER =
21-
JavaagentHttpServerInstrumenterBuilder.create(
20+
JavaagentHttpServerInstrumenters.create(
2221
PekkoHttpUtil.instrumentationName(),
2322
new PekkoHttpServerAttributesGetter(),
24-
Optional.of(PekkoHttpServerHeaders.INSTANCE));
23+
PekkoHttpServerHeaders.INSTANCE);
2524
}
2625

2726
public static Instrumenter<HttpRequest, HttpResponse> instrumenter() {

instrumentation/restlet/restlet-1.1/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/restlet/v1_1/RestletSingletons.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
import io.opentelemetry.instrumentation.api.instrumenter.Instrumenter;
1010
import io.opentelemetry.instrumentation.api.semconv.http.HttpServerRouteGetter;
1111
import io.opentelemetry.instrumentation.restlet.v1_1.RestletTelemetry;
12-
import io.opentelemetry.javaagent.bootstrap.internal.JavaagentHttpServerInstrumenterBuilder;
12+
import io.opentelemetry.javaagent.bootstrap.internal.JavaagentHttpServerInstrumenters;
1313
import io.opentelemetry.javaagent.bootstrap.servlet.ServletContextPath;
1414
import org.restlet.data.Request;
1515
import org.restlet.data.Response;
@@ -20,7 +20,7 @@ public final class RestletSingletons {
2020

2121
static {
2222
INSTRUMENTER =
23-
JavaagentHttpServerInstrumenterBuilder.create(
23+
JavaagentHttpServerInstrumenters.create(
2424
RestletTelemetry.builder(GlobalOpenTelemetry.get()));
2525
}
2626

instrumentation/restlet/restlet-2.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/restlet/v2_0/RestletSingletons.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,16 +9,15 @@
99
import io.opentelemetry.instrumentation.api.instrumenter.Instrumenter;
1010
import io.opentelemetry.instrumentation.api.semconv.http.HttpServerRouteGetter;
1111
import io.opentelemetry.instrumentation.restlet.v2_0.RestletTelemetry;
12-
import io.opentelemetry.javaagent.bootstrap.internal.JavaagentHttpServerInstrumenterBuilder;
12+
import io.opentelemetry.javaagent.bootstrap.internal.JavaagentHttpServerInstrumenters;
1313
import io.opentelemetry.javaagent.bootstrap.servlet.ServletContextPath;
1414
import org.restlet.Request;
1515
import org.restlet.Response;
1616

1717
public final class RestletSingletons {
1818

1919
private static final Instrumenter<Request, Response> INSTRUMENTER =
20-
JavaagentHttpServerInstrumenterBuilder.create(
21-
RestletTelemetry.create(GlobalOpenTelemetry.get()));
20+
JavaagentHttpServerInstrumenters.create(RestletTelemetry.create(GlobalOpenTelemetry.get()));
2221

2322
public static Instrumenter<Request, Response> instrumenter() {
2423
return INSTRUMENTER;

0 commit comments

Comments
 (0)