Skip to content

Commit 5b99c27

Browse files
committed
Moving VirtualField.find()
1 parent 0cda82f commit 5b99c27

File tree

2 files changed

+9
-7
lines changed

2 files changed

+9
-7
lines changed

instrumentation/undertow-1.4/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/undertow/HttpServerExchangeInstrumentation.java

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,11 @@
55

66
package io.opentelemetry.javaagent.instrumentation.undertow;
77

8+
import static io.opentelemetry.javaagent.instrumentation.undertow.UndertowSingletons.RUNNABLE_PROPAGATED_CONTEXT;
89
import static net.bytebuddy.matcher.ElementMatchers.named;
910
import static net.bytebuddy.matcher.ElementMatchers.takesArguments;
1011

1112
import io.opentelemetry.context.Context;
12-
import io.opentelemetry.instrumentation.api.util.VirtualField;
1313
import io.opentelemetry.javaagent.bootstrap.Java8BytecodeBridge;
1414
import io.opentelemetry.javaagent.bootstrap.executors.ExecutorAdviceHelper;
1515
import io.opentelemetry.javaagent.bootstrap.executors.PropagatedContext;
@@ -41,9 +41,7 @@ public static class DispatchAdvice {
4141
public static PropagatedContext enterJobSubmit(@Advice.Argument(1) Runnable task) {
4242
Context context = Java8BytecodeBridge.currentContext();
4343
if (ExecutorAdviceHelper.shouldPropagateContext(context, task)) {
44-
VirtualField<Runnable, PropagatedContext> virtualField =
45-
VirtualField.find(Runnable.class, PropagatedContext.class);
46-
return ExecutorAdviceHelper.attachContextToTask(context, virtualField, task);
44+
return ExecutorAdviceHelper.attachContextToTask(context, RUNNABLE_PROPAGATED_CONTEXT, task);
4745
}
4846
return null;
4947
}
@@ -53,9 +51,8 @@ public static void exitJobSubmit(
5351
@Advice.Argument(1) Runnable task,
5452
@Advice.Enter PropagatedContext propagatedContext,
5553
@Advice.Thrown Throwable throwable) {
56-
VirtualField<Runnable, PropagatedContext> virtualField =
57-
VirtualField.find(Runnable.class, PropagatedContext.class);
58-
ExecutorAdviceHelper.cleanUpAfterSubmit(propagatedContext, throwable, virtualField, task);
54+
ExecutorAdviceHelper.cleanUpAfterSubmit(
55+
propagatedContext, throwable, RUNNABLE_PROPAGATED_CONTEXT, task);
5956
}
6057
}
6158
}

instrumentation/undertow-1.4/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/undertow/UndertowSingletons.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@
66
package io.opentelemetry.javaagent.instrumentation.undertow;
77

88
import io.opentelemetry.instrumentation.api.instrumenter.Instrumenter;
9+
import io.opentelemetry.instrumentation.api.util.VirtualField;
10+
import io.opentelemetry.javaagent.bootstrap.executors.PropagatedContext;
911
import io.opentelemetry.javaagent.bootstrap.internal.JavaagentHttpServerInstrumenters;
1012
import io.opentelemetry.javaagent.bootstrap.servlet.AppServerBridge;
1113
import io.opentelemetry.javaagent.bootstrap.undertow.UndertowActiveHandlers;
@@ -16,6 +18,9 @@ public final class UndertowSingletons {
1618

1719
private static final Instrumenter<HttpServerExchange, HttpServerExchange> INSTRUMENTER;
1820

21+
public static final VirtualField<Runnable, PropagatedContext> RUNNABLE_PROPAGATED_CONTEXT =
22+
VirtualField.find(Runnable.class, PropagatedContext.class);
23+
1924
static {
2025
INSTRUMENTER =
2126
JavaagentHttpServerInstrumenters.create(

0 commit comments

Comments
 (0)