Skip to content

Commit 5ba6965

Browse files
committed
fix naming
1 parent cb24c1e commit 5ba6965

File tree

4 files changed

+13
-365
lines changed

4 files changed

+13
-365
lines changed

instrumentation-docs/src/main/java/io/opentelemetry/instrumentation/docs/internal/TelemetryMerger.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ public static MergedTelemetryData merge(
4444
return convertManualTelemetryOnly(manualTelemetry);
4545
}
4646

47-
return mergeManualAndAutoGenerated(
47+
return mergeManualAndEmitted(
4848
manualTelemetry, emittedMetrics, emittedSpans, instrumentationName);
4949
}
5050

@@ -75,13 +75,13 @@ private static MergedTelemetryData convertManualTelemetryOnly(
7575
* Merges manual telemetry with emitted telemetry, deduplicating by name within the same 'when'
7676
* condition.
7777
*/
78-
private static MergedTelemetryData mergeManualAndAutoGenerated(
78+
private static MergedTelemetryData mergeManualAndEmitted(
7979
List<ManualTelemetryEntry> manualTelemetry,
8080
Map<String, List<EmittedMetrics.Metric>> emittedMetrics,
8181
Map<String, List<EmittedSpans.Span>> emittedSpans,
8282
String instrumentationName) {
8383

84-
// Start with generated data (create mutable copies of the lists)
84+
// Start with emitted data (create mutable copies of the lists)
8585
Map<String, List<EmittedMetrics.Metric>> mergedMetrics = new HashMap<>();
8686
for (Map.Entry<String, List<EmittedMetrics.Metric>> entry : emittedMetrics.entrySet()) {
8787
mergedMetrics.put(entry.getKey(), new ArrayList<>(entry.getValue()));

instrumentation-docs/src/test/java/io/opentelemetry/instrumentation/docs/TelemetryMergerTest.java

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,8 @@ void testOverrideMode() {
2525
List<ManualTelemetryEntry> manualTelemetry = createManualTelemetry();
2626

2727
// Emitted telemetry that should be ignored
28-
Map<String, List<EmittedMetrics.Metric>> autoMetrics = createAutoGeneratedMetrics();
29-
Map<String, List<EmittedSpans.Span>> autoSpans = createAutoGeneratedSpans();
28+
Map<String, List<EmittedMetrics.Metric>> autoMetrics = createEmittedMetrics();
29+
Map<String, List<EmittedSpans.Span>> autoSpans = createEmittedSpans();
3030

3131
TelemetryMerger.MergedTelemetryData result =
3232
TelemetryMerger.merge(
@@ -53,8 +53,8 @@ void testOverrideMode() {
5353
void testMergeMode() {
5454
List<ManualTelemetryEntry> manualTelemetry = createManualTelemetry();
5555

56-
Map<String, List<EmittedMetrics.Metric>> autoMetrics = createAutoGeneratedMetrics();
57-
Map<String, List<EmittedSpans.Span>> autoSpans = createAutoGeneratedSpans();
56+
Map<String, List<EmittedMetrics.Metric>> autoMetrics = createEmittedMetrics();
57+
Map<String, List<EmittedSpans.Span>> autoSpans = createEmittedSpans();
5858

5959
TelemetryMerger.MergedTelemetryData result =
6060
TelemetryMerger.merge(
@@ -80,8 +80,8 @@ void testConflictResolution() {
8080
// Create manual telemetry with same name as emitted
8181
List<ManualTelemetryEntry> manualTelemetry = createConflictingManualTelemetry();
8282

83-
Map<String, List<EmittedMetrics.Metric>> autoMetrics = createAutoGeneratedMetrics();
84-
Map<String, List<EmittedSpans.Span>> autoSpans = createAutoGeneratedSpans();
83+
Map<String, List<EmittedMetrics.Metric>> autoMetrics = createEmittedMetrics();
84+
Map<String, List<EmittedSpans.Span>> autoSpans = createEmittedSpans();
8585

8686
// Test merge mode with conflicts
8787
TelemetryMerger.MergedTelemetryData result =
@@ -112,8 +112,8 @@ void testEmptyManualTelemetry() {
112112
// Empty manual telemetry
113113
List<ManualTelemetryEntry> manualTelemetry = new ArrayList<>();
114114

115-
Map<String, List<EmittedMetrics.Metric>> autoMetrics = createAutoGeneratedMetrics();
116-
Map<String, List<EmittedSpans.Span>> autoSpans = createAutoGeneratedSpans();
115+
Map<String, List<EmittedMetrics.Metric>> autoMetrics = createEmittedMetrics();
116+
Map<String, List<EmittedSpans.Span>> autoSpans = createEmittedSpans();
117117

118118
// Test merge mode with empty manual telemetry
119119
TelemetryMerger.MergedTelemetryData result =
@@ -243,7 +243,7 @@ private static List<ManualTelemetryEntry> createMultipleWhenManualTelemetry() {
243243
return manualTelemetry;
244244
}
245245

246-
private static Map<String, List<EmittedMetrics.Metric>> createAutoGeneratedMetrics() {
246+
private static Map<String, List<EmittedMetrics.Metric>> createEmittedMetrics() {
247247
Map<String, List<EmittedMetrics.Metric>> autoMetrics = new HashMap<>();
248248

249249
List<TelemetryAttribute> attrs = new ArrayList<>();
@@ -262,7 +262,7 @@ private static Map<String, List<EmittedMetrics.Metric>> createAutoGeneratedMetri
262262
return autoMetrics;
263263
}
264264

265-
private static Map<String, List<EmittedSpans.Span>> createAutoGeneratedSpans() {
265+
private static Map<String, List<EmittedSpans.Span>> createEmittedSpans() {
266266
Map<String, List<EmittedSpans.Span>> autoSpans = new HashMap<>();
267267

268268
EmittedSpans.Span span = new EmittedSpans.Span();

0 commit comments

Comments
 (0)