pr review

Author: zeitlinger

instrumentation-api-incubator/src/main/java/io/opentelemetry/instrumentation/api/incubator/semconv/db/DbResponseStatusUtil.java

@@ -8,7 +8,6 @@
 import static java.util.logging.Level.FINE;
 
 import io.opentelemetry.instrumentation.api.incubator.semconv.db.DbClientAttributesGetter;
-import io.opentelemetry.instrumentation.api.incubator.semconv.db.DbResponseStatusUtil;
 import java.io.BufferedReader;
 import java.io.IOException;
 import java.io.InputStreamReader;
@@ -98,8 +97,8 @@ public String getDbOperationName(ElasticsearchRestRequest request) {
   @Override
   public String getResponseStatus(@Nullable Response response, @Nullable Throwable error) {
     if (response != null) {
-      return DbResponseStatusUtil.httpStatusToResponseStatus(
-          response.getStatusLine().getStatusCode());
+      int httpStatus = response.getStatusLine().getStatusCode();
+      return httpStatus >= 400 && httpStatus < 600 ? Integer.toString(httpStatus) : null;
     }
     return null;
   }

instrumentation/elasticsearch/elasticsearch-rest-common-5.0/library/src/main/java/io/opentelemetry/instrumentation/elasticsearch/rest/common/v5_0/internal/ElasticsearchDbAttributesGetter.java

@@ -6,7 +6,6 @@
 package io.opentelemetry.javaagent.instrumentation.opensearch.rest;
 
 import io.opentelemetry.instrumentation.api.incubator.semconv.db.DbClientAttributesGetter;
-import io.opentelemetry.instrumentation.api.incubator.semconv.db.DbResponseStatusUtil;
 import io.opentelemetry.semconv.incubating.DbIncubatingAttributes;
 import javax.annotation.Nullable;
 import org.opensearch.client.Response;
@@ -56,8 +55,8 @@ public String getDbOperationName(OpenSearchRestRequest request) {
   @Override
   public String getResponseStatus(@Nullable Response response, @Nullable Throwable error) {
     if (response != null) {
-      return DbResponseStatusUtil.httpStatusToResponseStatus(
-          response.getStatusLine().getStatusCode());
+      int httpStatus = response.getStatusLine().getStatusCode();
+      return httpStatus >= 400 && httpStatus < 600 ? Integer.toString(httpStatus) : null;
     }
     return null;
   }

instrumentation/opensearch/opensearch-rest-common/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/opensearch/rest/OpenSearchRestAttributesGetter.java

@@ -50,6 +50,7 @@ public Collection<String> getRawQueryTexts(VertxSqlClientRequest request) {
   @Override
   public String getResponseStatus(@Nullable Void response, @Nullable Throwable error) {
     try {
+      // loaded via reflection, because this class is not available in all versions that we support
       Class<?> ex = Class.forName("io.vertx.pgclient.PgException");
       if (ex.isInstance(error)) {
         return (String) ex.getMethod("getCode").invoke(error);