change value to name

Author: Duncan-tree-zhou

instrumentation-annotations-incubator/src/main/java/io/opentelemetry/instrumentation/annotations/incubator/Attribute.java

@@ -37,5 +37,5 @@
    * `javac`, the parameter name will be used instead. If the parameter name is not available, e.g.,
    * because the code was not compiled with that flag, the attribute will be ignored.
    */
-  String value() default "";
+  String name() default "";
 }

instrumentation-annotations-incubator/src/main/java/io/opentelemetry/instrumentation/annotations/incubator/Counted.java

@@ -40,7 +40,7 @@
    * <p>The name should follow the metric naming rules: <a
    * href="https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/api.md#instrument-name-syntax">https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/api.md#instrument-name-syntax</a>
    */
-  String value();
+  String name();
 
   /**
    * Description of the metric.

instrumentation-annotations-incubator/src/main/java/io/opentelemetry/instrumentation/annotations/incubator/Timed.java

@@ -40,7 +40,7 @@
    * <p>The name should follow the metric naming rules: <a
    * href="https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/api.md#instrument-naming-rule">https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/api.md#instrument-naming-rule</a>
    */
-  String value();
+  String name();
 
   /**
    * Description for the metric.

instrumentation-annotations-incubator/src/test/java/io/opentelemetry/instrumentation/annotations/incubator/CountedUsageExamples.java

@@ -7,9 +7,10 @@
 
 public class CountedUsageExamples {
 
-  @Counted("customizedName")
+  @Counted(name = "customizedName")
   public void method() {}
 
-  @Counted("methodWithAttributes")
-  public void attributes(@Attribute String attribute1, @Attribute("attribute2") long attribute2) {}
+  @Counted(name = "methodWithAttributes")
+  public void attributes(
+      @Attribute String attribute1, @Attribute(name = "attribute2") long attribute2) {}
 }

instrumentation-annotations-incubator/src/test/java/io/opentelemetry/instrumentation/annotations/incubator/TimedUsageExamples.java

@@ -7,9 +7,10 @@
 
 public class TimedUsageExamples {
 
-  @Timed("customizedName")
+  @Timed(name = "customizedName")
   public void method() {}
 
-  @Timed("methodWithAttributes")
-  public void attributes(@Attribute String attribute1, @Attribute("attribute2") long attribute2) {}
+  @Timed(name = "methodWithAttributes")
+  public void attributes(
+      @Attribute String attribute1, @Attribute(name = "attribute2") long attribute2) {}
 }

instrumentation/opentelemetry-instrumentation-annotations/opentelemetry-instrumentation-annotations-incubator/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/instrumentationannotations/incubator/counted/CountedExample.java

@@ -18,42 +18,42 @@ public class CountedExample {
   public static final String METRIC_UNIT = "ms";
   public static final String TO_STRING = "I am a to string object.";
 
-  @Counted(METRIC_NAME)
+  @Counted(name = METRIC_NAME)
   public void exampleWithName() {}
 
-  @Counted(value = "example.with.description.count", description = METRIC_DESCRIPTION)
+  @Counted(name = "example.with.description.count", description = METRIC_DESCRIPTION)
   public void exampleWithDescription() {}
 
-  @Counted(value = "example.with.unit.count", unit = METRIC_UNIT)
+  @Counted(name = "example.with.unit.count", unit = METRIC_UNIT)
   public void exampleWithUnit() {}
 
-  @Counted("example.with.static.attributes.count")
+  @Counted(name = "example.with.static.attributes.count")
   @StaticAttribute(name = "key1", value = "value1")
   @StaticAttribute(name = "key2", value = "value2")
   @StaticAttribute(name = "key2", value = "value2")
   public void exampleWithStaticAttributes() {}
 
-  @Counted("example.with.attributes.count")
+  @Counted(name = "example.with.attributes.count")
   public void exampleWithAttributes(
       @Attribute String attribute1,
-      @Attribute("custom_attr1") long attribute2,
-      @Attribute("custom_attr2") ToStringObject toStringObject) {}
+      @Attribute(name = "custom_attr1") long attribute2,
+      @Attribute(name = "custom_attr2") ToStringObject toStringObject) {}
 
-  @Counted(value = "example.with.return.count")
+  @Counted(name = "example.with.return.count")
   @ReturnValueAttribute("returnValue")
   public ToStringObject exampleWithReturnValueAttribute() {
     return new ToStringObject();
   }
 
-  @Counted("example.with.exception.count")
+  @Counted(name = "example.with.exception.count")
   public void exampleWithException() {
     throw new IllegalStateException("test exception.");
   }
 
-  @Counted("example.ignore.count")
+  @Counted(name = "example.ignore.count")
   public void exampleIgnore() {}
 
-  @Counted(value = "example.completable.future.count")
+  @Counted(name = "example.completable.future.count")
   @ReturnValueAttribute("returnValue")
   public CompletableFuture<String> completableFuture(CompletableFuture<String> future) {
     return future;

instrumentation/opentelemetry-instrumentation-annotations/opentelemetry-instrumentation-annotations-incubator/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/instrumentationannotations/incubator/timed/TimedExample.java

@@ -16,38 +16,38 @@ public class TimedExample {
   public static final String METRIC_DESCRIPTION = "I am the description.";
   public static final String TO_STRING = "I am a to string object.";
 
-  @Timed(METRIC_NAME)
+  @Timed(name = METRIC_NAME)
   public void exampleWithName() {}
 
-  @Timed(value = "example.with.description.duration", description = METRIC_DESCRIPTION)
+  @Timed(name = "example.with.description.duration", description = METRIC_DESCRIPTION)
   public void exampleWithDescription() {}
 
-  @Timed("example.with.static.attributes.duration")
+  @Timed(name = "example.with.static.attributes.duration")
   @StaticAttribute(name = "key1", value = "value1")
   @StaticAttribute(name = "key2", value = "value2")
   public void exampleWithStaticAttributes() {}
 
-  @Timed("example.with.attributes.duration")
+  @Timed(name = "example.with.attributes.duration")
   public void exampleWithAttributes(
       @Attribute String attribute1,
-      @Attribute("custom_attr1") long attribute2,
-      @Attribute("custom_attr2") TimedExample.ToStringObject toStringObject) {}
+      @Attribute(name = "custom_attr1") long attribute2,
+      @Attribute(name = "custom_attr2") TimedExample.ToStringObject toStringObject) {}
 
-  @Timed("example.ignore.duration")
+  @Timed(name = "example.ignore.duration")
   public void exampleIgnore() {}
 
-  @Timed("example.with.exception.duration")
+  @Timed(name = "example.with.exception.duration")
   public void exampleWithException() {
     throw new IllegalStateException("test");
   }
 
-  @Timed(value = "example.with.return.duration")
+  @Timed(name = "example.with.return.duration")
   @ReturnValueAttribute("returnValue")
   public ToStringObject exampleWithReturnValueAttribute() {
     return new ToStringObject();
   }
 
-  @Timed(value = "example.completable.future.duration")
+  @Timed(name = "example.completable.future.duration")
   @ReturnValueAttribute("returnValue")
   public CompletableFuture<String> completableFuture(CompletableFuture<String> future) {
     return future;

instrumentation/opentelemetry-instrumentation-annotations/opentelemetry-instrumentation-annotations-incubator/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/instrumentationannotations/incubator/timed/TimedInstrumentationTest.java

@@ -122,7 +122,7 @@ void testExampleWithException() {
   }
 
   @Test
-  void testExampleWithReturnValueAttribute() {
+  void testExampleWithReturnNameAttribute() {
     new TimedExample().exampleWithReturnValueAttribute();
     testing.waitAndAssertMetrics(
         TIMED_INSTRUMENTATION_NAME,