Skip to content

Commit 5d86086

Browse files
committed
post-review changes
1 parent 39da926 commit 5d86086

File tree

1 file changed

+4
-8
lines changed

1 file changed

+4
-8
lines changed

instrumentation/jmx-metrics/library/src/test/java/io/opentelemetry/instrumentation/jmx/engine/MetricAggregationTest.java

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -82,8 +82,7 @@ void before() {
8282

8383
@AfterEach
8484
void after() throws Exception {
85-
ObjectName objectName =
86-
new ObjectName("otel.jmx.test:type=" + Hello.class.getSimpleName() + ",*");
85+
ObjectName objectName = new ObjectName(DOMAIN + ":type=" + Hello.class.getSimpleName() + ",*");
8786
theServer
8887
.queryMBeans(objectName, null)
8988
.forEach(
@@ -103,7 +102,8 @@ void after() throws Exception {
103102
private InMemoryMetricReader reader;
104103
private OpenTelemetrySdk sdk;
105104

106-
private static ObjectName getObjectName(@Nullable String a, @Nullable String b) {
105+
private static ObjectName getObjectName(@Nullable String a, @Nullable String b)
106+
throws MalformedObjectNameException {
107107
StringBuilder parts = new StringBuilder();
108108
parts.append("otel.jmx.test:type=").append(Hello.class.getSimpleName());
109109
if (a != null) {
@@ -112,11 +112,7 @@ private static ObjectName getObjectName(@Nullable String a, @Nullable String b)
112112
if (b != null) {
113113
parts.append(",b=").append(b);
114114
}
115-
try {
116-
return new ObjectName(parts.toString());
117-
} catch (MalformedObjectNameException e) {
118-
throw new RuntimeException(e);
119-
}
115+
return new ObjectName(parts.toString());
120116
}
121117

122118
static List<MetricInfo.Type> metricTypes() {

0 commit comments

Comments
 (0)