Skip to content

Commit 5e81701

Browse files
committed
use constants from semconv
1 parent 2daa67f commit 5e81701

File tree

1 file changed

+2
-13
lines changed

1 file changed

+2
-13
lines changed

instrumentation/aws-sdk/aws-sdk-1.11/testing/src/main/java/io/opentelemetry/instrumentation/awssdk/v1_11/AbstractStepFunctionsClientTest.java

Lines changed: 2 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,15 @@
55

66
package io.opentelemetry.instrumentation.awssdk.v1_11;
77

8-
import static io.opentelemetry.api.common.AttributeKey.stringKey;
98
import static io.opentelemetry.sdk.testing.assertj.OpenTelemetryAssertions.equalTo;
9+
import static io.opentelemetry.semconv.incubating.AwsIncubatingAttributes.AWS_STEP_FUNCTIONS_ACTIVITY_ARN;
10+
import static io.opentelemetry.semconv.incubating.AwsIncubatingAttributes.AWS_STEP_FUNCTIONS_STATE_MACHINE_ARN;
1011
import static java.util.Collections.singletonList;
1112

1213
import com.amazonaws.services.stepfunctions.AWSStepFunctions;
1314
import com.amazonaws.services.stepfunctions.AWSStepFunctionsClientBuilder;
1415
import com.amazonaws.services.stepfunctions.model.DescribeActivityRequest;
1516
import com.amazonaws.services.stepfunctions.model.DescribeStateMachineRequest;
16-
import io.opentelemetry.api.common.AttributeKey;
1717
import io.opentelemetry.sdk.testing.assertj.AttributeAssertion;
1818
import io.opentelemetry.testing.internal.armeria.common.HttpResponse;
1919
import io.opentelemetry.testing.internal.armeria.common.HttpStatus;
@@ -27,17 +27,6 @@
2727

2828
public abstract class AbstractStepFunctionsClientTest extends AbstractBaseAwsClientTest {
2929

30-
// Copied from semconv. These two keys are not available in the current version of semconv.
31-
// They can be replaced with direct imports when the new version of semconv is in.
32-
// import static
33-
// io.opentelemetry.semconv.incubating.AwsIncubatingAttributes.AWS_STEP_FUNCTIONS_ACTIVITY_ARN;
34-
// import static
35-
// io.opentelemetry.semconv.incubating.AwsIncubatingAttributes.AWS_STEP_FUNCTIONS_STATE_MACHINE_ARN;
36-
private static final AttributeKey<String> AWS_STEP_FUNCTIONS_ACTIVITY_ARN =
37-
stringKey("aws.step_functions.activity.arn");
38-
private static final AttributeKey<String> AWS_STEP_FUNCTIONS_STATE_MACHINE_ARN =
39-
stringKey("aws.step_functions.state_machine.arn");
40-
4130
public abstract AWSStepFunctionsClientBuilder configureClient(
4231
AWSStepFunctionsClientBuilder client);
4332

0 commit comments

Comments
 (0)