pr review

Author: zeitlinger

smoke-tests/src/test/java/io/opentelemetry/smoketest/AgentDebugLoggingTest.java

@@ -6,6 +6,7 @@
 package io.opentelemetry.smoketest;
 
 import java.time.Duration;
+import org.junit.jupiter.api.DisplayName;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.condition.DisabledIf;
 
@@ -24,8 +25,9 @@ protected TargetWaitStrategy getWaitStrategy() {
         Duration.ofMinutes(1), ".*DEBUG io.opentelemetry.javaagent.tooling.VersionLogger.*");
   }
 
+  @DisplayName("verifies that debug logging is working by checking for a debug log on startup")
   @Test
-  void verifyThatDebugLoggingIsWorking() throws Exception {
+  void verifyLogging() throws Exception {
     withTarget(8, () -> {});
   }
 }

smoke-tests/src/test/java/io/opentelemetry/smoketest/LogsSmokeTest.java

@@ -32,11 +32,13 @@ protected TargetWaitStrategy getWaitStrategy() {
   @ParameterizedTest
   @ValueSource(ints = {8, 11, 17})
   void shouldExportLogs(int jdk) throws Exception {
-    withTarget(jdk, () -> {
-      client().get("/greeting").aggregate().join();
-      Collection<LogRecordData> logs = waitForLogs();
+    withTarget(
+        jdk,
+        () -> {
+          client().get("/greeting").aggregate().join();
+          Collection<LogRecordData> logs = waitForLogs();
 
-      assertThat(logs).isNotEmpty();
-    });
+          assertThat(logs).isNotEmpty();
+        });
   }
 }

smoke-tests/src/test/java/io/opentelemetry/smoketest/QuarkusSmokeTest.java

@@ -37,7 +37,7 @@ protected boolean getSetServiceName() {
 
   @ParameterizedTest
   @ValueSource(ints = {17, 21, 23}) // Quarkus 3.7+ requires Java 17+
-  void quarkusSmokeTestOnJdk(int jdk) throws Exception {
+  void quarkusSmokeTest(int jdk) throws Exception {
     withTarget(
         jdk,
         () -> {

smoke-tests/src/test/java/io/opentelemetry/smoketest/SecurityManagerSmokeTest.java

@@ -30,7 +30,7 @@ protected Map<String, String> getExtraEnv() {
 
   @ParameterizedTest
   @ValueSource(ints = {8, 11, 17, 21, 23})
-  void securityManagerSmokeTestOnJdk(int jdk) throws Exception {
+  void securityManagerSmokeTest(int jdk) throws Exception {
     withTarget(
         jdk,
         () ->

smoke-tests/src/test/java/io/opentelemetry/smoketest/TargetRunner.java

@@ -1,3 +1,8 @@
+/*
+ * Copyright The OpenTelemetry Authors
+ * SPDX-License-Identifier: Apache-2.0
+ */
+
 package io.opentelemetry.smoketest;
 
 @FunctionalInterface