Skip to content

Commit 5fcca3f

Browse files
committed
fix rebase
1 parent c5b9a40 commit 5fcca3f

File tree

6 files changed

+18
-30
lines changed

6 files changed

+18
-30
lines changed

instrumentation/spring/spring-boot-autoconfigure/build.gradle.kts

Lines changed: 6 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,7 @@ plugins {
66
base.archivesName.set("opentelemetry-spring-boot-autoconfigure")
77
group = "io.opentelemetry.instrumentation"
88

9-
val springBootVersion =
10-
"2.7.18" // AutoConfiguration is added in 2.7.0, but can be used with older versions
9+
val springBootVersion = "2.7.18" // AutoConfiguration is added in 2.7.0, but can be used with older versions
1110

1211
// r2dbc-proxy is shadowed to prevent org.springframework.boot.autoconfigure.r2dbc.R2dbcAutoConfiguration
1312
// from being loaded by Spring Boot (by the presence of META-INF/services/io.r2dbc.spi.ConnectionFactoryProvider) - even if the user doesn't want to use R2DBC.
@@ -44,12 +43,7 @@ dependencies {
4443
implementation(project(":instrumentation-annotations-support"))
4544
implementation(project(":instrumentation:kafka:kafka-clients:kafka-clients-2.6:library"))
4645
implementation(project(":instrumentation:mongo:mongo-3.1:library"))
47-
compileOnly(
48-
project(
49-
path = ":instrumentation:r2dbc-1.0:library-instrumentation-shaded",
50-
configuration = "shadow"
51-
)
52-
)
46+
compileOnly(project(path = ":instrumentation:r2dbc-1.0:library-instrumentation-shaded", configuration = "shadow"))
5347
implementation(project(":instrumentation:spring:spring-kafka-2.7:library"))
5448
implementation(project(":instrumentation:spring:spring-web:spring-web-3.1:library"))
5549
implementation(project(":instrumentation:spring:spring-webmvc:spring-webmvc-5.3:library"))
@@ -115,14 +109,8 @@ dependencies {
115109
add("javaSpring3CompileOnly", files(sourceSets.main.get().output.classesDirs))
116110
add("javaSpring3CompileOnly", "org.springframework.boot:spring-boot-starter-web:3.2.4")
117111
add("javaSpring3CompileOnly", "io.opentelemetry:opentelemetry-sdk-extension-autoconfigure")
118-
add(
119-
"javaSpring3CompileOnly",
120-
project(":instrumentation:spring:spring-web:spring-web-3.1:library")
121-
)
122-
add(
123-
"javaSpring3CompileOnly",
124-
project(":instrumentation:spring:spring-webmvc:spring-webmvc-6.0:library")
125-
)
112+
add("javaSpring3CompileOnly", project(":instrumentation:spring:spring-web:spring-web-3.1:library"))
113+
add("javaSpring3CompileOnly", project(":instrumentation:spring:spring-webmvc:spring-webmvc-6.0:library"))
126114
}
127115

128116
val latestDepTest = findProperty("testLatestDeps") as Boolean
@@ -134,10 +122,8 @@ if (latestDepTest) {
134122
}
135123
}
136124

137-
val testJavaVersion =
138-
gradle.startParameter.projectProperties["testJavaVersion"]?.let(JavaVersion::toVersion)
139-
val testSpring3 =
140-
(testJavaVersion == null || testJavaVersion.compareTo(JavaVersion.VERSION_17) >= 0)
125+
val testJavaVersion = gradle.startParameter.projectProperties["testJavaVersion"]?.let(JavaVersion::toVersion)
126+
val testSpring3 = (testJavaVersion == null || testJavaVersion.compareTo(JavaVersion.VERSION_17) >= 0)
141127

142128
testing {
143129
suites {

instrumentation/spring/spring-boot-autoconfigure/src/main/java/io/opentelemetry/instrumentation/spring/autoconfigure/OpenTelemetryAutoConfiguration.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -189,8 +189,9 @@ public ConfigProvider configProvider(OpenTelemetryConfigurationModel model) {
189189
* integrate with spring boot properties.
190190
*/
191191
@Bean
192-
public ConfigProperties otelProperties(ConfigProvider configProvider) {
193-
return DeclarativeConfigPropertiesBridge.create(configProvider.getInstrumentationConfig());
192+
public ConfigProperties otelProperties(
193+
OpenTelemetryConfigurationModel model, ConfigProvider configProvider) {
194+
return new DeclarativeConfigPropertiesBridge(configProvider, model.getLogLevel());
194195
}
195196
}
196197
}

javaagent-extension-api/build.gradle.kts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,6 @@ dependencies {
1313

1414
implementation(project(":instrumentation-api"))
1515
implementation(project(":instrumentation-api-incubator"))
16-
implementation(project(":sdk-bridge")) {
17-
// is part of bootstrap classpath
18-
exclude(group = "io.opentelemetry", module = "opentelemetry-api-incubator")
19-
exclude(group = "io.opentelemetry", module = "opentelemetry-sdk-extension-autoconfigure-spi")
20-
}
2116

2217
// autoconfigure is unstable, do not expose as api
2318
implementation("io.opentelemetry:opentelemetry-sdk-extension-autoconfigure")

javaagent-tooling/build.gradle.kts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,11 @@ dependencies {
1717
implementation(project(":instrumentation-annotations-support"))
1818
implementation(project(":muzzle"))
1919
implementation(project(":sdk-autoconfigure-support"))
20+
implementation(project(":sdk-bridge")) {
21+
// is part of bootstrap classpath
22+
exclude(group = "io.opentelemetry", module = "opentelemetry-api-incubator")
23+
exclude(group = "io.opentelemetry", module = "opentelemetry-sdk-extension-autoconfigure-spi")
24+
}
2025

2126
implementation("io.opentelemetry:opentelemetry-api")
2227
implementation("io.opentelemetry:opentelemetry-sdk")

javaagent-tooling/src/main/java/io/opentelemetry/javaagent/tooling/config/DeclarativeConfigEarlyInitAgentConfig.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@
88
import io.opentelemetry.api.GlobalOpenTelemetry;
99
import io.opentelemetry.api.incubator.config.DeclarativeConfigException;
1010
import io.opentelemetry.api.incubator.config.GlobalConfigProvider;
11+
import io.opentelemetry.instrumentation.sdk.DeclarativeConfigPropertiesBridge;
1112
import io.opentelemetry.javaagent.bootstrap.OpenTelemetrySdkAccess;
12-
import io.opentelemetry.javaagent.extension.DeclarativeConfigPropertiesBridge;
1313
import io.opentelemetry.sdk.OpenTelemetrySdk;
1414
import io.opentelemetry.sdk.autoconfigure.AutoConfiguredOpenTelemetrySdk;
1515
import io.opentelemetry.sdk.autoconfigure.internal.SpiHelper;

sdk-bridge/src/main/java/io/opentelemetry/instrumentation/sdk/DeclarativeConfigPropertiesBridge.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55

66
package io.opentelemetry.instrumentation.sdk;
77

8+
import static io.opentelemetry.api.incubator.config.DeclarativeConfigProperties.empty;
89

910
import io.opentelemetry.api.incubator.config.ConfigProvider;
1011
import io.opentelemetry.api.incubator.config.DeclarativeConfigException;
@@ -110,7 +111,7 @@ public DeclarativeConfigPropertiesBridge(ConfigProvider configProvider, String l
110111
this.logLevel = logLevel;
111112
DeclarativeConfigProperties inst = configProvider.getInstrumentationConfig();
112113
if (inst == null) {
113-
inst = DeclarativeConfigProperties.empty();
114+
inst = empty();
114115
}
115116
instrumentationJavaNode = inst.getStructured("java", empty());
116117
instrumentationGeneralNode = inst.getStructured("general", empty());
@@ -223,7 +224,7 @@ private static <T> T splitOnDot(
223224
}
224225
if (segments.length > 1) {
225226
for (int i = 0; i < segments.length - 1; i++) {
226-
target = target.getStructured(segments[i], DeclarativeConfigProperties.empty());
227+
target = target.getStructured(segments[i], empty());
227228
}
228229
}
229230
String lastPart = segments[segments.length - 1];

0 commit comments

Comments
 (0)