Polish variable naming from enableExperimentalJmxTelemetry to emitExperimentalTelemetry (#13791)

Author: steverao

instrumentation/runtime-telemetry/runtime-telemetry-java17/library/src/main/java/io/opentelemetry/instrumentation/runtimemetrics/java17/RuntimeMetricsBuilder.java

@@ -21,7 +21,7 @@ public final class RuntimeMetricsBuilder {
   final EnumMap<JfrFeature, Boolean> enabledFeatureMap;
 
   private boolean disableJmx = false;
-  private boolean enableExperimentalJmxTelemetry = false;
+  private boolean emitExperimentalTelemetry = false;
   private boolean captureGcCause = false;
 
   RuntimeMetricsBuilder(OpenTelemetry openTelemetry) {
@@ -77,8 +77,20 @@ public RuntimeMetricsBuilder disableAllJmx() {
 
   /** Enable experimental JMX telemetry collection. */
   @CanIgnoreReturnValue
+  public RuntimeMetricsBuilder emitExperimentalTelemetry() {
+    emitExperimentalTelemetry = true;
+    return this;
+  }
+
+  /**
+   * Enable experimental JMX telemetry collection.
+   *
+   * @deprecated Use {@link #emitExperimentalTelemetry()} instead.
+   */
+  @Deprecated
+  @CanIgnoreReturnValue
   public RuntimeMetricsBuilder enableExperimentalJmxTelemetry() {
-    enableExperimentalJmxTelemetry = true;
+    emitExperimentalTelemetry = true;
     return this;
   }
 
@@ -95,7 +107,7 @@ public RuntimeMetrics build() {
         disableJmx
             ? List.of()
             : JmxRuntimeMetricsFactory.buildObservables(
-                openTelemetry, enableExperimentalJmxTelemetry, captureGcCause);
+                openTelemetry, emitExperimentalTelemetry, captureGcCause);
     RuntimeMetrics.JfrRuntimeMetrics jfrRuntimeMetrics = buildJfrMetrics();
     return new RuntimeMetrics(openTelemetry, observables, jfrRuntimeMetrics);
   }

instrumentation/runtime-telemetry/runtime-telemetry-java17/library/src/main/java/io/opentelemetry/instrumentation/runtimemetrics/java17/internal/RuntimeMetricsConfigUtil.java

@@ -40,7 +40,7 @@ public static RuntimeMetrics configure(
 
     if (config.getBoolean(
         "otel.instrumentation.runtime-telemetry.emit-experimental-telemetry", false)) {
-      builder.enableExperimentalJmxTelemetry();
+      builder.emitExperimentalTelemetry();
     }
 
     if (config.getBoolean("otel.instrumentation.runtime-telemetry.capture-gc-cause", false)) {

instrumentation/runtime-telemetry/runtime-telemetry-java8/library/src/main/java/io/opentelemetry/instrumentation/runtimemetrics/java8/RuntimeMetricsBuilder.java

@@ -15,7 +15,7 @@ public final class RuntimeMetricsBuilder {
 
   private final OpenTelemetry openTelemetry;
 
-  private boolean enableExperimentalJmxTelemetry = false;
+  private boolean emitExperimentalTelemetry = false;
   private boolean captureGcCause = false;
 
   RuntimeMetricsBuilder(OpenTelemetry openTelemetry) {
@@ -24,8 +24,20 @@ public final class RuntimeMetricsBuilder {
 
   /** Enable all JMX telemetry collection. */
   @CanIgnoreReturnValue
+  public RuntimeMetricsBuilder emitExperimentalTelemetry() {
+    emitExperimentalTelemetry = true;
+    return this;
+  }
+
+  /**
+   * Enable experimental JMX telemetry collection.
+   *
+   * @deprecated Use {@link #emitExperimentalTelemetry()} instead.
+   */
+  @Deprecated
+  @CanIgnoreReturnValue
   public RuntimeMetricsBuilder enableExperimentalJmxTelemetry() {
-    enableExperimentalJmxTelemetry = true;
+    emitExperimentalTelemetry = true;
     return this;
   }
 
@@ -40,7 +52,7 @@ public RuntimeMetricsBuilder captureGcCause() {
   public RuntimeMetrics build() {
     List<AutoCloseable> observables =
         JmxRuntimeMetricsFactory.buildObservables(
-            openTelemetry, enableExperimentalJmxTelemetry, captureGcCause);
+            openTelemetry, emitExperimentalTelemetry, captureGcCause);
     return new RuntimeMetrics(observables);
   }
 }

instrumentation/runtime-telemetry/runtime-telemetry-java8/library/src/main/java/io/opentelemetry/instrumentation/runtimemetrics/java8/internal/JmxRuntimeMetricsFactory.java

@@ -21,15 +21,15 @@
 public class JmxRuntimeMetricsFactory {
   @SuppressWarnings("CatchingUnchecked")
   public static List<AutoCloseable> buildObservables(
-      OpenTelemetry openTelemetry, boolean enableExperimentalJmxTelemetry, boolean captureGcCause) {
+      OpenTelemetry openTelemetry, boolean emitExperimentalTelemetry, boolean captureGcCause) {
     // Set up metrics gathered by JMX
     List<AutoCloseable> observables = new ArrayList<>();
     observables.addAll(Classes.registerObservers(openTelemetry));
     observables.addAll(Cpu.registerObservers(openTelemetry));
     observables.addAll(GarbageCollector.registerObservers(openTelemetry, captureGcCause));
     observables.addAll(MemoryPools.registerObservers(openTelemetry));
     observables.addAll(Threads.registerObservers(openTelemetry));
-    if (enableExperimentalJmxTelemetry) {
+    if (emitExperimentalTelemetry) {
       observables.addAll(ExperimentalBufferPools.registerObservers(openTelemetry));
       observables.addAll(ExperimentalCpu.registerObservers(openTelemetry));
       observables.addAll(ExperimentalMemoryPools.registerObservers(openTelemetry));

instrumentation/runtime-telemetry/runtime-telemetry-java8/library/src/main/java/io/opentelemetry/instrumentation/runtimemetrics/java8/internal/RuntimeMetricsConfigUtil.java

@@ -28,7 +28,7 @@ public static RuntimeMetrics configure(
 
     if (config.getBoolean(
         "otel.instrumentation.runtime-telemetry.emit-experimental-telemetry", false)) {
-      builder.enableExperimentalJmxTelemetry();
+      builder.emitExperimentalTelemetry();
     }
 
     if (config.getBoolean("otel.instrumentation.runtime-telemetry.capture-gc-cause", false)) {