pr review

Author: zeitlinger

instrumentation-api-incubator/src/main/java/io/opentelemetry/instrumentation/api/incubator/config/internal/InstrumentationConfig.java

@@ -119,9 +119,10 @@ default List<String> getList(String name) {
    *
    * @param node the name of the instrumentation (e.g. "log4j"), the vendor name (e.g. "google"), or
    *     "common" for common Java settings that don't apply to other languages.
-   * @return the declarative configuration properties for the given node name, or {@code * null} if
+   * @return the declarative configuration properties for the given node name, or {@code null} if
    *     declarative configuration is <b>not used at all</b>.
    */
+  @Nullable
   DeclarativeConfigProperties getDeclarativeConfig(String node);
 
   /**

instrumentation/spring/spring-boot-autoconfigure/src/main/java/io/opentelemetry/instrumentation/spring/autoconfigure/internal/properties/ConfigPropertiesBridge.java

@@ -121,7 +121,7 @@ public DeclarativeConfigProperties getDeclarativeConfig(String node) {
   @Nullable
   @Override
   public ConfigProvider getConfigProvider() {
-    // create a spring boot bridge for DeclarativeConfigProperties
+    // create a spring boot bridge for ConfigProvider
     return null;
   }
 }

javaagent-extension-api/src/main/java/io/opentelemetry/javaagent/extension/internal/DeclarativeConfigPropertiesBridge.java

@@ -197,13 +197,4 @@ private static String[] getSegments(String property) {
     // Split the remainder of the property on "."
     return property.replace('-', '_').split("\\.");
   }
-
-  static String yamlPath(String property) {
-    String[] segments = getSegments(property);
-    if (segments.length == 0) {
-      throw new IllegalArgumentException("Invalid property: " + property);
-    }
-
-    return "'instrumentation/development' / 'java' / '" + String.join("' / '", segments) + "'";
-  }
 }