Skip to content

Commit 62c9051

Browse files
authored
switch annotation org.checkerframework.checker.nullness.qual.Nullable to javax.annotation.Nullable (#4418)
1 parent 25910d9 commit 62c9051

File tree

15 files changed

+69
-46
lines changed

15 files changed

+69
-46
lines changed

instrumentation/akka-http-10.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/akkahttp/client/AkkaHttpClientAttributesExtractor.java

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
import io.opentelemetry.instrumentation.api.instrumenter.http.HttpClientAttributesExtractor;
1111
import io.opentelemetry.javaagent.instrumentation.akkahttp.AkkaHttpUtil;
1212
import java.util.List;
13-
import org.checkerframework.checker.nullness.qual.Nullable;
13+
import javax.annotation.Nullable;
1414

1515
class AkkaHttpClientAttributesExtractor
1616
extends HttpClientAttributesExtractor<HttpRequest, HttpResponse> {
@@ -35,13 +35,15 @@ protected List<String> requestHeader(HttpRequest httpRequest, String name) {
3535
}
3636

3737
@Override
38-
protected @Nullable Long requestContentLength(
38+
@Nullable
39+
protected Long requestContentLength(
3940
HttpRequest httpRequest, @Nullable HttpResponse httpResponse) {
4041
return null;
4142
}
4243

4344
@Override
44-
protected @Nullable Long requestContentLengthUncompressed(
45+
@Nullable
46+
protected Long requestContentLengthUncompressed(
4547
HttpRequest httpRequest, @Nullable HttpResponse httpResponse) {
4648
return null;
4749
}
@@ -52,13 +54,14 @@ protected Integer statusCode(HttpRequest httpRequest, HttpResponse httpResponse)
5254
}
5355

5456
@Override
55-
protected @Nullable Long responseContentLength(
56-
HttpRequest httpRequest, HttpResponse httpResponse) {
57+
@Nullable
58+
protected Long responseContentLength(HttpRequest httpRequest, HttpResponse httpResponse) {
5759
return null;
5860
}
5961

6062
@Override
61-
protected @Nullable Long responseContentLengthUncompressed(
63+
@Nullable
64+
protected Long responseContentLengthUncompressed(
6265
HttpRequest httpRequest, HttpResponse httpResponse) {
6366
return null;
6467
}

instrumentation/akka-http-10.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/akkahttp/client/AkkaHttpNetAttributesExtractor.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
import akka.http.scaladsl.model.HttpResponse;
1010
import io.opentelemetry.instrumentation.api.instrumenter.net.NetClientAttributesExtractor;
1111
import io.opentelemetry.semconv.trace.attributes.SemanticAttributes;
12-
import org.checkerframework.checker.nullness.qual.Nullable;
12+
import javax.annotation.Nullable;
1313

1414
class AkkaHttpNetAttributesExtractor
1515
extends NetClientAttributesExtractor<HttpRequest, HttpResponse> {
@@ -29,7 +29,8 @@ public Integer peerPort(HttpRequest httpRequest, @Nullable HttpResponse httpResp
2929
}
3030

3131
@Override
32-
public @Nullable String peerIp(HttpRequest httpRequest, @Nullable HttpResponse httpResponse) {
32+
@Nullable
33+
public String peerIp(HttpRequest httpRequest, @Nullable HttpResponse httpResponse) {
3334
return null;
3435
}
3536
}

instrumentation/akka-http-10.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/akkahttp/server/AkkaHttpServerAttributesExtractor.java

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
import io.opentelemetry.instrumentation.api.instrumenter.http.HttpServerAttributesExtractor;
1111
import io.opentelemetry.javaagent.instrumentation.akkahttp.AkkaHttpUtil;
1212
import java.util.List;
13-
import org.checkerframework.checker.nullness.qual.Nullable;
13+
import javax.annotation.Nullable;
1414
import scala.Option;
1515

1616
class AkkaHttpServerAttributesExtractor
@@ -27,13 +27,14 @@ protected List<String> requestHeader(HttpRequest request, String name) {
2727
}
2828

2929
@Override
30-
protected @Nullable Long requestContentLength(
31-
HttpRequest request, @Nullable HttpResponse httpResponse) {
30+
@Nullable
31+
protected Long requestContentLength(HttpRequest request, @Nullable HttpResponse httpResponse) {
3232
return null;
3333
}
3434

3535
@Override
36-
protected @Nullable Long requestContentLengthUncompressed(
36+
@Nullable
37+
protected Long requestContentLengthUncompressed(
3738
HttpRequest request, @Nullable HttpResponse httpResponse) {
3839
return null;
3940
}
@@ -44,13 +45,14 @@ protected Integer statusCode(HttpRequest request, HttpResponse httpResponse) {
4445
}
4546

4647
@Override
47-
protected @Nullable Long responseContentLength(HttpRequest request, HttpResponse httpResponse) {
48+
@Nullable
49+
protected Long responseContentLength(HttpRequest request, HttpResponse httpResponse) {
4850
return null;
4951
}
5052

5153
@Override
52-
protected @Nullable Long responseContentLengthUncompressed(
53-
HttpRequest request, HttpResponse httpResponse) {
54+
@Nullable
55+
protected Long responseContentLengthUncompressed(HttpRequest request, HttpResponse httpResponse) {
5456
return null;
5557
}
5658

@@ -76,7 +78,8 @@ protected String target(HttpRequest request) {
7678
}
7779

7880
@Override
79-
protected @Nullable String route(HttpRequest request) {
81+
@Nullable
82+
protected String route(HttpRequest request) {
8083
return null;
8184
}
8285

@@ -86,7 +89,8 @@ protected String scheme(HttpRequest request) {
8689
}
8790

8891
@Override
89-
protected @Nullable String serverName(HttpRequest request, @Nullable HttpResponse httpResponse) {
92+
@Nullable
93+
protected String serverName(HttpRequest request, @Nullable HttpResponse httpResponse) {
9094
return null;
9195
}
9296
}

instrumentation/aws-lambda-1.0/library/src/main/java/io/opentelemetry/instrumentation/awslambda/v1_0/internal/ApiGatewayProxyAttributesExtractor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
import java.net.URLEncoder;
2424
import java.nio.charset.StandardCharsets;
2525
import java.util.Map;
26-
import org.checkerframework.checker.nullness.qual.Nullable;
26+
import javax.annotation.Nullable;
2727

2828
final class ApiGatewayProxyAttributesExtractor
2929
implements AttributesExtractor<AwsLambdaRequest, Object> {

instrumentation/aws-lambda-1.0/library/src/main/java/io/opentelemetry/instrumentation/awslambda/v1_0/internal/AwsLambdaFunctionAttributesExtractor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
import java.lang.invoke.MethodHandle;
1717
import java.lang.invoke.MethodHandles;
1818
import java.lang.invoke.MethodType;
19-
import org.checkerframework.checker.nullness.qual.Nullable;
19+
import javax.annotation.Nullable;
2020

2121
class AwsLambdaFunctionAttributesExtractor
2222
implements AttributesExtractor<AwsLambdaRequest, Object> {

instrumentation/aws-lambda-1.0/library/src/main/java/io/opentelemetry/instrumentation/awslambda/v1_0/internal/AwsLambdaFunctionInstrumenter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
import io.opentelemetry.instrumentation.api.internal.ContextPropagationDebug;
1313
import io.opentelemetry.instrumentation.awslambda.v1_0.AwsLambdaRequest;
1414
import java.util.Map;
15-
import org.checkerframework.checker.nullness.qual.Nullable;
15+
import javax.annotation.Nullable;
1616

1717
public class AwsLambdaFunctionInstrumenter {
1818

instrumentation/aws-lambda-1.0/library/src/main/java/io/opentelemetry/instrumentation/awslambda/v1_0/internal/SqsEventAttributesExtractor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
import io.opentelemetry.api.common.AttributesBuilder;
1010
import io.opentelemetry.instrumentation.api.instrumenter.AttributesExtractor;
1111
import io.opentelemetry.semconv.trace.attributes.SemanticAttributes;
12-
import org.checkerframework.checker.nullness.qual.Nullable;
12+
import javax.annotation.Nullable;
1313

1414
class SqsEventAttributesExtractor implements AttributesExtractor<SQSEvent, Void> {
1515
@Override

instrumentation/aws-lambda-1.0/library/src/main/java/io/opentelemetry/instrumentation/awslambda/v1_0/internal/SqsMessageAttributesExtractor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
import io.opentelemetry.api.common.AttributesBuilder;
1010
import io.opentelemetry.instrumentation.api.instrumenter.AttributesExtractor;
1111
import io.opentelemetry.semconv.trace.attributes.SemanticAttributes;
12-
import org.checkerframework.checker.nullness.qual.Nullable;
12+
import javax.annotation.Nullable;
1313

1414
class SqsMessageAttributesExtractor implements AttributesExtractor<SQSMessage, Void> {
1515
@Override

instrumentation/mongo/mongo-3.1/library/src/main/java/io/opentelemetry/instrumentation/mongo/v3_1/MongoAttributesExtractor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@
1313
import io.opentelemetry.instrumentation.api.instrumenter.AttributesExtractor;
1414
import java.util.HashSet;
1515
import java.util.Set;
16+
import javax.annotation.Nullable;
1617
import org.bson.BsonValue;
17-
import org.checkerframework.checker.nullness.qual.Nullable;
1818

1919
class MongoAttributesExtractor implements AttributesExtractor<CommandStartedEvent, Void> {
2020
@Override

instrumentation/mongo/mongo-3.1/library/src/main/java/io/opentelemetry/instrumentation/mongo/v3_1/MongoNetAttributesExtractor.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,13 @@
88
import com.mongodb.event.CommandStartedEvent;
99
import io.opentelemetry.instrumentation.api.instrumenter.net.InetSocketAddressNetClientAttributesExtractor;
1010
import java.net.InetSocketAddress;
11-
import org.checkerframework.checker.nullness.qual.Nullable;
11+
import javax.annotation.Nullable;
1212

1313
class MongoNetAttributesExtractor
1414
extends InetSocketAddressNetClientAttributesExtractor<CommandStartedEvent, Void> {
1515
@Override
16-
public @Nullable InetSocketAddress getAddress(CommandStartedEvent event, @Nullable Void unused) {
16+
@Nullable
17+
public InetSocketAddress getAddress(CommandStartedEvent event, @Nullable Void unused) {
1718
if (event.getConnectionDescription() != null
1819
&& event.getConnectionDescription().getServerAddress() != null) {
1920
return event.getConnectionDescription().getServerAddress().getSocketAddress();
@@ -23,8 +24,8 @@ class MongoNetAttributesExtractor
2324
}
2425

2526
@Override
26-
public @Nullable String transport(
27-
CommandStartedEvent commandStartedEvent, @Nullable Void unused) {
27+
@Nullable
28+
public String transport(CommandStartedEvent commandStartedEvent, @Nullable Void unused) {
2829
return null;
2930
}
3031
}

0 commit comments

Comments
 (0)