Skip to content

Commit 635484d

Browse files
committed
up level nested class
1 parent 11eea16 commit 635484d

File tree

2 files changed

+30
-22
lines changed

2 files changed

+30
-22
lines changed
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
/*
2+
* Copyright The OpenTelemetry Authors
3+
* SPDX-License-Identifier: Apache-2.0
4+
*/
5+
6+
package io.opentelemetry.javaagent.instrumentation.jdbc.test;
7+
8+
import io.opentelemetry.instrumentation.jdbc.TestConnection;
9+
import java.sql.DatabaseMetaData;
10+
import java.sql.SQLException;
11+
12+
class DbCallingConnection extends TestConnection {
13+
final boolean usePreparedStatement;
14+
15+
DbCallingConnection(boolean usePreparedStatement) {
16+
super(false);
17+
this.usePreparedStatement = usePreparedStatement;
18+
}
19+
20+
@Override
21+
public DatabaseMetaData getMetaData() throws SQLException {
22+
// simulate retrieving DB metadata from the DB itself
23+
if (usePreparedStatement) {
24+
prepareStatement("SELECT * from DB_METADATA").executeQuery();
25+
} else {
26+
createStatement().executeQuery("SELECT * from DB_METADATA");
27+
}
28+
return super.getMetaData();
29+
}
30+
}

instrumentation/jdbc/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/jdbc/test/JdbcInstrumentationTest.java

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@
3131
import java.io.IOException;
3232
import java.sql.CallableStatement;
3333
import java.sql.Connection;
34-
import java.sql.DatabaseMetaData;
3534
import java.sql.Driver;
3635
import java.sql.PreparedStatement;
3736
import java.sql.ResultSet;
@@ -43,7 +42,6 @@
4342
import java.util.List;
4443
import java.util.Locale;
4544
import java.util.Map;
46-
import java.util.Objects;
4745
import java.util.Properties;
4846
import java.util.function.Consumer;
4947
import java.util.stream.Stream;
@@ -1314,26 +1312,6 @@ void testHandleRecursiveStatements(
13141312
equalTo(ServerAttributes.SERVER_ADDRESS, "localhost"))));
13151313
}
13161314

1317-
static class DbCallingConnection extends TestConnection {
1318-
final boolean usePreparedStatement;
1319-
1320-
DbCallingConnection(boolean usePreparedStatement) {
1321-
super(false);
1322-
this.usePreparedStatement = usePreparedStatement;
1323-
}
1324-
1325-
@Override
1326-
public DatabaseMetaData getMetaData() throws SQLException {
1327-
// simulate retrieving DB metadata from the DB itself
1328-
if (usePreparedStatement) {
1329-
prepareStatement("SELECT * from DB_METADATA").executeQuery();
1330-
} else {
1331-
createStatement().executeQuery("SELECT * from DB_METADATA");
1332-
}
1333-
return super.getMetaData();
1334-
}
1335-
}
1336-
13371315
// regression test for
13381316
// https://github.com/open-telemetry/opentelemetry-java-instrumentation/issues/6015
13391317
@DisplayName("test proxy statement")

0 commit comments

Comments
 (0)