Skip to content

Commit 6429d6f

Browse files
committed
post-review changes
1 parent 283f589 commit 6429d6f

File tree

6 files changed

+7
-16
lines changed

6 files changed

+7
-16
lines changed

instrumentation/jaxrs/jaxrs-1.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/jaxrs/v1_0/JaxrsAnnotationsInstrumentation.java

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
import io.opentelemetry.instrumentation.api.semconv.http.HttpServerRoute;
2323
import io.opentelemetry.instrumentation.api.semconv.http.HttpServerRouteSource;
2424
import io.opentelemetry.javaagent.bootstrap.CallDepth;
25-
import io.opentelemetry.javaagent.bootstrap.Java8BytecodeBridge;
2625
import io.opentelemetry.javaagent.extension.instrumentation.TypeInstrumentation;
2726
import io.opentelemetry.javaagent.extension.instrumentation.TypeTransformer;
2827
import java.lang.reflect.Method;
@@ -83,7 +82,7 @@ public AdviceScope(CallDepth callDepth, Class<?> type, Method method) {
8382
return;
8483
}
8584

86-
Context parentContext = Java8BytecodeBridge.currentContext();
85+
Context parentContext = Context.current();
8786
handlerData = new HandlerData(type, method);
8887

8988
HttpServerRoute.update(
@@ -103,11 +102,7 @@ public AdviceScope(CallDepth callDepth, Class<?> type, Method method) {
103102
}
104103

105104
public void exit(@Nullable Throwable throwable) {
106-
if (callDepth.decrementAndGet() > 0) {
107-
return;
108-
}
109-
110-
if (scope == null) {
105+
if (callDepth.decrementAndGet() > 0 || scope == null) {
111106
return;
112107
}
113108
scope.close();

instrumentation/jaxrs/jaxrs-2.0/jaxrs-2.0-annotations/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/jaxrs/v2_0/DefaultRequestContextInstrumentation.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
import io.opentelemetry.context.Scope;
1212
import io.opentelemetry.instrumentation.api.semconv.http.HttpServerRoute;
1313
import io.opentelemetry.instrumentation.api.semconv.http.HttpServerRouteSource;
14-
import io.opentelemetry.javaagent.bootstrap.Java8BytecodeBridge;
1514
import io.opentelemetry.javaagent.instrumentation.jaxrs.JaxrsConstants;
1615
import io.opentelemetry.javaagent.instrumentation.jaxrs.JaxrsServerSpanNaming;
1716
import java.lang.reflect.Method;
@@ -51,7 +50,7 @@ private AdviceScope(Context context, Scope scope, Jaxrs2HandlerData handlerData)
5150
@Nullable
5251
public static AdviceScope enter(Class<?> filterClass, Method method) {
5352

54-
Context parentContext = Java8BytecodeBridge.currentContext();
53+
Context parentContext = Context.current();
5554
Jaxrs2HandlerData handlerData = new Jaxrs2HandlerData(filterClass, method);
5655

5756
HttpServerRoute.update(

instrumentation/jaxrs/jaxrs-2.0/jaxrs-2.0-annotations/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/jaxrs/v2_0/JaxrsAnnotationsInstrumentation.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
import io.opentelemetry.instrumentation.api.semconv.http.HttpServerRoute;
2424
import io.opentelemetry.instrumentation.api.semconv.http.HttpServerRouteSource;
2525
import io.opentelemetry.javaagent.bootstrap.CallDepth;
26-
import io.opentelemetry.javaagent.bootstrap.Java8BytecodeBridge;
2726
import io.opentelemetry.javaagent.extension.instrumentation.TypeInstrumentation;
2827
import io.opentelemetry.javaagent.extension.instrumentation.TypeTransformer;
2928
import io.opentelemetry.javaagent.instrumentation.jaxrs.AsyncResponseData;
@@ -111,7 +110,7 @@ public AdviceScope(CallDepth callDepth, Object[] args, Object target, Method met
111110
}
112111
asyncResponse = asyncResponseArg;
113112

114-
Context parentContext = Java8BytecodeBridge.currentContext();
113+
Context parentContext = Context.current();
115114
handlerData = new Jaxrs2HandlerData(target.getClass(), method);
116115

117116
HttpServerRoute.update(

instrumentation/jaxrs/jaxrs-2.0/jaxrs-2.0-resteasy-common/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/jaxrs/v2_0/ResteasySingletons.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
import org.jboss.resteasy.core.ResourceLocatorInvoker;
1010
import org.jboss.resteasy.core.ResourceMethodInvoker;
1111

12-
public class ResteasySingletons {
12+
public final class ResteasySingletons {
1313

1414
public static final VirtualField<ResourceLocatorInvoker, String> LOCATOR_NAME =
1515
VirtualField.find(ResourceLocatorInvoker.class, String.class);

instrumentation/jaxrs/jaxrs-3.0/jaxrs-3.0-annotations/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/jaxrs/v3_0/DefaultRequestContextInstrumentation.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
import io.opentelemetry.context.Scope;
1212
import io.opentelemetry.instrumentation.api.semconv.http.HttpServerRoute;
1313
import io.opentelemetry.instrumentation.api.semconv.http.HttpServerRouteSource;
14-
import io.opentelemetry.javaagent.bootstrap.Java8BytecodeBridge;
1514
import io.opentelemetry.javaagent.instrumentation.jaxrs.JaxrsConstants;
1615
import io.opentelemetry.javaagent.instrumentation.jaxrs.JaxrsServerSpanNaming;
1716
import jakarta.ws.rs.container.ContainerRequestContext;
@@ -51,7 +50,7 @@ private AdviceScope(Context context, Scope scope, Jaxrs3HandlerData handlerData)
5150
@Nullable
5251
public static AdviceScope enter(
5352
Class<?> filterClass, Method method, ContainerRequestContext requestContext) {
54-
Context parentContext = Java8BytecodeBridge.currentContext();
53+
Context parentContext = Context.current();
5554
Jaxrs3HandlerData handlerData = new Jaxrs3HandlerData(filterClass, method);
5655

5756
HttpServerRoute.update(

instrumentation/jaxrs/jaxrs-3.0/jaxrs-3.0-annotations/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/jaxrs/v3_0/JaxrsAnnotationsInstrumentation.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
import io.opentelemetry.instrumentation.api.semconv.http.HttpServerRoute;
2424
import io.opentelemetry.instrumentation.api.semconv.http.HttpServerRouteSource;
2525
import io.opentelemetry.javaagent.bootstrap.CallDepth;
26-
import io.opentelemetry.javaagent.bootstrap.Java8BytecodeBridge;
2726
import io.opentelemetry.javaagent.extension.instrumentation.TypeInstrumentation;
2827
import io.opentelemetry.javaagent.extension.instrumentation.TypeTransformer;
2928
import io.opentelemetry.javaagent.instrumentation.jaxrs.AsyncResponseData;
@@ -111,7 +110,7 @@ public AdviceScope(CallDepth callDepth, Class<?> type, Method method, Object[] a
111110
}
112111
asyncResponse = asyncResponseArg;
113112

114-
Context parentContext = Java8BytecodeBridge.currentContext();
113+
Context parentContext = Context.current();
115114
handlerData = new Jaxrs3HandlerData(type, method);
116115

117116
HttpServerRoute.update(

0 commit comments

Comments
 (0)