Skip to content

Commit 653501d

Browse files
committed
add nullaway
1 parent 4415444 commit 653501d

File tree

1 file changed

+19
-16
lines changed

1 file changed

+19
-16
lines changed

instrumentation-api/src/jmh/java/io/opentelemetry/instrumentation/api/instrumenter/InstrumenterBenchmark.java

Lines changed: 19 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,10 @@
3333
@State(Scope.Thread)
3434
public class InstrumenterBenchmark {
3535

36-
private static final Instrumenter<Void, Void> INSTRUMENTER =
37-
Instrumenter.<Void, Void>builder(
36+
private static final Object REQUEST = new Object();
37+
38+
private static final Instrumenter<Object, Void> INSTRUMENTER =
39+
Instrumenter.<Object, Void>builder(
3840
OpenTelemetry.noop(),
3941
"benchmark",
4042
HttpSpanNameExtractor.create(ConstantHttpAttributesGetter.INSTANCE))
@@ -44,75 +46,76 @@ public class InstrumenterBenchmark {
4446

4547
@Benchmark
4648
public Context start() {
47-
return INSTRUMENTER.start(Context.root(), null);
49+
return INSTRUMENTER.start(Context.root(), REQUEST);
4850
}
4951

5052
@Benchmark
5153
public Context startEnd() {
52-
Context context = INSTRUMENTER.start(Context.root(), null);
53-
INSTRUMENTER.end(context, null, null, null);
54+
Context context = INSTRUMENTER.start(Context.root(), REQUEST);
55+
INSTRUMENTER.end(context, REQUEST, null, null);
5456
return context;
5557
}
5658

57-
enum ConstantHttpAttributesGetter implements HttpClientAttributesGetter<Void, Void> {
59+
enum ConstantHttpAttributesGetter implements HttpClientAttributesGetter<Object, Void> {
5860
INSTANCE;
5961

6062
private static final InetSocketAddress PEER_ADDRESS =
6163
InetSocketAddress.createUnresolved("localhost", 8080);
6264

6365
@Override
64-
public String getUrlFull(Void unused) {
66+
public String getUrlFull(Object unused) {
6567
return "https://opentelemetry.io/benchmark";
6668
}
6769

6870
@Override
69-
public String getHttpRequestMethod(Void unused) {
71+
public String getHttpRequestMethod(Object unused) {
7072
return "GET";
7173
}
7274

7375
@Override
74-
public List<String> getHttpRequestHeader(Void unused, String name) {
76+
public List<String> getHttpRequestHeader(Object unused, String name) {
7577
if (name.equalsIgnoreCase("user-agent")) {
7678
return Collections.singletonList("OpenTelemetryBot");
7779
}
7880
return Collections.emptyList();
7981
}
8082

8183
@Override
82-
public Integer getHttpResponseStatusCode(Void unused, Void unused2, @Nullable Throwable error) {
84+
public Integer getHttpResponseStatusCode(
85+
Object unused, Void unused2, @Nullable Throwable error) {
8386
return 200;
8487
}
8588

8689
@Override
87-
public List<String> getHttpResponseHeader(Void unused, Void unused2, String name) {
90+
public List<String> getHttpResponseHeader(Object unused, Void unused2, String name) {
8891
return Collections.emptyList();
8992
}
9093

9194
@Override
92-
public String getNetworkProtocolName(Void unused, @Nullable Void unused2) {
95+
public String getNetworkProtocolName(Object unused, @Nullable Void unused2) {
9396
return "http";
9497
}
9598

9699
@Override
97-
public String getNetworkProtocolVersion(Void unused, @Nullable Void unused2) {
100+
public String getNetworkProtocolVersion(Object unused, @Nullable Void unused2) {
98101
return "2.0";
99102
}
100103

101104
@Nullable
102105
@Override
103-
public String getServerAddress(Void request) {
106+
public String getServerAddress(Object request) {
104107
return null;
105108
}
106109

107110
@Nullable
108111
@Override
109-
public Integer getServerPort(Void request) {
112+
public Integer getServerPort(Object request) {
110113
return null;
111114
}
112115

113116
@Override
114117
public InetSocketAddress getNetworkPeerInetSocketAddress(
115-
Void request, @Nullable Void response) {
118+
Object request, @Nullable Void response) {
116119
return PEER_ADDRESS;
117120
}
118121
}

0 commit comments

Comments
 (0)