fix test

Author: jaydeluca

instrumentation-docs/src/main/java/io/opentelemetry/instrumentation/docs/utils/YamlHelper.java

@@ -140,7 +140,7 @@ private static Map<String, Object> baseProperties(InstrumentationModule module)
         Map<String, Object> telemetryEntry = new LinkedHashMap<>();
         telemetryEntry.put("when", group);
         List<EmittedMetrics.Metric> metrics =
-            module.getMetrics().getOrDefault(group, Collections.emptyList());
+            new ArrayList<>(module.getMetrics().getOrDefault(group, Collections.emptyList()));
         List<Map<String, Object>> metricsList = new ArrayList<>();
 
         // sort metrics by name for some determinism in the order

instrumentation-docs/src/test/java/io/opentelemetry/instrumentation/docs/utils/YamlHelperTest.java

@@ -332,22 +332,24 @@ void testMetricsParsing() throws Exception {
             target_versions:
               library:
               - org.apache.mylib:mylib-core:2.3.0
-            metrics:
-            - name: db.client.operation.duration
-              description: Duration of database client operations.
-              type: HISTOGRAM
-              unit: s
-              attributes:
-              - name: db.namespace
-                type: STRING
-              - name: db.operation.name
-                type: STRING
-              - name: db.system.name
-                type: STRING
-              - name: server.address
-                type: STRING
-              - name: server.port
-                type: LONG
+            telemetry:
+            - when: default
+              metrics:
+              - name: db.client.operation.duration
+                description: Duration of database client operations.
+                type: HISTOGRAM
+                unit: s
+                attributes:
+                - name: db.namespace
+                  type: STRING
+                - name: db.operation.name
+                  type: STRING
+                - name: db.system.name
+                  type: STRING
+                - name: server.address
+                  type: STRING
+                - name: server.port
+                  type: LONG
         """;
 
     assertThat(expectedYaml).isEqualTo(stringWriter.toString());