post-review changes again

SylvainJuge · SylvainJuge · commit 6575f22ddd80 · 2025-06-24T10:52:24.000+02:00
diff --git a/instrumentation/logback/logback-appender-1.0/library/build.gradle.kts b/instrumentation/logback/logback-appender-1.0/library/build.gradle.kts
@@ -155,6 +155,7 @@ tasks {
   }
 
   check {
+    dependsOn(testing.suites)
     dependsOn(testStableSemconv)
     dependsOn(testBothSemconv)
   }
diff --git a/instrumentation/rxjava/rxjava-2.0/javaagent/src/test/java/BaseRxJava2WithSpanTest.java b/instrumentation/rxjava/rxjava-2.0/javaagent/src/test/java/BaseRxJava2WithSpanTest.java
@@ -61,7 +61,7 @@ public void captureSpanForCompletedCompletable() {
                             .hasKind(SpanKind.INTERNAL)
                             .hasNoParent()
                             .hasAttributesSatisfyingExactly(
-                                codeFunctionSuffixAssertions("TracedWithSpan", "completable"))));
+                                codeFunctionSuffixAssertions(".TracedWithSpan", "completable"))));
   }
 
   @Test
diff --git a/instrumentation/spring/spring-webmvc/spring-webmvc-common/testing/src/main/java/io/opentelemetry/instrumentation/spring/webmvc/filter/AbstractServletFilterTest.java b/instrumentation/spring/spring-webmvc/spring-webmvc-common/testing/src/main/java/io/opentelemetry/instrumentation/spring/webmvc/filter/AbstractServletFilterTest.java
@@ -100,7 +100,7 @@ protected List<Consumer<SpanDataAssert>> errorPageSpanAssertions(
                 .hasKind(SpanKind.INTERNAL)
                 .hasAttributesSatisfyingExactly(
                     SemconvCodeStabilityUtil.codeFunctionSuffixAssertions(
-                        "BasicErrorController", "error")));
+                        ".BasicErrorController", "error")));
     return spanAssertions;
   }
 

Original file line number	Diff line number	Diff line change
`@@ -155,6 +155,7 @@ tasks {`
`155`	`155`	`}`
`156`	`156`
`157`	`157`	`check {`
	`158`	`+ dependsOn(testing.suites)`
`158`	`159`	`dependsOn(testStableSemconv)`
`159`	`160`	`dependsOn(testBothSemconv)`
`160`	`161`	`}`
Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,7 @@ public void captureSpanForCompletedCompletable() {`
`61`	`61`	`.hasKind(SpanKind.INTERNAL)`
`62`	`62`	`.hasNoParent()`
`63`	`63`	`.hasAttributesSatisfyingExactly(`
`64`		`- codeFunctionSuffixAssertions("TracedWithSpan", "completable"))));`
	`64`	`+ codeFunctionSuffixAssertions(".TracedWithSpan", "completable"))));`
`65`	`65`	`}`
`66`	`66`
`67`	`67`	`@Test`
Original file line number	Diff line number	Diff line change
`@@ -100,7 +100,7 @@ protected List<Consumer<SpanDataAssert>> errorPageSpanAssertions(`
`100`	`100`	`.hasKind(SpanKind.INTERNAL)`
`101`	`101`	`.hasAttributesSatisfyingExactly(`
`102`	`102`	`SemconvCodeStabilityUtil.codeFunctionSuffixAssertions(`
`103`		`- "BasicErrorController", "error")));`
	`103`	`+ ".BasicErrorController", "error")));`
`104`	`104`	`return spanAssertions;`
`105`	`105`	`}`
`106`	`106`