Skip to content

Commit 682b5e0

Browse files
committed
fix rebase
1 parent bd7f765 commit 682b5e0

File tree

7 files changed

+14
-139
lines changed

7 files changed

+14
-139
lines changed

javaagent-extension-api/build.gradle.kts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,3 @@ dependencies {
2222
// Used by byte-buddy but not brought in as a transitive dependency.
2323
compileOnly("com.google.code.findbugs:annotations")
2424
}
25-
26-
// Needed by mockito
27-
configurations.testRuntimeClasspath {
28-
exclude(group = "net.bytebuddy", module = "byte-buddy-dep")
29-
}

javaagent-extension-api/src/main/java/io/opentelemetry/javaagent/extension/ConfigPropertiesUtil.java

Lines changed: 0 additions & 40 deletions
This file was deleted.

javaagent-extension-api/src/main/java/io/opentelemetry/javaagent/extension/DeclarativeConfigPropertiesBridge.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -237,6 +237,6 @@ private static String getJavaPath(String property) {
237237
} else if (property.startsWith(OTEL_JAVA_AGENT_PREFIX)) {
238238
return "agent." + property.substring(OTEL_JAVA_AGENT_PREFIX.length()).replace('-', '_');
239239
}
240-
return null;
240+
return property;
241241
}
242242
}

javaagent-extension-api/src/test/java/io/opentelemetry/javaagent/extension/ConfigPropertiesUtilTest.java

Lines changed: 0 additions & 87 deletions
This file was deleted.

javaagent-extension-api/src/test/java/io/opentelemetry/javaagent/extension/DeclarativeConfigPropertiesBridgeTest.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,12 @@ void getProperties() {
114114
.isEqualTo(expectedMap);
115115
}
116116

117-
// tests for specific properties
117+
@Test
118+
void vendor() {
119+
// verify vendor specific property names are preserved in unchanged form (prefix is not stripped
120+
// as for otel.instrumentation.*)
121+
assertThat(bridge.getBoolean("acme.full_name.preserved")).isTrue();
122+
}
118123

119124
@DisplayName("properties from the general instrumentation section in config.yaml")
120125
@Test

javaagent-extension-api/src/test/resources/config.yaml

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,10 @@ instrumentation/development:
88
- peer: 2.3.4.5
99
service: BarService
1010
http:
11-
# known_methods:
12-
# - GET
13-
# - POST
14-
# - PUT
11+
# known_methods:
12+
# - GET
13+
# - POST
14+
# - PUT
1515
client:
1616
request_captured_headers:
1717
- Content-Type
@@ -27,6 +27,9 @@ instrumentation/development:
2727
- Content-Type
2828
- Content-Encoding
2929
java:
30+
acme:
31+
full_name:
32+
preserved: true
3033
agent:
3134
experimental:
3235
indy: true

javaagent-tooling/src/main/java/io/opentelemetry/javaagent/tooling/AgentInstaller.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@
3030
import io.opentelemetry.javaagent.bootstrap.internal.AgentInstrumentationConfig;
3131
import io.opentelemetry.javaagent.bootstrap.internal.ConfiguredResourceAttributesHolder;
3232
import io.opentelemetry.javaagent.extension.AgentListener;
33-
import io.opentelemetry.javaagent.extension.ConfigPropertiesUtil;
3433
import io.opentelemetry.javaagent.extension.ignore.IgnoredTypesConfigurer;
3534
import io.opentelemetry.javaagent.extension.instrumentation.internal.EarlyInstrumentationModule;
3635
import io.opentelemetry.javaagent.tooling.asyncannotationsupport.WeakRefAsyncOperationEndStrategies;

0 commit comments

Comments
 (0)