Skip to content

Commit 684aaf3

Browse files
committed
use builder
1 parent f6faa48 commit 684aaf3

File tree

2 files changed

+3
-10
lines changed

2 files changed

+3
-10
lines changed

smoke-tests/src/test/java/io/opentelemetry/smoketest/SdkDisabledSmokeTest.java

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -29,16 +29,9 @@ class SdkDisabledSmokeTest {
2929
@ValueSource(ints = {8, 11, 17})
3030
void noopSdkSmokeTest(int jdk) throws Exception {
3131
SmokeTestOutput output = testing.start(jdk);
32-
String currentAgentVersion =
33-
new JarFile(testing.getAgentPath())
34-
.getManifest()
35-
.getMainAttributes()
36-
.get(Attributes.Name.IMPLEMENTATION_VERSION)
37-
.toString();
38-
3932
assertThat(testing.client().get("/greeting").aggregate().join().contentUtf8()).isEqualTo("Hi!");
4033
assertThat(testing.spans()).isEmpty();
41-
output.assertVersionLogged(currentAgentVersion);
34+
output.assertVersionLogged(testing.getAgentImplementationVersion());
4235
assertThat(testing.spans()).isEmpty();
4336
}
4437
}

smoke-tests/src/test/java/io/opentelemetry/smoketest/SpringBootSmokeTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,10 +36,10 @@ class SpringBootSmokeTest {
3636
@ParameterizedTest
3737
@ValueSource(ints = {8, 11, 17, 21, 23})
3838
void springBootSmokeTest(int jdk) throws Exception {
39-
SmokeTestOutput output = testing.startTarget(jdk);
39+
SmokeTestOutput output = testing.start(jdk);
4040
String currentAgentVersion = testing.getAgentImplementationVersion();
4141

42-
var response = client().get("/greeting").aggregate().join();
42+
var response = testing.client().get("/greeting").aggregate().join();
4343
assertThat(response.contentUtf8()).isEqualTo("Hi!");
4444

4545
testing.waitAndAssertTraces(

0 commit comments

Comments
 (0)