Skip to content

Commit 69a8841

Browse files
committed
Remove deprecated from the new classes
1 parent 4e8bdb3 commit 69a8841

File tree

2 files changed

+2
-48
lines changed

2 files changed

+2
-48
lines changed

instrumentation/ktor/ktor-2-common/library/src/main/kotlin/io/opentelemetry/instrumentation/ktor/v2_0/common/client/AbstractKtorClientTelemetryBuilder.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ abstract class AbstractKtorClientTelemetryBuilder(
6363
builder.setKnownMethods(methods.toSet())
6464
}
6565

66-
fun attributeExtractor(extractorBuilder: ExtractorBuilder.() -> Unit = {}) {
66+
fun attributesExtractor(extractorBuilder: ExtractorBuilder.() -> Unit = {}) {
6767
val builder = ExtractorBuilder().apply(extractorBuilder).build()
6868
this.builder.addAttributeExtractor(
6969
object : AttributesExtractor<HttpRequestData, HttpResponse> {

instrumentation/ktor/ktor-2-common/library/src/main/kotlin/io/opentelemetry/instrumentation/ktor/v2_0/common/server/AbstractKtorServerTelemetryBuilder.kt

Lines changed: 1 addition & 47 deletions
Original file line numberDiff line numberDiff line change
@@ -40,15 +40,6 @@ abstract class AbstractKtorServerTelemetryBuilder(private val instrumentationNam
4040
)
4141
}
4242

43-
@Deprecated("Please use method `spanStatusExtractor`")
44-
fun setStatusExtractor(
45-
extractor: (SpanStatusExtractor<in ApplicationRequest, in ApplicationResponse>) -> SpanStatusExtractor<in ApplicationRequest, in ApplicationResponse>
46-
) {
47-
spanStatusExtractor { prevStatusExtractor ->
48-
extractor(prevStatusExtractor).extract(spanStatusBuilder, request, response, error)
49-
}
50-
}
51-
5243
fun spanStatusExtractor(extract: SpanStatusData.(SpanStatusExtractor<in ApplicationRequest, in ApplicationResponse>) -> Unit) {
5344
builder.setStatusExtractor { prevExtractor ->
5445
SpanStatusExtractor { spanStatusBuilder: SpanStatusBuilder,
@@ -70,13 +61,6 @@ abstract class AbstractKtorServerTelemetryBuilder(private val instrumentationNam
7061
val error: Throwable?
7162
)
7263

73-
@Deprecated("Please use method `spanKindExtractor`")
74-
fun setSpanKindExtractor(extractor: (SpanKindExtractor<ApplicationRequest>) -> SpanKindExtractor<ApplicationRequest>) {
75-
spanKindExtractor { prevSpanKindExtractor ->
76-
extractor(prevSpanKindExtractor).extract(this)
77-
}
78-
}
79-
8064
fun spanKindExtractor(extract: ApplicationRequest.(SpanKindExtractor<ApplicationRequest>) -> SpanKind) {
8165
spanKindExtractor = { prevExtractor ->
8266
SpanKindExtractor<ApplicationRequest> { request: ApplicationRequest ->
@@ -85,19 +69,7 @@ abstract class AbstractKtorServerTelemetryBuilder(private val instrumentationNam
8569
}
8670
}
8771

88-
@Deprecated("Please use method `attributeExtractor`")
89-
fun addAttributeExtractor(extractor: AttributesExtractor<in ApplicationRequest, in ApplicationResponse>) {
90-
attributeExtractor {
91-
onStart {
92-
extractor.onStart(attributes, parentContext, request)
93-
}
94-
onEnd {
95-
extractor.onEnd(attributes, parentContext, request, response, error)
96-
}
97-
}
98-
}
99-
100-
fun attributeExtractor(extractorBuilder: ExtractorBuilder.() -> Unit = {}) {
72+
fun attributesExtractor(extractorBuilder: ExtractorBuilder.() -> Unit = {}) {
10173
val builder = ExtractorBuilder().apply(extractorBuilder).build()
10274
this.builder.addAttributesExtractor(
10375
object : AttributesExtractor<ApplicationRequest, ApplicationResponse> {
@@ -145,36 +117,18 @@ abstract class AbstractKtorServerTelemetryBuilder(private val instrumentationNam
145117
val error: Throwable?
146118
)
147119

148-
@Deprecated(
149-
"Please use method `capturedRequestHeaders`",
150-
ReplaceWith("capturedRequestHeaders(headers)")
151-
)
152-
fun setCapturedRequestHeaders(headers: List<String>) = capturedRequestHeaders(headers)
153-
154120
fun capturedRequestHeaders(vararg headers: String) = capturedRequestHeaders(headers.asIterable())
155121

156122
fun capturedRequestHeaders(headers: Iterable<String>) {
157123
builder.setCapturedRequestHeaders(headers.toList())
158124
}
159125

160-
@Deprecated(
161-
"Please use method `capturedResponseHeaders`",
162-
ReplaceWith("capturedResponseHeaders(headers)")
163-
)
164-
fun setCapturedResponseHeaders(headers: List<String>) = capturedResponseHeaders(headers)
165-
166126
fun capturedResponseHeaders(vararg headers: String) = capturedResponseHeaders(headers.asIterable())
167127

168128
fun capturedResponseHeaders(headers: Iterable<String>) {
169129
builder.setCapturedResponseHeaders(headers.toList())
170130
}
171131

172-
@Deprecated(
173-
"Please use method `knownMethods`",
174-
ReplaceWith("knownMethods(knownMethods)")
175-
)
176-
fun setKnownMethods(knownMethods: Set<String>) = knownMethods(knownMethods)
177-
178132
fun knownMethods(vararg methods: String) = knownMethods(methods.asIterable())
179133

180134
fun knownMethods(vararg methods: HttpMethod) = knownMethods(methods.asIterable())

0 commit comments

Comments
 (0)