Skip to content

Commit 6a1d539

Browse files
committed
improve handling of general properties, signal if declarative config is available at all
1 parent 96e8f4c commit 6a1d539

File tree

1 file changed

+0
-20
lines changed

1 file changed

+0
-20
lines changed

javaagent-extension-api/src/test/java/io/opentelemetry/javaagent/extension/internal/DeclarativeConfigPropertiesBridgeTest.java

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
package io.opentelemetry.javaagent.extension.internal;
77

88
import static org.assertj.core.api.Assertions.assertThat;
9-
import static org.assertj.core.data.MapEntry.entry;
109

1110
import io.opentelemetry.sdk.autoconfigure.spi.ConfigProperties;
1211
import io.opentelemetry.sdk.extension.incubator.fileconfig.DeclarativeConfiguration;
@@ -20,7 +19,6 @@
2019
import java.util.Map;
2120
import java.util.Objects;
2221
import org.junit.jupiter.api.BeforeEach;
23-
import org.junit.jupiter.api.DisplayName;
2422
import org.junit.jupiter.api.Test;
2523

2624
class DeclarativeConfigPropertiesBridgeTest {
@@ -121,24 +119,6 @@ void vendor() {
121119
assertThat(bridge.getBoolean("acme.full_name.preserved")).isTrue();
122120
}
123121

124-
@DisplayName("properties from the general instrumentation section in config.yaml")
125-
@Test
126-
void general() {
127-
assertThat(bridge.getMap("otel.instrumentation.common.peer-service-mapping"))
128-
.containsOnly(entry("1.2.3.4", "FooService"), entry("2.3.4.5", "BarService"));
129-
// not supported in SDK yet (this is strictly typed)
130-
// assertThat(bridge.getList("otel.instrumentation.http.known-methods"))
131-
// .containsExactly("GET", "POST", "PUT");
132-
assertThat(bridge.getList("otel.instrumentation.http.client.capture-request-headers"))
133-
.containsExactly("Content-Type", "Accept");
134-
assertThat(bridge.getList("otel.instrumentation.http.client.capture-response-headers"))
135-
.containsExactly("Content-Type", "Content-Encoding");
136-
assertThat(bridge.getList("otel.instrumentation.http.server.capture-request-headers"))
137-
.containsExactly("Content-Type", "Accept");
138-
assertThat(bridge.getList("otel.instrumentation.http.server.capture-response-headers"))
139-
.containsExactly("Content-Type", "Content-Encoding");
140-
}
141-
142122
@Test
143123
void common() {
144124
assertThat(bridge.getBoolean("otel.instrumentation.common.default-enabled")).isFalse();

0 commit comments

Comments
 (0)