Skip to content

Commit 6a570cc

Browse files
committed
avoid java8 bridge when we can
1 parent bb73209 commit 6a570cc

File tree

11 files changed

+15
-25
lines changed

11 files changed

+15
-25
lines changed

instrumentation/spring/spring-batch-3.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/spring/batch/v3_0/AdviceScope.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55

66
package io.opentelemetry.javaagent.instrumentation.spring.batch.v3_0;
77

8-
import static io.opentelemetry.javaagent.bootstrap.Java8BytecodeBridge.currentContext;
98
import static io.opentelemetry.javaagent.instrumentation.spring.batch.v3_0.SpringBatchInstrumentationConfig.shouldTraceItems;
109
import static io.opentelemetry.javaagent.instrumentation.spring.batch.v3_0.item.ItemSingletons.getChunkContext;
1110
import static io.opentelemetry.javaagent.instrumentation.spring.batch.v3_0.item.ItemSingletons.itemInstrumenter;
@@ -29,7 +28,7 @@ private AdviceScope(Context context, Scope scope, String item) {
2928

3029
@Nullable
3130
public static AdviceScope enter(String itemName) {
32-
Context parentContext = currentContext();
31+
Context parentContext = Context.current();
3332
ChunkContext chunkContext = getChunkContext(parentContext);
3433
if (chunkContext == null || !shouldTraceItems()) {
3534
return null;

instrumentation/spring/spring-batch-3.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/spring/batch/v3_0/chunk/TracingChunkExecutionListener.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@
55

66
package io.opentelemetry.javaagent.instrumentation.spring.batch.v3_0.chunk;
77

8-
import static io.opentelemetry.javaagent.bootstrap.Java8BytecodeBridge.currentContext;
9-
import static io.opentelemetry.javaagent.bootstrap.Java8BytecodeBridge.rootContext;
108
import static io.opentelemetry.javaagent.instrumentation.spring.batch.v3_0.SpringBatchInstrumentationConfig.shouldCreateRootSpanForChunk;
119
import static io.opentelemetry.javaagent.instrumentation.spring.batch.v3_0.chunk.ChunkSingletons.chunkInstrumenter;
1210

@@ -31,7 +29,7 @@ public TracingChunkExecutionListener(Class<?> builderClass) {
3129

3230
@Override
3331
public void beforeChunk(ChunkContext chunkContext) {
34-
Context parentContext = shouldCreateRootSpanForChunk() ? rootContext() : currentContext();
32+
Context parentContext = shouldCreateRootSpanForChunk() ? Context.root() : Context.current();
3533
chunkContextAndBuilder = new ChunkContextAndBuilder(chunkContext, builderClass);
3634
if (!chunkInstrumenter().shouldStart(parentContext, chunkContextAndBuilder)) {
3735
return;

instrumentation/spring/spring-batch-3.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/spring/batch/v3_0/job/TracingJobExecutionListener.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55

66
package io.opentelemetry.javaagent.instrumentation.spring.batch.v3_0.job;
77

8-
import static io.opentelemetry.javaagent.bootstrap.Java8BytecodeBridge.currentContext;
98
import static io.opentelemetry.javaagent.instrumentation.spring.batch.v3_0.job.JobSingletons.jobInstrumenter;
109

1110
import io.opentelemetry.context.Context;
@@ -25,7 +24,7 @@ public TracingJobExecutionListener() {}
2524

2625
@Override
2726
public void beforeJob(JobExecution jobExecution) {
28-
Context parentContext = currentContext();
27+
Context parentContext = Context.current();
2928
if (!jobInstrumenter().shouldStart(parentContext, jobExecution)) {
3029
return;
3130
}

instrumentation/spring/spring-batch-3.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/spring/batch/v3_0/step/TracingStepExecutionListener.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55

66
package io.opentelemetry.javaagent.instrumentation.spring.batch.v3_0.step;
77

8-
import static io.opentelemetry.javaagent.bootstrap.Java8BytecodeBridge.currentContext;
98
import static io.opentelemetry.javaagent.instrumentation.spring.batch.v3_0.step.StepSingletons.stepInstrumenter;
109

1110
import io.opentelemetry.context.Context;
@@ -26,7 +25,7 @@ public TracingStepExecutionListener() {}
2625

2726
@Override
2827
public void beforeStep(StepExecution stepExecution) {
29-
Context parentContext = currentContext();
28+
Context parentContext = Context.current();
3029
if (!stepInstrumenter().shouldStart(parentContext, stepExecution)) {
3130
return;
3231
}

instrumentation/spring/spring-jms/spring-jms-2.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/spring/jms/v2_0/SpringJmsMessageListenerInstrumentation.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515

1616
import io.opentelemetry.context.Context;
1717
import io.opentelemetry.context.Scope;
18-
import io.opentelemetry.javaagent.bootstrap.Java8BytecodeBridge;
1918
import io.opentelemetry.javaagent.bootstrap.jms.JmsReceiveContextHolder;
2019
import io.opentelemetry.javaagent.extension.instrumentation.TypeInstrumentation;
2120
import io.opentelemetry.javaagent.extension.instrumentation.TypeTransformer;
@@ -66,7 +65,7 @@ private AdviceScope(MessageWithDestination request, Context context, Scope scope
6665

6766
@Nullable
6867
public static AdviceScope enter(Message message) {
69-
Context parentContext = Java8BytecodeBridge.currentContext();
68+
Context parentContext = Context.current();
7069
Context receiveContext = JmsReceiveContextHolder.getReceiveContext(parentContext);
7170
if (receiveContext != null) {
7271
parentContext = receiveContext;

instrumentation/spring/spring-jms/spring-jms-6.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/spring/jms/v6_0/SpringJmsMessageListenerInstrumentation.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515

1616
import io.opentelemetry.context.Context;
1717
import io.opentelemetry.context.Scope;
18-
import io.opentelemetry.javaagent.bootstrap.Java8BytecodeBridge;
1918
import io.opentelemetry.javaagent.bootstrap.jms.JmsReceiveContextHolder;
2019
import io.opentelemetry.javaagent.extension.instrumentation.TypeInstrumentation;
2120
import io.opentelemetry.javaagent.extension.instrumentation.TypeTransformer;
@@ -66,7 +65,7 @@ private AdviceScope(MessageWithDestination request, Context context, Scope scope
6665

6766
@Nullable
6867
public static AdviceScope enter(Message message) {
69-
Context parentContext = Java8BytecodeBridge.currentContext();
68+
Context parentContext = Context.current();
7069
Context receiveContext = JmsReceiveContextHolder.getReceiveContext(parentContext);
7170
if (receiveContext != null) {
7271
parentContext = receiveContext;

instrumentation/spring/spring-webmvc/spring-webmvc-3.1/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/spring/webmvc/v3_1/DispatcherServletInstrumentation.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55

66
package io.opentelemetry.javaagent.instrumentation.spring.webmvc.v3_1;
77

8-
import static io.opentelemetry.javaagent.bootstrap.Java8BytecodeBridge.currentContext;
98
import static io.opentelemetry.javaagent.instrumentation.spring.webmvc.v3_1.SpringWebMvcSingletons.modelAndViewInstrumenter;
109
import static net.bytebuddy.matcher.ElementMatchers.isMethod;
1110
import static net.bytebuddy.matcher.ElementMatchers.isProtected;
@@ -88,7 +87,7 @@ private AdviceScope(Context context, Scope scope) {
8887

8988
@Nullable
9089
public static AdviceScope enter(ModelAndView mv) {
91-
Context parentContext = currentContext();
90+
Context parentContext = Context.current();
9291
if (!modelAndViewInstrumenter().shouldStart(parentContext, mv)) {
9392
return null;
9493
}

instrumentation/spring/spring-webmvc/spring-webmvc-3.1/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/spring/webmvc/v3_1/HandlerAdapterInstrumentation.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,10 @@
1616
import static net.bytebuddy.matcher.ElementMatchers.takesArgument;
1717
import static net.bytebuddy.matcher.ElementMatchers.takesArguments;
1818

19+
import io.opentelemetry.api.trace.Span;
1920
import io.opentelemetry.context.Context;
2021
import io.opentelemetry.context.Scope;
2122
import io.opentelemetry.instrumentation.api.semconv.http.HttpServerRoute;
22-
import io.opentelemetry.javaagent.bootstrap.Java8BytecodeBridge;
2323
import io.opentelemetry.javaagent.extension.instrumentation.TypeInstrumentation;
2424
import io.opentelemetry.javaagent.extension.instrumentation.TypeTransformer;
2525
import io.opentelemetry.javaagent.instrumentation.spring.webmvc.IsGrailsHandler;
@@ -72,10 +72,10 @@ public static AdviceScope enter(HttpServletRequest request, Object handler) {
7272
return null;
7373
}
7474

75-
Context parentContext = Java8BytecodeBridge.currentContext();
75+
Context parentContext = Context.current();
7676

7777
// don't start a new top-level span
78-
if (!Java8BytecodeBridge.spanFromContext(parentContext).getSpanContext().isValid()) {
78+
if (!Span.fromContext(parentContext).getSpanContext().isValid()) {
7979
return null;
8080
}
8181

instrumentation/spring/spring-webmvc/spring-webmvc-6.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/spring/webmvc/v6_0/DispatcherServletInstrumentation.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55

66
package io.opentelemetry.javaagent.instrumentation.spring.webmvc.v6_0;
77

8-
import static io.opentelemetry.javaagent.bootstrap.Java8BytecodeBridge.currentContext;
98
import static io.opentelemetry.javaagent.instrumentation.spring.webmvc.v6_0.SpringWebMvcSingletons.modelAndViewInstrumenter;
109
import static net.bytebuddy.matcher.ElementMatchers.isMethod;
1110
import static net.bytebuddy.matcher.ElementMatchers.isProtected;
@@ -89,7 +88,7 @@ private AdviceScope(Context context, Scope scope) {
8988

9089
@Nullable
9190
public static AdviceScope enter(ModelAndView mv) {
92-
Context parentContext = currentContext();
91+
Context parentContext = Context.current();
9392
if (!modelAndViewInstrumenter().shouldStart(parentContext, mv)) {
9493
return null;
9594
}

instrumentation/spring/spring-webmvc/spring-webmvc-6.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/spring/webmvc/v6_0/HandlerAdapterInstrumentation.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,10 @@
1616
import static net.bytebuddy.matcher.ElementMatchers.takesArgument;
1717
import static net.bytebuddy.matcher.ElementMatchers.takesArguments;
1818

19+
import io.opentelemetry.api.trace.Span;
1920
import io.opentelemetry.context.Context;
2021
import io.opentelemetry.context.Scope;
2122
import io.opentelemetry.instrumentation.api.semconv.http.HttpServerRoute;
22-
import io.opentelemetry.javaagent.bootstrap.Java8BytecodeBridge;
2323
import io.opentelemetry.javaagent.extension.instrumentation.TypeInstrumentation;
2424
import io.opentelemetry.javaagent.extension.instrumentation.TypeTransformer;
2525
import io.opentelemetry.javaagent.instrumentation.spring.webmvc.IsGrailsHandler;
@@ -72,10 +72,10 @@ public static AdviceScope enter(HttpServletRequest request, Object handler) {
7272
return null;
7373
}
7474

75-
Context parentContext = Java8BytecodeBridge.currentContext();
75+
Context parentContext = Context.current();
7676

7777
// don't start a new top-level span
78-
if (!Java8BytecodeBridge.spanFromContext(parentContext).getSpanContext().isValid()) {
78+
if (!Span.fromContext(parentContext).getSpanContext().isValid()) {
7979
return null;
8080
}
8181

0 commit comments

Comments
 (0)