Skip to content

Commit 6aa6306

Browse files
committed
fix
1 parent 9b9b075 commit 6aa6306

File tree

4 files changed

+32
-9
lines changed

4 files changed

+32
-9
lines changed

instrumentation/kafka/kafka-clients/kafka-clients-2.6/library/build.gradle.kts

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,8 @@ tasks {
2424

2525
test {
2626
filter {
27-
excludeTestsMatching("*DeprecatedInterceptorsTest")
27+
excludeTestsMatching("*Deprecated*")
2828
}
29-
systemProperty("otel.instrumentation.messaging.experimental.capture-headers", "Test-Message-Header")
3029
}
3130

3231
val testDeprecated by registering(Test::class) {
@@ -39,8 +38,16 @@ tasks {
3938
systemProperty("otel.instrumentation.messaging.experimental.capture-headers", "Test-Message-Header")
4039
}
4140

41+
val testDeprecatedSuppressReceiveSpans by registering(Test::class) {
42+
testClassesDirs = sourceSets.test.get().output.classesDirs
43+
classpath = sourceSets.test.get().runtimeClasspath
44+
filter {
45+
includeTestsMatching("*DeprecatedInterceptorsSuppressReceiveSpansTest")
46+
}
47+
}
48+
4249
check {
43-
dependsOn(testDeprecated)
50+
dependsOn(testDeprecated, testDeprecatedSuppressReceiveSpans)
4451
}
4552
}
4653

instrumentation/kafka/kafka-clients/kafka-clients-2.6/library/src/test/java/io/opentelemetry/instrumentation/kafkaclients/v2_6/AbstractInterceptorsTest.java

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,22 +26,19 @@ abstract class AbstractInterceptorsTest extends KafkaClientBaseTest {
2626

2727
static final String greeting = "Hello Kafka!";
2828

29-
private static final KafkaTelemetry kafkaTelemetry =
30-
KafkaTelemetry.builder(testing.getOpenTelemetry())
31-
.setMessagingReceiveInstrumentationEnabled(true)
32-
.build();
29+
protected abstract KafkaTelemetry kafkaTelemetry();
3330

3431
@Override
3532
public Map<String, Object> producerProps() {
3633
Map<String, Object> props = super.producerProps();
37-
props.putAll(kafkaTelemetry.producerInterceptorConfigProperties());
34+
props.putAll(kafkaTelemetry().producerInterceptorConfigProperties());
3835
return props;
3936
}
4037

4138
@Override
4239
public Map<String, Object> consumerProps() {
4340
Map<String, Object> props = super.consumerProps();
44-
props.putAll(kafkaTelemetry.consumerInterceptorConfigProperties());
41+
props.putAll(kafkaTelemetry().consumerInterceptorConfigProperties());
4542
return props;
4643
}
4744

instrumentation/kafka/kafka-clients/kafka-clients-2.6/library/src/test/java/io/opentelemetry/instrumentation/kafkaclients/v2_6/InterceptorsSuppressReceiveSpansTest.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,14 @@
2323

2424
class InterceptorsSuppressReceiveSpansTest extends AbstractInterceptorsTest {
2525

26+
private static final KafkaTelemetry kafkaTelemetry =
27+
KafkaTelemetry.create(testing.getOpenTelemetry());
28+
29+
@Override
30+
protected KafkaTelemetry kafkaTelemetry() {
31+
return kafkaTelemetry;
32+
}
33+
2634
@SuppressWarnings("deprecation") // using deprecated semconv
2735
@Override
2836
void assertTraces() {

instrumentation/kafka/kafka-clients/kafka-clients-2.6/library/src/test/java/io/opentelemetry/instrumentation/kafkaclients/v2_6/InterceptorsTest.java

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,17 @@
3030

3131
class InterceptorsTest extends AbstractInterceptorsTest {
3232

33+
private static final KafkaTelemetry kafkaTelemetry =
34+
KafkaTelemetry.builder(testing.getOpenTelemetry())
35+
.setMessagingReceiveInstrumentationEnabled(true)
36+
.setCapturedHeaders(singletonList("Test-Message-Header"))
37+
.build();
38+
39+
@Override
40+
protected KafkaTelemetry kafkaTelemetry() {
41+
return kafkaTelemetry;
42+
}
43+
3344
@SuppressWarnings("deprecation") // using deprecated semconv
3445
@Override
3546
void assertTraces() {

0 commit comments

Comments
 (0)