Updating advice

LikeTheSalad · LikeTheSalad · commit 6acd2d807527 · 2025-10-02T14:27:37.000+02:00
diff --git a/instrumentation/tomcat/tomcat-10.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/tomcat/v10_0/Tomcat10ServerHandlerAdvice.java b/instrumentation/tomcat/tomcat-10.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/tomcat/v10_0/Tomcat10ServerHandlerAdvice.java
@@ -44,11 +44,12 @@ public static AdviceScope start(Request request, Response response) {
       return new AdviceScope(context, scope);
     }
 
-    private void end(Request request, Response response, Throwable throwable) {
+    public void end(Request request, Response response, Throwable throwable) {
       helper().end(request, response, throwable, context, scope);
     }
   }
 
+  @Nullable
   @Advice.OnMethodEnter(suppress = Throwable.class)
   public static AdviceScope onEnter(
       @Advice.Argument(0) Request request, @Advice.Argument(1) Response response) {

Original file line number	Diff line number	Diff line change
`@@ -44,11 +44,12 @@ public static AdviceScope start(Request request, Response response) {`
`44`	`44`	`return new AdviceScope(context, scope);`
`45`	`45`	`}`
`46`	`46`
`47`		`- private void end(Request request, Response response, Throwable throwable) {`
	`47`	`+ public void end(Request request, Response response, Throwable throwable) {`
`48`	`48`	`helper().end(request, response, throwable, context, scope);`
`49`	`49`	`}`
`50`	`50`	`}`
`51`	`51`
	`52`	`+ @Nullable`
`52`	`53`	`@Advice.OnMethodEnter(suppress = Throwable.class)`
`53`	`54`	`public static AdviceScope onEnter(`
`54`	`55`	`@Advice.Argument(0) Request request, @Advice.Argument(1) Response response) {`