Skip to content

Commit 6dea116

Browse files
committed
refine ut
1 parent c63a933 commit 6dea116

File tree

6 files changed

+17
-21
lines changed

6 files changed

+17
-21
lines changed

instrumentation/vertx/vertx-web-3.0/javaagent/src/latestDepTest/java/server/VertxLatestHttpServerTest.java renamed to instrumentation/vertx/vertx-web-3.0/javaagent/src/latestDepTest/java/io/opentelemetry/javaagent/instrumentation/vertx/VertxLatestHttpServerTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
* SPDX-License-Identifier: Apache-2.0
44
*/
55

6-
package server;
6+
package io.opentelemetry.javaagent.instrumentation.vertx;
77

88
import io.vertx.core.AbstractVerticle;
99
import io.vertx.core.Vertx;

instrumentation/vertx/vertx-web-3.0/javaagent/src/latestDepTest/java/server/VertxLatestWebServer.java renamed to instrumentation/vertx/vertx-web-3.0/javaagent/src/latestDepTest/java/io/opentelemetry/javaagent/instrumentation/vertx/VertxLatestWebServer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
* SPDX-License-Identifier: Apache-2.0
44
*/
55

6-
package server;
6+
package io.opentelemetry.javaagent.instrumentation.vertx;
77

88
import io.vertx.core.Promise;
99
import io.vertx.core.http.HttpServerResponse;

instrumentation/vertx/vertx-web-3.0/javaagent/src/version3Test/java/server/VertxHttpServerTest.java renamed to instrumentation/vertx/vertx-web-3.0/javaagent/src/version3Test/java/io/opentelemetry/javaagent/instrumentation/vertx/VertxHttpServerTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
* SPDX-License-Identifier: Apache-2.0
44
*/
55

6-
package server;
6+
package io.opentelemetry.javaagent.instrumentation.vertx;
77

88
import io.vertx.core.AbstractVerticle;
99

instrumentation/vertx/vertx-web-3.0/javaagent/src/version3Test/java/server/VertxWebServer.java renamed to instrumentation/vertx/vertx-web-3.0/javaagent/src/version3Test/java/io/opentelemetry/javaagent/instrumentation/vertx/VertxWebServer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
* SPDX-License-Identifier: Apache-2.0
44
*/
55

6-
package server;
6+
package io.opentelemetry.javaagent.instrumentation.vertx;
77

88
import io.vertx.core.Future;
99
import io.vertx.core.http.HttpServerResponse;

instrumentation/vertx/vertx-web-3.0/testing/src/main/java/server/AbstractVertxHttpServerTest.java renamed to instrumentation/vertx/vertx-web-3.0/testing/src/main/java/io/opentelemetry/javaagent/instrumentation/vertx/AbstractVertxHttpServerTest.java

Lines changed: 12 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,7 @@
33
* SPDX-License-Identifier: Apache-2.0
44
*/
55

6-
package server;
7-
8-
import static io.opentelemetry.instrumentation.testing.junit.http.ServerEndpoint.EXCEPTION;
6+
package io.opentelemetry.javaagent.instrumentation.vertx;
97

108
import io.opentelemetry.instrumentation.api.internal.HttpConstants;
119
import io.opentelemetry.instrumentation.testing.junit.InstrumentationExtension;
@@ -32,23 +30,21 @@ abstract class AbstractVertxHttpServerTest extends AbstractHttpServerTest<Vertx>
3230

3331
@Override
3432
protected void configure(HttpServerTestOptions options) {
33+
super.configure(options);
3534
options.setTestPathParam(true);
3635
// server spans are ended inside of the controller spans
3736
options.setVerifyServerSpanEndTime(false);
3837
options.setContextPath("/vertx-app");
39-
options.setExpectedException(new IllegalStateException(EXCEPTION.getBody()));
40-
super.configure(options);
41-
}
42-
43-
@Override
44-
public String expectedHttpRoute(ServerEndpoint endpoint, String method) {
45-
if (Objects.equals(method, HttpConstants._OTHER)) {
46-
return getContextPath() + endpoint.getPath();
47-
}
48-
if (Objects.equals(endpoint, ServerEndpoint.NOT_FOUND)) {
49-
return getContextPath();
50-
}
51-
return super.expectedHttpRoute(endpoint, method);
38+
options.setExpectedHttpRoute(
39+
(endpoint, method) -> {
40+
if (Objects.equals(method, HttpConstants._OTHER)) {
41+
return getContextPath() + endpoint.getPath();
42+
}
43+
if (Objects.equals(endpoint, ServerEndpoint.NOT_FOUND)) {
44+
return getContextPath();
45+
}
46+
return super.expectedHttpRoute(endpoint, method);
47+
});
5248
}
5349

5450
@Override

instrumentation/vertx/vertx-web-3.0/testing/src/main/java/server/AbstractVertxWebServer.java renamed to instrumentation/vertx/vertx-web-3.0/testing/src/main/java/io/opentelemetry/javaagent/instrumentation/vertx/AbstractVertxWebServer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
* SPDX-License-Identifier: Apache-2.0
44
*/
55

6-
package server;
6+
package io.opentelemetry.javaagent.instrumentation.vertx;
77

88
import static io.opentelemetry.instrumentation.testing.junit.http.AbstractHttpServerTest.controller;
99
import static io.opentelemetry.instrumentation.testing.junit.http.ServerEndpoint.CAPTURE_HEADERS;

0 commit comments

Comments
 (0)