Skip to content

Commit 6e178a8

Browse files
Copilottrask
andcommitted
Document TODOs in check-javaagent-suppression-keys.sh with detailed explanations
Co-authored-by: trask <[email protected]>
1 parent 062d37e commit 6e178a8

File tree

1 file changed

+18
-5
lines changed

1 file changed

+18
-5
lines changed

.github/scripts/check-javaagent-suppression-keys.sh

Lines changed: 18 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,23 +17,36 @@ for file in $(find instrumentation -name "*Module.java"); do
1717
simple_module_name=$(echo "$module_name" | sed 's/-[0-9.]*$//')
1818

1919
if [[ "$simple_module_name" == *jaxrs* ]]; then
20-
# TODO these need some work still
20+
# TODO: JAX-RS modules use "jaxrs" as the main instrumentation name instead of the module name,
21+
# providing multiple alternative names (jaxrs, jaxrs-X.Y, framework-name) for flexibility.
22+
# This allows users to disable all JAX-RS instrumentation with a single key.
23+
# Future work: evaluate if this pattern should be standardized or changed.
2124
continue
2225
fi
2326
if [[ "$simple_module_name" == *jaxws* ]]; then
24-
# TODO these need some work still
27+
# TODO: JAX-WS modules use "jaxws" as the main instrumentation name instead of the module name,
28+
# similar to JAX-RS. Future work: align with the standard pattern or document the exception.
2529
continue
2630
fi
2731
if [[ "$simple_module_name" == jdbc ]]; then
28-
# TODO split jdbc-datasource out into separate instrumentation?
32+
# TODO: The jdbc directory contains two separate InstrumentationModules:
33+
# - JdbcInstrumentationModule with super("jdbc")
34+
# - DataSourceInstrumentationModule with super("jdbc-datasource")
35+
# Consider splitting jdbc-datasource into a separate instrumentation directory to follow
36+
# the standard pattern where each directory contains only one InstrumentationModule.
2937
continue
3038
fi
3139
if [[ "$simple_module_name" == kafka-clients ]]; then
32-
# TODO split kafka client metrics out into separate instrumentation?
40+
# TODO: The kafka-clients-X.Y directory contains two InstrumentationModules:
41+
# - KafkaClientsInstrumentationModule with super("kafka-clients", "kafka-clients-X.Y", "kafka")
42+
# - KafkaMetricsInstrumentationModule with super("kafka-clients-metrics", ...)
43+
# Consider splitting kafka-clients-metrics into a separate instrumentation directory.
3344
continue
3445
fi
3546
if [[ "$simple_module_name" == quarkus-resteasy-reactive ]]; then
36-
# TODO module is missing a base version
47+
# TODO: quarkus-resteasy-reactive should be versioned in the directory name
48+
# (e.g., quarkus-resteasy-reactive-3.0) to follow the standard pattern where
49+
# the directory name matches the versioned instrumentation name.
3750
continue
3851
fi
3952

0 commit comments

Comments
 (0)