Skip to content

Commit 6f20784

Browse files
committed
enhance tests
1 parent 9272bfe commit 6f20784

File tree

1 file changed

+16
-3
lines changed
  • instrumentation/jmx-metrics/library/src/test/java/io/opentelemetry/instrumentation/jmx/engine

1 file changed

+16
-3
lines changed

instrumentation/jmx-metrics/library/src/test/java/io/opentelemetry/instrumentation/jmx/engine/RuleParserTest.java

Lines changed: 16 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -74,18 +74,31 @@ void testConf2() {
7474
assertThat(defs).hasSize(2);
7575

7676
JmxRule def1 = defs.get(0);
77-
assertThat(def1.getBeans()).hasSize(2);
78-
assertThat(def1.getMetricAttribute()).hasSize(2);
77+
assertThat(def1.getBeans()).containsExactly("OBJECT:NAME1=*", "OBJECT:NAME2=*");
78+
assertThat(def1.getMetricAttribute()).hasSize(2)
79+
.containsEntry("LABEL_KEY1", "param(PARAMETER)")
80+
.containsEntry("LABEL_KEY2", "beanattr(ATTRIBUTE)");
7981

8082
Map<String, Metric> attr = def1.getMapping();
81-
assertThat(attr).hasSize(4);
83+
assertThat(attr).hasSize(4)
84+
.containsKeys("ATTRIBUTE1", "ATTRIBUTE2", "ATTRIBUTE3", "ATTRIBUTE4");
8285

8386
Metric m1 = attr.get("ATTRIBUTE1");
8487
assertThat(m1).isNotNull();
8588
assertThat(m1.getMetric()).isEqualTo("METRIC_NAME1");
8689
assertThat(m1.getMetricType()).isEqualTo(MetricInfo.Type.GAUGE);
8790
assertThat(m1.getUnit()).isEqualTo("UNIT1");
8891
assertThat(m1.getMetricAttribute()).containsExactly(entry("LABEL_KEY3", "const(CONSTANT)"));
92+
93+
JmxRule def2 = defs.get(1);
94+
assertThat(def2.getBeans()).containsExactly("OBJECT:NAME3=*");
95+
assertThat(def2.getMetricAttribute()).isNull();
96+
97+
assertThat(def2.getMapping()).hasSize(1);
98+
Metric m3 = def2.getMapping().get("ATTRIBUTE3");
99+
assertThat(m3.getMetric()).isEqualTo("METRIC_NAME3");
100+
assertThat(m3.getUnit()).isNull();
101+
89102
}
90103

91104
private static final String CONF3 =

0 commit comments

Comments
 (0)