Skip to content

Commit 6f31d85

Browse files
committed
fix
1 parent 421922e commit 6f31d85

File tree

6 files changed

+11
-11
lines changed

6 files changed

+11
-11
lines changed

instrumentation/jms/jms-1.1/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/jms/v1_1/AbstractJms1Test.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -318,7 +318,7 @@ private static Stream<Arguments> emptyReceiveArguments() {
318318
arguments(queue, receiveNoWait));
319319
}
320320

321-
private static Stream<Arguments> destinationArguments() {
321+
protected static Stream<Arguments> destinationArguments() {
322322
DestinationFactory topic = session -> session.createTopic("someTopic");
323323
DestinationFactory queue = session -> session.createQueue("someQueue");
324324
DestinationFactory tempTopic = Session::createTemporaryTopic;

instrumentation/jms/jms-1.1/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/jms/v1_1/Jms1InstrumentationTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,13 +23,13 @@
2323
import javax.jms.MessageProducer;
2424
import javax.jms.TextMessage;
2525
import org.junit.jupiter.params.ParameterizedTest;
26-
import org.junit.jupiter.params.provider.ArgumentsSource;
26+
import org.junit.jupiter.params.provider.MethodSource;
2727

2828
class Jms1InstrumentationTest extends AbstractJms1Test {
2929

3030
@SuppressWarnings("deprecation") // using deprecated semconv
31-
@ArgumentsSource(DestinationsProvider.class)
3231
@ParameterizedTest
32+
@MethodSource("destinationArguments")
3333
void testMessageConsumer(
3434
DestinationFactory destinationFactory, String destinationName, boolean isTemporary)
3535
throws JMSException {

instrumentation/jms/jms-1.1/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/jms/v1_1/Jms1SuppressReceiveSpansTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,13 +20,13 @@
2020
import javax.jms.MessageProducer;
2121
import javax.jms.TextMessage;
2222
import org.junit.jupiter.params.ParameterizedTest;
23-
import org.junit.jupiter.params.provider.ArgumentsSource;
23+
import org.junit.jupiter.params.provider.MethodSource;
2424

2525
class Jms1SuppressReceiveSpansTest extends AbstractJms1Test {
2626

2727
@SuppressWarnings("deprecation") // using deprecated semconv
28-
@ArgumentsSource(DestinationsProvider.class)
2928
@ParameterizedTest
29+
@MethodSource("destinationArguments")
3030
void testMessageConsumer(
3131
DestinationFactory destinationFactory, String destinationName, boolean isTemporary)
3232
throws JMSException {

instrumentation/jms/jms-3.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/jms/v3_0/Jms3InstrumentationTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,13 +24,13 @@
2424
import java.util.concurrent.atomic.AtomicReference;
2525
import org.apache.activemq.artemis.jms.client.ActiveMQDestination;
2626
import org.junit.jupiter.params.ParameterizedTest;
27-
import org.junit.jupiter.params.provider.ArgumentsSource;
27+
import org.junit.jupiter.params.provider.MethodSource;
2828

2929
class Jms3InstrumentationTest extends AbstractJms3Test {
3030

3131
@SuppressWarnings("deprecation") // using deprecated semconv
32-
@ArgumentsSource(DestinationsProvider.class)
3332
@ParameterizedTest
33+
@MethodSource("destinationArguments")
3434
void testMessageConsumer(DestinationFactory destinationFactory, boolean isTemporary)
3535
throws JMSException {
3636

instrumentation/jms/jms-3.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/jms/v3_0/Jms3SuppressReceiveSpansTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,13 @@
2121
import jakarta.jms.TextMessage;
2222
import org.apache.activemq.artemis.jms.client.ActiveMQDestination;
2323
import org.junit.jupiter.params.ParameterizedTest;
24-
import org.junit.jupiter.params.provider.ArgumentsSource;
24+
import org.junit.jupiter.params.provider.MethodSource;
2525

2626
class Jms3SuppressReceiveSpansTest extends AbstractJms3Test {
2727

2828
@SuppressWarnings("deprecation") // using deprecated semconv
29-
@ArgumentsSource(DestinationsProvider.class)
3029
@ParameterizedTest
30+
@MethodSource("destinationArguments")
3131
void testMessageConsumer(DestinationFactory destinationFactory, boolean isTemporary)
3232
throws JMSException {
3333

instrumentation/spring/spring-jms/spring-jms-6.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/spring/jms/v6_0/SpringJmsListenerTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
import java.util.concurrent.atomic.AtomicReference;
3030
import org.assertj.core.api.AbstractStringAssert;
3131
import org.junit.jupiter.params.ParameterizedTest;
32-
import org.junit.jupiter.params.provider.ArgumentsSource;
32+
import org.junit.jupiter.params.provider.ValueSource;
3333
import org.springframework.boot.SpringApplication;
3434
import org.springframework.context.ConfigurableApplicationContext;
3535
import org.springframework.jms.core.JmsTemplate;
@@ -82,8 +82,8 @@ void assertSpringJmsListener() {
8282
span -> span.hasName("consumer").hasParent(trace.getSpan(1))));
8383
}
8484

85-
@ArgumentsSource(ConfigClasses.class)
8685
@ParameterizedTest
86+
@ValueSource(classes = {AnnotatedListenerConfig.class, ManualListenerConfig.class})
8787
@SuppressWarnings("unchecked")
8888
void shouldCaptureHeaders(Class<?> configClass)
8989
throws ExecutionException, InterruptedException, TimeoutException {

0 commit comments

Comments
 (0)