Apply suggestions from code review

Author: jaydeluca

.github/workflows/build-common.yml

@@ -249,6 +249,8 @@ jobs:
           - 3
           - 4
           - 5
+          - 6
+          - 7
         test-indy:
           - false
           - true

.github/workflows/reusable-muzzle.yml

@@ -22,6 +22,8 @@ jobs:
           - ":instrumentation:muzzle4"
           - ":instrumentation:muzzle5"
           - ":instrumentation:muzzle6"
+          - ":instrumentation:muzzle7"
+          - ":instrumentation:muzzle8"
       fail-fast: false
     steps:
       - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0

build.gradle.kts

@@ -68,11 +68,11 @@ if (gradle.startParameter.taskNames.contains("listTestsInPartition")) {
       group = "Help"
       description = "List test tasks in given partition"
 
-      // total of 6 partitions (see modulo 6 below)
+      // total of 8 partitions (see modulo 8 below)
       var testPartition = (project.findProperty("testPartition") as String?)?.toInt()
       if (testPartition == null) {
         throw GradleException("Test partition must be specified")
-      } else if (testPartition < 0 || testPartition >= 6) {
+      } else if (testPartition < 0 || testPartition >= 8) {
         throw GradleException("Invalid test partition")
       }
 
@@ -82,7 +82,7 @@ if (gradle.startParameter.taskNames.contains("listTestsInPartition")) {
         // relying on predictable ordering of subprojects
         // (see https://docs.gradle.org/current/dsl/org.gradle.api.Project.html#N14CB4)
         // since we are splitting these tasks across different github action jobs
-        val enabled = testPartitionCounter++ % 6 == testPartition
+        val enabled = testPartitionCounter++ % 8 == testPartition
         if (enabled) {
           tasks.withType<Test>().configureEach {
             partitionTasks.add(this)

instrumentation/build.gradle.kts

@@ -4,7 +4,7 @@ plugins {
 
 val instrumentationProjectTest = tasks.named("test")
 
-// batching up the muzzle tasks alphabetically into 6 chunks
+// batching up the muzzle tasks alphabetically into 8 chunks
 // to split them up into separate CI jobs (but not too many CI job)
 val instrumentationProjectMuzzle = listOf(
   tasks.register("muzzle1"),
@@ -13,6 +13,8 @@ val instrumentationProjectMuzzle = listOf(
   tasks.register("muzzle4"),
   tasks.register("muzzle5"),
   tasks.register("muzzle6"),
+  tasks.register("muzzle7"),
+  tasks.register("muzzle8"),
 )
 
 var counter = 0
@@ -35,6 +37,6 @@ subprojects {
     // relying on predictable ordering of subprojects
     // (see https://docs.gradle.org/current/dsl/org.gradle.api.Project.html#N14CB4)
     // since we are splitting these muzzleX tasks across different github action jobs
-    instrumentationProjectMuzzle[counter++ % 6].get().dependsOn(subProj.tasks.named("muzzle"))
+    instrumentationProjectMuzzle[counter++ % 8].get().dependsOn(subProj.tasks.named("muzzle"))
   }
 }