Skip to content

Commit 6ff9ee6

Browse files
committed
use list
1 parent 8ecaa83 commit 6ff9ee6

File tree

2 files changed

+7
-8
lines changed

2 files changed

+7
-8
lines changed

instrumentation/jdbc/library/src/main/java/io/opentelemetry/instrumentation/jdbc/internal/JdbcData.java

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,9 @@
1111
import java.sql.Connection;
1212
import java.sql.PreparedStatement;
1313
import java.sql.Statement;
14+
import java.util.ArrayList;
1415
import java.util.Collection;
15-
import java.util.LinkedHashSet;
16+
import java.util.List;
1617
import java.util.Map;
1718
import java.util.WeakHashMap;
1819

@@ -99,20 +100,18 @@ public static Long getPreparedStatementBatchSize(PreparedStatement statement) {
99100
* any time.
100101
*/
101102
public static final class StatementBatchInfo {
102-
private final Collection<String> statements = new LinkedHashSet<>();
103-
private long batchSize;
103+
private final List<String> statements = new ArrayList<>();
104104

105105
void add(String sql) {
106106
statements.add(sql);
107-
batchSize++;
108107
}
109108

110109
public Collection<String> getStatements() {
111110
return statements;
112111
}
113112

114113
public long getBatchSize() {
115-
return batchSize;
114+
return statements.size();
116115
}
117116
}
118117

instrumentation/jdbc/library/src/main/java/io/opentelemetry/instrumentation/jdbc/internal/OpenTelemetryStatement.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,8 @@
2929
import java.sql.SQLException;
3030
import java.sql.SQLWarning;
3131
import java.sql.Statement;
32-
import java.util.Collection;
33-
import java.util.LinkedHashSet;
32+
import java.util.ArrayList;
33+
import java.util.List;
3434

3535
/**
3636
* This class is internal and is hence not for public use. Its APIs are unstable and can change at
@@ -44,7 +44,7 @@ public class OpenTelemetryStatement<S extends Statement> implements Statement {
4444
protected final String query;
4545
protected final Instrumenter<DbRequest, Void> instrumenter;
4646

47-
private final Collection<String> batchCommands = new LinkedHashSet<>();
47+
private final List<String> batchCommands = new ArrayList<>();
4848
protected long batchSize;
4949

5050
OpenTelemetryStatement(

0 commit comments

Comments
 (0)