Remove todo assignment (#12884)

Author: jaydeluca

buildscripts/checkstyle.xml

@@ -405,7 +405,7 @@
   <!-- skip jflex generated files -->
   <module name="SuppressionSingleFilter">
     <property name="checks" value=".*"/>
-    <!-- TODO(anuraaga): Fix path after https://github.com/jprante/gradle-plugin-jflex/issues/20 -->
+    <!-- TODO: Fix path after https://github.com/jprante/gradle-plugin-jflex/issues/20 -->
     <property name="files"
       value="instrumentation-api[/\\]build[/\\]generated[/\\]sources[/\\]main"/>
   </module>

conventions/src/main/kotlin/io.opentelemetry.instrumentation.javaagent-testing.gradle.kts

@@ -104,8 +104,8 @@ afterEvaluate {
     val agentShadowJar = agentForTesting.resolve().first()
 
     dependsOn(shadowJar)
-    // TODO(anuraaga): Figure out why dependsOn override is still needed in otel.javaagent-testing
-    // despite this dependency.
+    // TODO: Figure out why dependsOn override is still needed in otel.javaagent-testing despite
+    // this dependency.
     dependsOn(agentForTesting.buildDependencies)
 
     jvmArgumentProviders.add(JavaagentTestArgumentsProvider(agentShadowJar, shadowJar.archiveFile.get().asFile))
@@ -119,8 +119,8 @@ afterEvaluate {
         return@filter false
       }
 
-      // TODO(anuraaga): Better not to have this naming constraint, we can likely use
-      // plugin identification instead.
+      // TODO: Better not to have this naming constraint, we can likely use plugin identification
+      // instead.
 
       val lib = it.absoluteFile
       if (lib.name.startsWith("opentelemetry-javaagent-")) {

conventions/src/main/kotlin/otel.errorprone-conventions.gradle.kts

@@ -90,7 +90,7 @@ tasks {
         disable("TypeParameterNaming")
 
         // In bytecode instrumentation it's very common to separate across onEnter / onExit
-        // TODO(anuraaga): Only disable for javaagent instrumentation modules.
+        // TODO: Only disable for javaagent instrumentation modules.
         disable("MustBeClosedChecker")
 
         // Common to avoid an allocation. Revisit if it's worth opt-in suppressing instead of
@@ -101,16 +101,15 @@ tasks {
         disable("JdkObsolete")
         disable("JavaUtilDate")
 
-        // TODO(anuraaga): Remove this, we use this pattern in several tests and it will mean
-        // some moving.
+        // TODO: Remove this, we use this pattern in several tests and it will mean some moving.
         disable("DefaultPackage")
 
         // we use modified Otel* checks which ignore *Advice classes
         disable("PrivateConstructorForUtilityClass")
         disable("CanIgnoreReturnValueSuggester")
 
-        // TODO(anuraaga): Remove this, probably after instrumenter API migration instead of dealing
-        // with older APIs.
+        // TODO: Remove this, probably after instrumenter API migration instead of dealing with
+        // older APIs.
         disable("InconsistentOverloads")
 
         // lots of low level APIs use arrays

conventions/src/main/kotlin/otel.java-conventions.gradle.kts

@@ -342,7 +342,7 @@ tasks.withType<Test>().configureEach {
   // There's no real harm in setting this for all tests even if any happen to not be using context
   // propagation.
   jvmArgs("-Dio.opentelemetry.context.enableStrictContext=${rootProject.findProperty("enableStrictContext") ?: true}")
-  // TODO(anuraaga): Have agent map unshaded to shaded.
+  // TODO: Have agent map unshaded to shaded.
   if (project.findProperty("disableShadowRelocate") != "true") {
     jvmArgs("-Dio.opentelemetry.javaagent.shaded.io.opentelemetry.context.enableStrictContext=${rootProject.findProperty("enableStrictContext") ?: true}")
   } else {

examples/distro/smoke-tests/src/test/java/com/example/javaagent/smoketest/SmokeTest.java

@@ -158,8 +158,7 @@ protected Collection<ExportTraceServiceRequest> waitForTraces()
         .map(
             it -> {
               ExportTraceServiceRequest.Builder builder = ExportTraceServiceRequest.newBuilder();
-              // TODO(anuraaga): Register parser into object mapper to avoid de -> re ->
-              // deserialize.
+              // TODO: Register parser into object mapper to avoid de -> re -> deserialize.
               try {
                 JsonFormat.parser().merge(OBJECT_MAPPER.writeValueAsString(it), builder);
               } catch (InvalidProtocolBufferException | JsonProcessingException e) {

instrumentation/armeria/armeria-1.3/testing/src/main/java/io/opentelemetry/instrumentation/armeria/v1_3/AbstractArmeriaHttpServerTest.java

@@ -180,8 +180,8 @@ protected void configure(HttpServerTestOptions options) {
     options.setExpectedHttpRoute(
         (endpoint, method) -> {
           if (endpoint == ServerEndpoint.NOT_FOUND) {
-            // TODO(anuraaga): Revisit this when applying instrumenters to more libraries, Armeria
-            // currently reports '/*' which is a fallback route.
+            // TODO: Revisit this when applying instrumenters to more libraries, Armeria currently
+            // reports '/*' which is a fallback route.
             return "/*";
           }
           return expectedHttpRoute(endpoint, method);

instrumentation/aws-lambda/aws-lambda-core-1.0/library/src/main/java/io/opentelemetry/instrumentation/awslambdacore/v1_0/internal/ApiGatewayProxyRequest.java

@@ -25,8 +25,8 @@ public abstract class ApiGatewayProxyRequest {
 
   private static final Logger logger = Logger.getLogger(ApiGatewayProxyRequest.class.getName());
 
-  // TODO(anuraaga): We should create a RequestFactory type of class instead of evaluating this
-  // for every request.
+  // TODO: We should create a RequestFactory type of class instead of evaluating this for every
+  // request.
   private static boolean noHttpPropagationNeeded() {
     Collection<String> fields =
         GlobalOpenTelemetry.getPropagators().getTextMapPropagator().fields();

instrumentation/aws-lambda/aws-lambda-events-2.2/library/build.gradle.kts

@@ -28,7 +28,7 @@ dependencies {
   // We need Jackson for wrappers to reproduce the serialization does when Lambda invokes a RequestHandler with event
   // since Lambda will only be able to invoke the wrapper itself with a generic Object.
   // Note that Lambda itself uses Jackson, but does not expose it to the function so we need to include it here.
-  // TODO(anuraaga): Switch to aws-lambda-java-serialization to more robustly follow Lambda's serialization logic.
+  // TODO: Switch to aws-lambda-java-serialization to more robustly follow Lambda's serialization logic.
   implementation("com.fasterxml.jackson.core:jackson-databind")
   implementation("io.opentelemetry.contrib:opentelemetry-aws-xray-propagator")
 

instrumentation/aws-sdk/aws-sdk-2.2/testing/src/main/groovy/io/opentelemetry/instrumentation/awssdk/v2_2/AbstractAws2ClientTest.groovy

@@ -408,7 +408,7 @@ abstract class AbstractAws2ClientTest extends AbstractAws2ClientCoreTest {
       """
   }
 
-  // TODO(anuraaga): Without AOP instrumentation of the HTTP client, we cannot model retries as
+  // TODO: Without AOP instrumentation of the HTTP client, we cannot model retries as
   // spans because of https://github.com/aws/aws-sdk-java-v2/issues/1741. We should at least tweak
   // the instrumentation to add Events for retries instead.
   def "timeout and retry errors not captured"() {

instrumentation/finatra-2.9/javaagent/build.gradle.kts

@@ -28,8 +28,7 @@ val finatraLatest by configurations.creating {
 }
 
 dependencies {
-  // TODO(anuraaga): Something about library configuration doesn't work well with scala compilation
-  // here.
+  // TODO: Something about library configuration doesn't work well with scala compilation here.
   compileOnly("com.twitter:finatra-http_2.11:2.9.0")
 
   testInstrumentation(project(":instrumentation:netty:netty-4.1:javaagent"))