Skip to content

Commit 7292bf5

Browse files
committed
Fix: Incorrect SNS Auto-Inst Unit Test Parameters in AWS SDK v2
We want to run the SNS unit test twice, each time with a different parameter: once with TopicArn, and once with TargetArn. However, the second argument was mistakenly nested as a sub-parameter of the first due to misaligned parentheses. As a result, the unit test only runs once—with TopicArn—and never runs with TargetArn. Tests Run: ./gradlew spotlessCheck ./gradlew clean assemble ./gradlew instrumentation:check ./gradlew :smoke-tests:test No regression issues found. Backward Compatibility: There is no risk of breaking existing functionality. This change only fixes one unit test without modifying the existing behavior of the auto-instrumentation library.
1 parent 8af76e8 commit 7292bf5

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

instrumentation/aws-sdk/aws-sdk-2.2/testing/src/main/java/io/opentelemetry/instrumentation/awssdk/v2_2/AbstractAws2ClientTest.java

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -476,15 +476,15 @@ private static Stream<Arguments> provideSnsArguments() {
476476
PublishRequest.builder()
477477
.message("somemessage")
478478
.topicArn("somearn")
479-
.build()),
480-
Arguments.of(
481-
(Function<SnsClient, Object>)
482-
c ->
483-
c.publish(
484-
PublishRequest.builder()
485-
.message("somemessage")
486-
.targetArn("somearn")
487-
.build()))));
479+
.build())),
480+
Arguments.of(
481+
(Function<SnsClient, Object>)
482+
c ->
483+
c.publish(
484+
PublishRequest.builder()
485+
.message("somemessage")
486+
.targetArn("somearn")
487+
.build())));
488488
}
489489

490490
@ParameterizedTest

0 commit comments

Comments
 (0)