jedis-4.0

Author: SylvainJuge

instrumentation/jedis/jedis-4.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/jedis/v4_0/JedisConnectionInstrumentation.java

@@ -20,6 +20,7 @@
 import io.opentelemetry.javaagent.extension.instrumentation.TypeTransformer;
 import io.opentelemetry.javaagent.instrumentation.jedis.JedisRequestContext;
 import java.net.Socket;
+import javax.annotation.Nullable;
 import net.bytebuddy.asm.Advice;
 import net.bytebuddy.description.type.TypeDescription;
 import net.bytebuddy.matcher.ElementMatcher;
@@ -50,78 +51,72 @@ public void transform(TypeTransformer transformer) {
         this.getClass().getName() + "$SendCommandAdvice");
   }
 
-  @SuppressWarnings("unused")
-  public static class SendCommandAdvice {
+  public static class AdviceScope {
+    private final Context context;
+    private final Scope scope;
+    private final JedisRequest request;
 
-    @Advice.OnMethodEnter(suppress = Throwable.class)
-    public static void onEnter(
-        @Advice.Argument(0) ProtocolCommand command,
-        @Advice.Argument(1) byte[][] args,
-        @Advice.Local("otelJedisRequest") JedisRequest request,
-        @Advice.Local("otelContext") Context context,
-        @Advice.Local("otelScope") Scope scope) {
+    private AdviceScope(Context context, Scope scope, JedisRequest request) {
+      this.context = context;
+      this.scope = scope;
+      this.request = request;
+    }
+
+    @Nullable
+    public static AdviceScope start(JedisRequest request) {
       Context parentContext = currentContext();
-      request = JedisRequest.create(command, asList(args));
       if (!instrumenter().shouldStart(parentContext, request)) {
-        return;
+        return null;
       }
+      Context context = instrumenter().start(parentContext, request);
+      return new AdviceScope(context, context.makeCurrent(), request);
+    }
+
+    public void end(Socket socket, @Nullable Throwable throwable) {
+      request.setSocket(socket);
+      scope.close();
+      JedisRequestContext.endIfNotAttached(instrumenter(), context, request, throwable);
+    }
+  }
+
+  @SuppressWarnings("unused")
+  public static class SendCommandAdvice {
 
-      context = instrumenter().start(parentContext, request);
-      scope = context.makeCurrent();
+    @Nullable
+    @Advice.OnMethodEnter(suppress = Throwable.class)
+    public static AdviceScope onEnter(
+        @Advice.Argument(0) ProtocolCommand command, @Advice.Argument(1) byte[][] args) {
+      return AdviceScope.start(JedisRequest.create(command, asList(args)));
     }
 
     @Advice.OnMethodExit(onThrowable = Throwable.class, suppress = Throwable.class)
     public static void stopSpan(
         @Advice.FieldValue("socket") Socket socket,
-        @Advice.Thrown Throwable throwable,
-        @Advice.Local("otelJedisRequest") JedisRequest request,
-        @Advice.Local("otelContext") Context context,
-        @Advice.Local("otelScope") Scope scope) {
-      if (scope == null) {
-        return;
+        @Advice.Thrown @Nullable Throwable throwable,
+        @Advice.Enter @Nullable AdviceScope adviceScope) {
+      if (adviceScope != null) {
+        adviceScope.end(socket, throwable);
       }
-
-      request.setSocket(socket);
-
-      scope.close();
-      JedisRequestContext.endIfNotAttached(instrumenter(), context, request, throwable);
     }
   }
 
   @SuppressWarnings("unused")
   public static class SendCommand2Advice {
 
+    @Nullable
     @Advice.OnMethodEnter(suppress = Throwable.class)
-    public static void onEnter(
-        @Advice.Argument(0) CommandArguments command,
-        @Advice.Local("otelJedisRequest") JedisRequest request,
-        @Advice.Local("otelContext") Context context,
-        @Advice.Local("otelScope") Scope scope) {
-      Context parentContext = currentContext();
-      request = JedisRequest.create(command);
-      if (!instrumenter().shouldStart(parentContext, request)) {
-        return;
-      }
-
-      context = instrumenter().start(parentContext, request);
-      scope = context.makeCurrent();
+    public static AdviceScope onEnter(@Advice.Argument(0) CommandArguments command) {
+      return AdviceScope.start(JedisRequest.create(command));
     }
 
     @Advice.OnMethodExit(onThrowable = Throwable.class, suppress = Throwable.class)
     public static void stopSpan(
         @Advice.FieldValue("socket") Socket socket,
-        @Advice.Thrown Throwable throwable,
-        @Advice.Local("otelJedisRequest") JedisRequest request,
-        @Advice.Local("otelContext") Context context,
-        @Advice.Local("otelScope") Scope scope) {
-      if (scope == null) {
-        return;
+        @Advice.Thrown @Nullable Throwable throwable,
+        @Advice.Enter @Nullable AdviceScope adviceScope) {
+      if (adviceScope != null) {
+        adviceScope.end(socket, throwable);
       }
-
-      request.setSocket(socket);
-
-      scope.close();
-      JedisRequestContext.endIfNotAttached(instrumenter(), context, request, throwable);
     }
   }
 }