Skip to content

Commit 7507e95

Browse files
committed
fix
1 parent 2220fb7 commit 7507e95

File tree

1 file changed

+4
-8
lines changed

1 file changed

+4
-8
lines changed

smoke-tests/src/test/java/io/opentelemetry/smoketest/appserver/AppServerTest.java

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -97,12 +97,12 @@ private void assertFullTrace(String path, String responseBody) {
9797
assertSpan(span)
9898
.hasName("GET")
9999
.hasKind(SpanKind.CLIENT)
100-
.hasAttribute(ClientAttributes.CLIENT_ADDRESS, "127.0.0.1")
101100
.hasAttribute(
102101
AttributeKey.stringArrayKey("http.request.header.x-test-request"),
103102
List.of("test")),
104103
span ->
105104
assertServerSpan(span, "/app/headers")
105+
.hasAttribute(ClientAttributes.CLIENT_ADDRESS, "127.0.0.1")
106106
.hasAttribute(UrlAttributes.URL_FULL, "http://localhost:8080" + path)));
107107

108108
// trace id is present in the HTTP headers as reported by the called endpoint
@@ -136,7 +136,7 @@ void testStaticFileNotFound() {
136136
trace ->
137137
trace.hasSpansSatisfyingExactly(
138138
span -> assertServerSpan(span, path),
139-
span -> span.hasName("Response.sendError").hasKind(SpanKind.INTERNAL)));
139+
span -> span.hasName("HttpServletResponseWrapper.sendError").hasKind(SpanKind.INTERNAL)));
140140
}
141141

142142
@Test
@@ -150,8 +150,7 @@ void testRequestForWebInfWebXml() {
150150
.waitAndAssertTraces(
151151
trace ->
152152
trace.hasSpansSatisfyingExactly(
153-
span -> assertServerSpan(span, path),
154-
span -> span.hasName("Response.sendError").hasKind(SpanKind.INTERNAL)));
153+
span -> assertServerSpan(span, path)));
155154
}
156155

157156
@Test
@@ -187,10 +186,7 @@ void testRequestOutsideDeployedApplication() {
187186
.waitAndAssertTraces(
188187
trace ->
189188
trace.hasSpansSatisfyingExactly(
190-
span -> assertServerSpan(span, path),
191-
span ->
192-
span.hasName("HttpServletResponseWrapper.sendError")
193-
.hasKind(SpanKind.INTERNAL)));
189+
span -> assertServerSpan(span, path)));
194190
}
195191

196192
@Test

0 commit comments

Comments
 (0)