Skip to content

Commit 7536867

Browse files
jaydelucalaurit
andauthored
Disable container support in opensearch test containers (#15022)
Co-authored-by: Lauri Tulmin <[email protected]>
1 parent f31f574 commit 7536867

File tree

7 files changed

+29
-10
lines changed
  • instrumentation

7 files changed

+29
-10
lines changed

instrumentation/elasticsearch/elasticsearch-api-client-7.16/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/elasticsearch/apiclient/ElasticsearchClientTest.java

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,10 +40,15 @@
4040
import org.junit.jupiter.api.BeforeAll;
4141
import org.junit.jupiter.api.Test;
4242
import org.junit.jupiter.api.extension.RegisterExtension;
43+
import org.slf4j.Logger;
44+
import org.slf4j.LoggerFactory;
45+
import org.testcontainers.containers.output.Slf4jLogConsumer;
4346
import org.testcontainers.elasticsearch.ElasticsearchContainer;
4447

4548
@SuppressWarnings("deprecation") // using deprecated semconv
4649
class ElasticsearchClientTest {
50+
private static final Logger logger = LoggerFactory.getLogger(ElasticsearchClientTest.class);
51+
4752
@RegisterExtension
4853
static final InstrumentationExtension testing = AgentInstrumentationExtension.create();
4954

@@ -57,9 +62,10 @@ class ElasticsearchClientTest {
5762
@BeforeAll
5863
static void setUp() {
5964
elasticsearch =
60-
new ElasticsearchContainer("docker.elastic.co/elasticsearch/elasticsearch:7.17.2");
65+
new ElasticsearchContainer("docker.elastic.co/elasticsearch/elasticsearch:7.17.28");
6166
// limit memory usage
6267
elasticsearch.withEnv("ES_JAVA_OPTS", "-Xmx256m -Xms256m");
68+
elasticsearch.withLogConsumer(new Slf4jLogConsumer(logger));
6369
elasticsearch.start();
6470

6571
httpHost = HttpHost.create(elasticsearch.getHttpHostAddress());
@@ -87,7 +93,7 @@ static void cleanUp() {
8793
@Test
8894
void elasticsearchStatus() throws IOException {
8995
InfoResponse response = client.info();
90-
assertThat(response.version().number()).isEqualTo("7.17.2");
96+
assertThat(response.version().number()).isEqualTo("7.17.28");
9197

9298
testing.waitAndAssertTraces(
9399
trace ->
@@ -188,7 +194,7 @@ void elasticsearchStatusAsync() throws Exception {
188194
//noinspection ResultOfMethodCallIgnored
189195
countDownLatch.await(10, TimeUnit.SECONDS);
190196

191-
assertThat(request.getResponse().version().number()).isEqualTo("7.17.2");
197+
assertThat(request.getResponse().version().number()).isEqualTo("7.17.28");
192198

193199
testing.waitAndAssertTraces(
194200
trace ->

instrumentation/elasticsearch/elasticsearch-rest-5.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/elasticsearch/rest/v5_0/ElasticsearchRest5Test.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,9 @@ static void setup() {
6161
new ElasticsearchContainer("docker.elastic.co/elasticsearch/elasticsearch-oss:6.8.16");
6262
}
6363
// limit memory usage
64-
elasticsearch.withEnv("ES_JAVA_OPTS", "-Xmx256m -Xms256m");
64+
elasticsearch.withEnv(
65+
"ES_JAVA_OPTS",
66+
"-Xmx256m -Xms256m -Dlog4j2.disableJmx=true -Dlog4j2.disable.jmx=true -XX:-UseContainerSupport");
6567
elasticsearch.start();
6668

6769
httpHost = HttpHost.create(elasticsearch.getHttpHostAddress());

instrumentation/elasticsearch/elasticsearch-rest-6.4/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/elasticsearch/rest/v6_4/ElasticsearchRest6Test.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,9 @@ static void setUp() {
5252
elasticsearch =
5353
new ElasticsearchContainer("docker.elastic.co/elasticsearch/elasticsearch-oss:6.8.16");
5454
// limit memory usage
55-
elasticsearch.withEnv("ES_JAVA_OPTS", "-Xmx256m -Xms256m");
55+
elasticsearch.withEnv(
56+
"ES_JAVA_OPTS",
57+
"-Xmx256m -Xms256m -Dlog4j2.disableJmx=true -Dlog4j2.disable.jmx=true -XX:-UseContainerSupport");
5658
elasticsearch.start();
5759

5860
httpHost = HttpHost.create(elasticsearch.getHttpHostAddress());

instrumentation/elasticsearch/elasticsearch-rest-7.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/elasticsearch/rest/v7_0/ElasticsearchRest7Test.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,9 @@ static void setUp() {
5555
elasticsearch =
5656
new ElasticsearchContainer("docker.elastic.co/elasticsearch/elasticsearch-oss:7.10.2");
5757
// limit memory usage
58-
elasticsearch.withEnv("ES_JAVA_OPTS", "-Xmx256m -Xms256m");
58+
elasticsearch.withEnv(
59+
"ES_JAVA_OPTS",
60+
"-Xmx256m -Xms256m -Dlog4j2.disableJmx=true -Dlog4j2.disable.jmx=true -XX:-UseContainerSupport");
5961
elasticsearch.start();
6062

6163
httpHost = HttpHost.create(elasticsearch.getHttpHostAddress());

instrumentation/elasticsearch/elasticsearch-rest-7.0/library/src/test/java/io/opentelemetry/instrumentation/elasticsearch/rest/v7_0/ElasticsearchRest7Test.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,9 @@ static void setUp() {
5151
elasticsearch =
5252
new ElasticsearchContainer("docker.elastic.co/elasticsearch/elasticsearch-oss:7.10.2");
5353
// limit memory usage
54-
elasticsearch.withEnv("ES_JAVA_OPTS", "-Xmx256m -Xms256m");
54+
elasticsearch.withEnv(
55+
"ES_JAVA_OPTS",
56+
"-Xmx256m -Xms256m -Dlog4j2.disableJmx=true -Dlog4j2.disable.jmx=true -XX:-UseContainerSupport");
5557
elasticsearch.start();
5658

5759
httpHost = HttpHost.create(elasticsearch.getHttpHostAddress());

instrumentation/opensearch/opensearch-java-3.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/opensearch/v3_0/AbstractOpenSearchTest.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,10 @@ void setUp() throws Exception {
6464
opensearch =
6565
new OpensearchContainer(DockerImageName.parse("opensearchproject/opensearch:1.3.6"))
6666
.withSecurityEnabled();
67-
opensearch.withEnv("OPENSEARCH_JAVA_OPTS", "-Xmx256m -Xms256m");
67+
// limit memory usage and disable Log4j JMX to avoid cgroup detection issues in containers
68+
opensearch.withEnv(
69+
"OPENSEARCH_JAVA_OPTS",
70+
"-Xmx256m -Xms256m -Dlog4j2.disableJmx=true -Dlog4j2.disable.jmx=true -XX:-UseContainerSupport");
6871
opensearch.start();
6972
httpHost = URI.create(opensearch.getHttpHostAddress());
7073
openSearchClient = buildOpenSearchClient();

instrumentation/opensearch/opensearch-rest-common/testing/src/main/java/io/opentelemetry/javaagent/instrumentation/opensearch/rest/AbstractOpenSearchRestTest.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,10 @@ void setUp() throws Exception {
5959
opensearch =
6060
new OpensearchContainer(DockerImageName.parse("opensearchproject/opensearch:1.3.6"))
6161
.withSecurityEnabled();
62-
// limit memory usage
63-
opensearch.withEnv("OPENSEARCH_JAVA_OPTS", "-Xmx256m -Xms256m");
62+
// limit memory usage and disable Log4j JMX to avoid cgroup detection issues in containers
63+
opensearch.withEnv(
64+
"OPENSEARCH_JAVA_OPTS",
65+
"-Xmx256m -Xms256m -Dlog4j2.disableJmx=true -Dlog4j2.disable.jmx=true -XX:-UseContainerSupport");
6466
opensearch.start();
6567
httpHost = URI.create(opensearch.getHttpHostAddress());
6668

0 commit comments

Comments
 (0)