Skip to content

Commit 75387d5

Browse files
authored
Move spring-web-3.1 tests from separate :testing module to :javaagent (#15023)
1 parent 5eb8527 commit 75387d5

File tree

4 files changed

+7
-13
lines changed

4 files changed

+7
-13
lines changed

instrumentation/spring/spring-web/spring-web-3.1/javaagent/build.gradle.kts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,5 +14,9 @@ muzzle {
1414
}
1515

1616
dependencies {
17-
compileOnly("org.springframework:spring-web:3.1.0.RELEASE")
17+
library("org.springframework:spring-web:3.1.0.RELEASE")
18+
19+
testInstrumentation(project(":instrumentation:http-url-connection:javaagent"))
20+
21+
latestDepTestLibrary("org.springframework:spring-web:5.+") // see spring-web-6.0 module
1822
}

instrumentation/spring/spring-web/spring-web-3.1/testing/src/test/java/io/opentelemetry/javaagent/instrumentation/spring/web/SpringRestTemplateTest.java renamed to instrumentation/spring/spring-web/spring-web-3.1/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/springweb/v3_1/SpringRestTemplateTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
* SPDX-License-Identifier: Apache-2.0
44
*/
55

6-
package io.opentelemetry.javaagent.instrumentation.spring.web;
6+
package io.opentelemetry.javaagent.instrumentation.springweb.v3_1;
77

88
import static java.util.Collections.singletonList;
99

@@ -23,7 +23,7 @@
2323
import org.springframework.web.client.ResourceAccessException;
2424
import org.springframework.web.client.RestTemplate;
2525

26-
public class SpringRestTemplateTest extends AbstractHttpClientTest<HttpEntity<String>> {
26+
class SpringRestTemplateTest extends AbstractHttpClientTest<HttpEntity<String>> {
2727

2828
@RegisterExtension
2929
static final InstrumentationExtension testing = HttpClientInstrumentationExtension.forAgent();

instrumentation/spring/spring-web/spring-web-3.1/testing/build.gradle.kts

Lines changed: 0 additions & 9 deletions
This file was deleted.

settings.gradle.kts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -593,7 +593,6 @@ include(":instrumentation:spring:spring-security-config-6.0:javaagent")
593593
include(":instrumentation:spring:spring-security-config-6.0:library")
594594
include(":instrumentation:spring:spring-web:spring-web-3.1:javaagent")
595595
include(":instrumentation:spring:spring-web:spring-web-3.1:library")
596-
include(":instrumentation:spring:spring-web:spring-web-3.1:testing")
597596
include(":instrumentation:spring:spring-web:spring-web-6.0:javaagent")
598597
include(":instrumentation:spring:spring-webflux:spring-webflux-5.0:javaagent")
599598
include(":instrumentation:spring:spring-webflux:spring-webflux-5.0:testing")

0 commit comments

Comments
 (0)