add attributes to scan metrics

Author: ghareeb-falazi

instrumentation/iceberg-1.8/library/src/main/java/io/opentelemetry/instrumentation/iceberg/v1_8/IcebergMetricsReporter.java

@@ -6,6 +6,8 @@
 package io.opentelemetry.instrumentation.iceberg.v1_8;
 
 import io.opentelemetry.api.OpenTelemetry;
+import io.opentelemetry.api.common.AttributeKey;
+import io.opentelemetry.api.common.Attributes;
 import io.opentelemetry.api.metrics.LongCounter;
 import io.opentelemetry.api.metrics.LongGauge;
 import org.apache.iceberg.metrics.CommitReport;
@@ -18,6 +20,10 @@
 
 public class IcebergMetricsReporter implements MetricsReporter {
   private static final String INSTRUMENTATION_NAME = "io.opentelemetry.iceberg_1.8";
+  private static final AttributeKey<Long> SCHEMA_ID = AttributeKey.longKey("iceberg.schema.id");
+  private static final AttributeKey<String> TABLE_NAME =
+      AttributeKey.stringKey("iceberg.table.name");
+  private static final AttributeKey<Long> SNAPHSOT_ID = AttributeKey.longKey("iceberg.snapshot.id");
 
   private final OpenTelemetry openTelemetry;
 
@@ -35,29 +41,37 @@ public void report(MetricsReport report) {
   }
 
   void reportScanMetrics(ScanReport scanReport) {
+    Attributes scanAttributes =
+        Attributes.of(
+            SCHEMA_ID,
+            Long.valueOf(scanReport.schemaId()),
+            TABLE_NAME,
+            scanReport.tableName(),
+            SNAPHSOT_ID,
+            scanReport.snapshotId());
     ScanMetricsResult metrics = scanReport.scanMetrics();
     TimerResult duration = metrics.totalPlanningDuration();
 
     if (duration != null) {
       LongGauge metric =
           ScanMetricsBuilder.totalPlanningDuration(openTelemetry.getMeter(INSTRUMENTATION_NAME));
-      metric.set(duration.totalDuration().toMillis());
+      metric.set(duration.totalDuration().toMillis(), scanAttributes);
     }
 
     CounterResult current = metrics.resultDataFiles();
 
     if (current != null) {
       LongCounter metric =
           ScanMetricsBuilder.scannedDataFilesCount(openTelemetry.getMeter(INSTRUMENTATION_NAME));
-      metric.add(current.value());
+      metric.add(current.value(), scanAttributes);
     }
 
     current = metrics.resultDeleteFiles();
 
     if (current != null) {
       LongCounter metric =
           ScanMetricsBuilder.scannedDeleteFilesCount(openTelemetry.getMeter(INSTRUMENTATION_NAME));
-      metric.add(current.value());
+      metric.add(current.value(), scanAttributes);
     }
 
     current = metrics.scannedDataManifests();
@@ -66,7 +80,7 @@ void reportScanMetrics(ScanReport scanReport) {
       LongCounter metric =
           ScanMetricsBuilder.scannedDataManifestsCount(
               openTelemetry.getMeter(INSTRUMENTATION_NAME));
-      metric.add(current.value());
+      metric.add(current.value(), scanAttributes);
     }
 
     current = metrics.scannedDeleteManifests();
@@ -75,15 +89,15 @@ void reportScanMetrics(ScanReport scanReport) {
       LongCounter metric =
           ScanMetricsBuilder.scannedDeleteManifestsCount(
               openTelemetry.getMeter(INSTRUMENTATION_NAME));
-      metric.add(current.value());
+      metric.add(current.value(), scanAttributes);
     }
 
     current = metrics.totalDataManifests();
 
     if (current != null) {
       LongCounter metric =
           ScanMetricsBuilder.totalDataManifestsCount(openTelemetry.getMeter(INSTRUMENTATION_NAME));
-      metric.add(current.value());
+      metric.add(current.value(), scanAttributes);
     }
 
     current = metrics.totalDeleteManifests();
@@ -92,23 +106,23 @@ void reportScanMetrics(ScanReport scanReport) {
       LongCounter metric =
           ScanMetricsBuilder.totalDeleteManifestsCount(
               openTelemetry.getMeter(INSTRUMENTATION_NAME));
-      metric.add(current.value());
+      metric.add(current.value(), scanAttributes);
     }
 
     current = metrics.totalFileSizeInBytes();
 
     if (current != null) {
       LongCounter metric =
           ScanMetricsBuilder.scannedDataFilesSize(openTelemetry.getMeter(INSTRUMENTATION_NAME));
-      metric.add(current.value());
+      metric.add(current.value(), scanAttributes);
     }
 
     current = metrics.totalDeleteFileSizeInBytes();
 
     if (current != null) {
       LongCounter metric =
           ScanMetricsBuilder.scannedDeleteFilesSize(openTelemetry.getMeter(INSTRUMENTATION_NAME));
-      metric.add(current.value());
+      metric.add(current.value(), scanAttributes);
     }
 
     current = metrics.skippedDataManifests();
@@ -117,7 +131,7 @@ void reportScanMetrics(ScanReport scanReport) {
       LongCounter metric =
           ScanMetricsBuilder.skippedDataManifestsCount(
               openTelemetry.getMeter(INSTRUMENTATION_NAME));
-      metric.add(current.value());
+      metric.add(current.value(), scanAttributes);
     }
 
     current = metrics.skippedDeleteManifests();
@@ -126,55 +140,55 @@ void reportScanMetrics(ScanReport scanReport) {
       LongCounter metric =
           ScanMetricsBuilder.skippedDeleteManifestsCount(
               openTelemetry.getMeter(INSTRUMENTATION_NAME));
-      metric.add(current.value());
+      metric.add(current.value(), scanAttributes);
     }
 
     current = metrics.skippedDataFiles();
 
     if (current != null) {
       LongCounter metric =
           ScanMetricsBuilder.skippedDataFilesCount(openTelemetry.getMeter(INSTRUMENTATION_NAME));
-      metric.add(current.value());
+      metric.add(current.value(), scanAttributes);
     }
 
     current = metrics.skippedDeleteFiles();
 
     if (current != null) {
       LongCounter metric =
           ScanMetricsBuilder.skippedDeleteFilesCount(openTelemetry.getMeter(INSTRUMENTATION_NAME));
-      metric.add(current.value());
+      metric.add(current.value(), scanAttributes);
     }
 
     current = metrics.indexedDeleteFiles();
 
     if (current != null) {
       LongCounter metric =
           ScanMetricsBuilder.indexedDeleteFilesCount(openTelemetry.getMeter(INSTRUMENTATION_NAME));
-      metric.add(current.value());
+      metric.add(current.value(), scanAttributes);
     }
 
     current = metrics.equalityDeleteFiles();
 
     if (current != null) {
       LongCounter metric =
           ScanMetricsBuilder.equalityDeleteFilesCount(openTelemetry.getMeter(INSTRUMENTATION_NAME));
-      metric.add(current.value());
+      metric.add(current.value(), scanAttributes);
     }
 
     current = metrics.positionalDeleteFiles();
 
     if (current != null) {
       LongCounter metric =
           ScanMetricsBuilder.positionDeleteFilesCount(openTelemetry.getMeter(INSTRUMENTATION_NAME));
-      metric.add(current.value());
+      metric.add(current.value(), scanAttributes);
     }
 
     current = metrics.dvs();
 
     if (current != null) {
       LongCounter metric =
           ScanMetricsBuilder.deletionVectorFilesCount(openTelemetry.getMeter(INSTRUMENTATION_NAME));
-      metric.add(current.value());
+      metric.add(current.value(), scanAttributes);
     }
   }