rename environment var

Author: jaydeluca

instrumentation/spring/spring-boot-autoconfigure/src/main/java/io/opentelemetry/instrumentation/spring/autoconfigure/internal/properties/SpringConfigProperties.java

@@ -25,7 +25,7 @@
  * any time.
  */
 public class SpringConfigProperties implements ConfigProperties {
-  private final CachedPropertyResolver cachedEnvironment;
+  private final CachedPropertyResolver environment;
 
   private final ExpressionParser parser;
   private final OtlpExporterProperties otlpExporterProperties;
@@ -44,7 +44,7 @@ public SpringConfigProperties(
       OtelResourceProperties resourceProperties,
       OtelSpringProperties otelSpringProperties,
       ConfigProperties otelSdkProperties) {
-    this.cachedEnvironment = new CachedPropertyResolver(environment);
+    this.environment = new CachedPropertyResolver(environment);
     this.parser = parser;
     this.otlpExporterProperties = otlpExporterProperties;
     this.resourceProperties = resourceProperties;
@@ -152,7 +152,7 @@ public static ConfigProperties create(
   @Override
   public String getString(String name) {
     String normalizedName = ConfigUtil.normalizeEnvironmentVariableKey(name);
-    String value = cachedEnvironment.getProperty(normalizedName, String.class);
+    String value = environment.getProperty(normalizedName, String.class);
     if (value == null && normalizedName.equals("otel.exporter.otlp.protocol")) {
       // SDK autoconfigure module defaults to `grpc`, but this module aligns with
       // recommendation in specification to default to `http/protobuf`
@@ -165,34 +165,31 @@ public String getString(String name) {
   @Override
   public Boolean getBoolean(String name) {
     return or(
-        cachedEnvironment.getProperty(
-            ConfigUtil.normalizeEnvironmentVariableKey(name), Boolean.class),
+        environment.getProperty(ConfigUtil.normalizeEnvironmentVariableKey(name), Boolean.class),
         otelSdkProperties.getBoolean(name));
   }
 
   @Nullable
   @Override
   public Integer getInt(String name) {
     return or(
-        cachedEnvironment.getProperty(
-            ConfigUtil.normalizeEnvironmentVariableKey(name), Integer.class),
+        environment.getProperty(ConfigUtil.normalizeEnvironmentVariableKey(name), Integer.class),
         otelSdkProperties.getInt(name));
   }
 
   @Nullable
   @Override
   public Long getLong(String name) {
     return or(
-        cachedEnvironment.getProperty(ConfigUtil.normalizeEnvironmentVariableKey(name), Long.class),
+        environment.getProperty(ConfigUtil.normalizeEnvironmentVariableKey(name), Long.class),
         otelSdkProperties.getLong(name));
   }
 
   @Nullable
   @Override
   public Double getDouble(String name) {
     return or(
-        cachedEnvironment.getProperty(
-            ConfigUtil.normalizeEnvironmentVariableKey(name), Double.class),
+        environment.getProperty(ConfigUtil.normalizeEnvironmentVariableKey(name), Double.class),
         otelSdkProperties.getDouble(name));
   }
 
@@ -212,8 +209,7 @@ public List<String> getList(String name) {
       }
     }
 
-    List<String> envValue =
-        (List<String>) cachedEnvironment.getProperty(normalizedName, List.class);
+    List<String> envValue = (List<String>) environment.getProperty(normalizedName, List.class);
     return or(envValue, otelSdkProperties.getList(name));
   }
 
@@ -240,7 +236,7 @@ public Map<String, String> getMap(String name) {
       return specialMap;
     }
 
-    String value = cachedEnvironment.getProperty(normalizedName);
+    String value = environment.getProperty(normalizedName);
     if (value == null) {
       return otelSdkMap;
     }