Skip to content

Commit 79edac7

Browse files
update opentelemetry sdk to 1.58.0 (#15817)
Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com>
1 parent 32fab83 commit 79edac7

File tree

40 files changed

+118
-223
lines changed

40 files changed

+118
-223
lines changed

.github/config/lychee.toml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,4 +26,7 @@ exclude = [
2626
'^https://central.sonatype.com/service/rest/repository/browse/maven-snapshots/io/opentelemetry/$',
2727
# new artifact, remove after 2.21.0 release
2828
'^https://central.sonatype.com/artifact/io.opentelemetry.instrumentation/opentelemetry-helidon-4.3$',
29+
# flaky link
30+
'^http://www.slf4j.org.*',
31+
'^https://logback.qos.ch/.*'
2932
]

declarative-config-bridge/src/main/java/io/opentelemetry/instrumentation/config/bridge/ConfigPropertiesBackedConfigProvider.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
import io.opentelemetry.api.incubator.config.ConfigProvider;
99
import io.opentelemetry.api.incubator.config.DeclarativeConfigProperties;
1010
import io.opentelemetry.sdk.autoconfigure.spi.ConfigProperties;
11-
import javax.annotation.Nullable;
1211

1312
/**
1413
* A {@link ConfigProvider} implementation backed by {@link ConfigProperties}.
@@ -30,7 +29,6 @@ private ConfigPropertiesBackedConfigProvider(ConfigProperties configProperties)
3029
configProperties);
3130
}
3231

33-
@Nullable
3432
@Override
3533
public DeclarativeConfigProperties getInstrumentationConfig() {
3634
return instrumentationConfig;

declarative-config-bridge/src/test/java/io/opentelemetry/instrumentation/config/bridge/DeclarativeConfigPropertiesBridgeTest.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
import io.opentelemetry.sdk.autoconfigure.spi.ConfigProperties;
1111
import io.opentelemetry.sdk.extension.incubator.fileconfig.DeclarativeConfiguration;
1212
import io.opentelemetry.sdk.extension.incubator.fileconfig.SdkConfigProvider;
13-
import io.opentelemetry.sdk.extension.incubator.fileconfig.internal.model.InstrumentationModel;
13+
import io.opentelemetry.sdk.extension.incubator.fileconfig.internal.model.ExperimentalInstrumentationModel;
1414
import io.opentelemetry.sdk.extension.incubator.fileconfig.internal.model.OpenTelemetryConfigurationModel;
1515
import java.time.Duration;
1616
import java.util.Arrays;
@@ -31,7 +31,8 @@ void setup() {
3131

3232
OpenTelemetryConfigurationModel emptyModel =
3333
new OpenTelemetryConfigurationModel()
34-
.withAdditionalProperty("instrumentation/development", new InstrumentationModel());
34+
.withAdditionalProperty(
35+
"instrumentation/development", new ExperimentalInstrumentationModel());
3536
SdkConfigProvider emptyConfigProvider = SdkConfigProvider.create(emptyModel);
3637
emptyBridge =
3738
new DeclarativeConfigPropertiesBridgeBuilder()

dependencyManagement/build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ plugins {
55
data class DependencySet(val group: String, val version: String, val modules: List<String>)
66

77
// this line is managed by .github/scripts/update-sdk-version.sh
8-
val otelSdkVersion = "1.57.0"
8+
val otelSdkVersion = "1.58.0"
99
val otelContribVersion = "1.52.0-alpha"
1010
val otelSdkAlphaVersion = otelSdkVersion.replaceFirst("(-SNAPSHOT)?$".toRegex(), "-alpha$1")
1111

examples/distro/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ subprojects {
2727
ext {
2828
versions = [
2929
// this line is managed by .github/scripts/update-sdk-version.sh
30-
opentelemetrySdk : "1.57.0",
30+
opentelemetrySdk : "1.58.0",
3131

3232
// these lines are managed by .github/scripts/update-version.sh
3333
opentelemetryJavaagent : "2.24.0-SNAPSHOT",

examples/extension/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ version '1.0'
2323
ext {
2424
versions = [
2525
// this line is managed by .github/scripts/update-sdk-version.sh
26-
opentelemetrySdk : "1.57.0",
26+
opentelemetrySdk : "1.58.0",
2727

2828
// these lines are managed by .github/scripts/update-version.sh
2929
opentelemetryJavaagent : "2.24.0-SNAPSHOT",

instrumentation-api-incubator/src/main/java/io/opentelemetry/instrumentation/api/incubator/config/internal/CommonConfig.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77

88
import io.opentelemetry.api.OpenTelemetry;
99
import io.opentelemetry.api.incubator.config.ConfigProvider;
10+
import io.opentelemetry.api.incubator.config.DeclarativeConfigProperties;
1011
import io.opentelemetry.instrumentation.api.incubator.log.LoggingContextConstants;
1112
import io.opentelemetry.instrumentation.api.incubator.semconv.net.PeerServiceResolver;
1213
import io.opentelemetry.instrumentation.api.internal.HttpConstants;
@@ -44,9 +45,9 @@ interface ValueProvider<T> {
4445
}
4546

4647
public CommonConfig(OpenTelemetry openTelemetry) {
47-
ExtendedDeclarativeConfigProperties generalConfig =
48+
DeclarativeConfigProperties generalConfig =
4849
DeclarativeConfigUtil.getGeneralInstrumentationConfig(openTelemetry);
49-
ExtendedDeclarativeConfigProperties commonConfig =
50+
DeclarativeConfigProperties commonConfig =
5051
DeclarativeConfigUtil.getInstrumentationConfig(openTelemetry, "common");
5152
peerServiceResolver = PeerServiceResolver.create(openTelemetry);
5253

instrumentation-api-incubator/src/main/java/io/opentelemetry/instrumentation/api/incubator/config/internal/DeclarativeConfigUtil.java

Lines changed: 8 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -19,25 +19,17 @@ public final class DeclarativeConfigUtil {
1919

2020
private DeclarativeConfigUtil() {}
2121

22-
public static ExtendedDeclarativeConfigProperties getInstrumentationConfig(
22+
public static DeclarativeConfigProperties getInstrumentationConfig(
2323
OpenTelemetry openTelemetry, String instrumentationName) {
24-
return getConfig(openTelemetry).get("java").get(instrumentationName);
24+
return openTelemetry instanceof ExtendedOpenTelemetry
25+
? ((ExtendedOpenTelemetry) openTelemetry).getInstrumentationConfig(instrumentationName)
26+
: empty();
2527
}
2628

27-
public static ExtendedDeclarativeConfigProperties getGeneralInstrumentationConfig(
29+
public static DeclarativeConfigProperties getGeneralInstrumentationConfig(
2830
OpenTelemetry openTelemetry) {
29-
return getConfig(openTelemetry).get("general");
30-
}
31-
32-
private static ExtendedDeclarativeConfigProperties getConfig(OpenTelemetry openTelemetry) {
33-
if (openTelemetry instanceof ExtendedOpenTelemetry) {
34-
ExtendedOpenTelemetry extendedOpenTelemetry = (ExtendedOpenTelemetry) openTelemetry;
35-
DeclarativeConfigProperties instrumentationConfig =
36-
extendedOpenTelemetry.getConfigProvider().getInstrumentationConfig();
37-
if (instrumentationConfig != null) {
38-
return new ExtendedDeclarativeConfigProperties(instrumentationConfig);
39-
}
40-
}
41-
return new ExtendedDeclarativeConfigProperties(empty());
31+
return openTelemetry instanceof ExtendedOpenTelemetry
32+
? ((ExtendedOpenTelemetry) openTelemetry).getGeneralInstrumentationConfig()
33+
: empty();
4234
}
4335
}

instrumentation-api-incubator/src/main/java/io/opentelemetry/instrumentation/api/incubator/config/internal/EnduserConfig.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55

66
package io.opentelemetry.instrumentation.api.incubator.config.internal;
77

8+
import io.opentelemetry.api.incubator.config.DeclarativeConfigProperties;
89
import java.util.Objects;
910

1011
/**
@@ -39,7 +40,7 @@ public class EnduserConfig {
3940
private final boolean roleEnabled;
4041
private final boolean scopeEnabled;
4142

42-
EnduserConfig(ExtendedDeclarativeConfigProperties commonConfig) {
43+
EnduserConfig(DeclarativeConfigProperties commonConfig) {
4344
Objects.requireNonNull(commonConfig, "commonConfig must not be null");
4445

4546
/*

instrumentation-api-incubator/src/main/java/io/opentelemetry/instrumentation/api/incubator/config/internal/ExtendedDeclarativeConfigProperties.java

Lines changed: 0 additions & 89 deletions
This file was deleted.

0 commit comments

Comments
 (0)