Skip to content

Commit 7b443bd

Browse files
committed
keep changes to the advice migration
1 parent fd0069c commit 7b443bd

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

instrumentation/internal/internal-reflection/javaagent-integration-tests/src/main/java/instrumentation/TestTypeInstrumentation.java

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
import io.opentelemetry.javaagent.extension.instrumentation.TypeInstrumentation;
1212
import io.opentelemetry.javaagent.extension.instrumentation.TypeTransformer;
1313
import net.bytebuddy.asm.Advice;
14+
import net.bytebuddy.asm.Advice.AssignReturned;
1415
import net.bytebuddy.description.type.TypeDescription;
1516
import net.bytebuddy.matcher.ElementMatcher;
1617

@@ -32,21 +33,21 @@ public void transform(TypeTransformer transformer) {
3233
@SuppressWarnings("unused")
3334
public static class TestAdvice {
3435

36+
@AssignReturned.ToReturned
3537
@Advice.OnMethodExit
36-
public static void methodExit(
37-
@Advice.This Runnable test, @Advice.Return(readOnly = false) String result) {
38+
public static String methodExit(@Advice.This Runnable test) {
3839
VirtualField.find(Runnable.class, String.class).set(test, "instrumented");
39-
result = "instrumented";
40+
return "instrumented";
4041
}
4142
}
4243

4344
@SuppressWarnings("unused")
4445
public static class Test2Advice {
4546

47+
@AssignReturned.ToReturned
4648
@Advice.OnMethodExit
47-
public static void methodExit(
48-
@Advice.This Runnable test, @Advice.Return(readOnly = false) String result) {
49-
result = VirtualField.find(Runnable.class, String.class).get(test);
49+
public static String methodExit(@Advice.This Runnable test) {
50+
return VirtualField.find(Runnable.class, String.class).get(test);
5051
}
5152
}
5253
}

0 commit comments

Comments
 (0)