tomcat.request_processor.name -> tomcat.request.processor.name

Author: robsunday

instrumentation/jmx-metrics/library/src/main/resources/jmx/rules/tomcat.yaml

@@ -8,7 +8,7 @@ rules:
     - Tomcat:type=GlobalRequestProcessor,name=*
     prefix: tomcat.
     metricAttribute:
-      tomcat.request_processor.name: param(name)
+      tomcat.request.processor.name: param(name)
     mapping:
       errorCount:
         metric: error.count

instrumentation/jmx-metrics/library/src/test/java/io/opentelemetry/instrumentation/jmx/rules/TomcatIntegrationTest.java

@@ -59,7 +59,7 @@ void testCollectedMetrics(String dockerImageName, String sampleWebApplicationUrl
 
   private static MetricsVerifier createMetricsVerifier() {
     AttributeMatcher requestProcessorNameAttribute =
-        attribute("tomcat.request_processor.name", "\"http-nio-8080\"");
+        attribute("tomcat.request.processor.name", "\"http-nio-8080\"");
     AttributeMatcher threadPoolNameAttribute =
         attribute("tomcat.thread.pool.name", "\"http-nio-8080\"");
 

instrumentation/jmx-metrics/library/tomcat.md

@@ -6,11 +6,11 @@ Here is the list of metrics based on MBeans exposed by Tomcat.
 |-----------------------------|---------------|-----------------------------------------------------|--------------------------------------------|
 | tomcat.session.active.count | UpDownCounter | tomcat.context                                      | The number of currently active sessions.   |
 | tomcat.session.active.limit | UpDownCounter | tomcat.context                                      | Maximum number of active sessions.         |
-| tomcat.error.count          | Counter       | tomcat.request_processor.name                       | The number of errors.                      |
-| tomcat.request.count        | Counter       | tomcat.request_processor.name                       | The number of requests processed.          |
-| tomcat.request.duration.max | Gauge         | tomcat.request_processor.name                       | The longest request processing time.       |
-| tomcat.request.duration.sum | Counter       | tomcat.request_processor.name                       | Total time of processing all requests.     |
-| tomcat.network.io           | Counter       | tomcat.request_processor.name, network.io.direction | The number of bytes transmitted.           |
+| tomcat.error.count          | Counter       | tomcat.request.processor.name                       | The number of errors.                      |
+| tomcat.request.count        | Counter       | tomcat.request.processor.name                       | The number of requests processed.          |
+| tomcat.request.duration.max | Gauge         | tomcat.request.processor.name                       | The longest request processing time.       |
+| tomcat.request.duration.sum | Counter       | tomcat.request.processor.name                       | Total time of processing all requests.     |
+| tomcat.network.io           | Counter       | tomcat.request.processor.name, network.io.direction | The number of bytes transmitted.           |
 | tomcat.thread.count         | UpDownCounter | tomcat.thread.pool.name                             | Total thread count of the thread pool.     |
 | tomcat.thread.max           | UpDownCounter | tomcat.thread.pool.name                             | Maximum thread count of the thread pool.   |
 | tomcat.thread.busy.count    | UpDownCounter | tomcat.thread.pool.name                             | Number of busy threads in the thread pool. |