address reveiw comments

Author: laurit

instrumentation/aws-sdk/aws-sdk-2.2/library/src/main/java/io/opentelemetry/instrumentation/awssdk/v2_2/internal/AwsSdkRequestType.java

@@ -22,7 +22,7 @@ enum AwsSdkRequestType {
   S3(request(AttributeKeys.AWS_S3_BUCKET, "Bucket")),
   SQS(
       request(AttributeKeys.AWS_SQS_QUEUE_URL, "QueueUrl"),
-      requestExperimental(AttributeKey.stringKey("aws.queue.name"), "QueueName")),
+      requestExperimental(stringKey("aws.queue.name"), "QueueName")),
   KINESIS(request(AttributeKeys.AWS_KINESIS_STREAM_NAME, "StreamName")),
   DYNAMODB(),
   BEDROCK_RUNTIME(),
@@ -74,6 +74,6 @@ private static class AttributeKeys {
 
     // copied from MessagingIncubatingAttributes
     static final AttributeKey<String> MESSAGING_DESTINATION_NAME =
-        AttributeKey.stringKey("messaging.destination.name");
+        stringKey("messaging.destination.name");
   }
 }

instrumentation/aws-sdk/aws-sdk-2.2/library/src/test/java/io/opentelemetry/instrumentation/awssdk/v2_2/internal/FieldMapperTest.java

@@ -12,14 +12,14 @@
 import static io.opentelemetry.semconv.incubating.AwsIncubatingAttributes.AWS_DYNAMODB_PROVISIONED_READ_CAPACITY;
 import static io.opentelemetry.semconv.incubating.AwsIncubatingAttributes.AWS_DYNAMODB_PROVISIONED_WRITE_CAPACITY;
 import static io.opentelemetry.semconv.incubating.AwsIncubatingAttributes.AWS_DYNAMODB_TABLE_NAMES;
+import static java.util.Arrays.asList;
 import static java.util.Collections.singletonList;
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.verify;
 import static org.mockito.Mockito.verifyNoMoreInteractions;
 import static org.mockito.Mockito.when;
 
 import io.opentelemetry.api.trace.Span;
-import java.util.Arrays;
 import java.util.Collection;
 import java.util.HashMap;
 import java.util.Map;
@@ -71,13 +71,13 @@ void shouldMapRequestFieldsOnly() {
     Map<String, Collection<WriteRequest>> items = new HashMap<>();
     BatchWriteItemRequest sdkRequest = BatchWriteItemRequest.builder().requestItems(items).build();
     when(serializer.serializeCollection(items.keySet()))
-        .thenReturn(Arrays.asList("firstTable", "secondTable"));
+        .thenReturn(asList("firstTable", "secondTable"));
 
     Span span = mock(Span.class);
     // when
     underTest.mapToAttributes(sdkRequest, awsSdkRequest, span);
     // then
-    verify(span).setAttribute(AWS_DYNAMODB_TABLE_NAMES, Arrays.asList("firstTable", "secondTable"));
+    verify(span).setAttribute(AWS_DYNAMODB_TABLE_NAMES, asList("firstTable", "secondTable"));
     verifyNoMoreInteractions(span);
   }
 

instrumentation/aws-sdk/aws-sdk-2.2/testing/src/main/java/io/opentelemetry/instrumentation/awssdk/v2_2/AbstractAws2ClientCoreTest.java

@@ -53,7 +53,6 @@
 import java.lang.reflect.Method;
 import java.lang.reflect.Proxy;
 import java.util.ArrayList;
-import java.util.Arrays;
 import java.util.List;
 import java.util.concurrent.CompletableFuture;
 import java.util.function.Function;
@@ -282,7 +281,7 @@ private static void assertDynamoDbRequest(
       SpanDataAssert span, String operation, List<AttributeAssertion> extraAttributes) {
     List<AttributeAssertion> assertions =
         new ArrayList<>(
-            Arrays.asList(
+            asList(
                 equalTo(SERVER_ADDRESS, "127.0.0.1"),
                 equalTo(SERVER_PORT, server.httpPort()),
                 equalTo(URL_FULL, server.httpUri() + "/"),