Skip to content

Commit 7f1aa86

Browse files
committed
Reduce the number of unnecessary diffs
1 parent 3c87494 commit 7f1aa86

File tree

28 files changed

+49
-60
lines changed

28 files changed

+49
-60
lines changed

instrumentation-api-incubator/src/test/java/io/opentelemetry/instrumentation/api/incubator/semconv/db/DbClientAttributesExtractorTest.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,6 @@
2525
class DbClientAttributesExtractorTest {
2626

2727
static final class TestAttributesGetter implements DbClientAttributesGetter<Map<String, String>> {
28-
29-
@Nullable
3028
@Override
3129
public String getDbSystem(Map<String, String> map) {
3230
return map.get("db.system");
@@ -39,7 +37,6 @@ public String getUser(Map<String, String> map) {
3937
}
4038

4139
@Override
42-
@Nullable
4340
public String getDbNamespace(Map<String, String> map) {
4441
return map.get(
4542
SemconvStabilityUtil.getAttributeKey(AttributeKey.stringKey("db.name")).getKey());
@@ -52,14 +49,12 @@ public String getConnectionString(Map<String, String> map) {
5249
}
5350

5451
@Override
55-
@Nullable
5652
public String getDbQueryText(Map<String, String> map) {
5753
return map.get(
5854
SemconvStabilityUtil.getAttributeKey(AttributeKey.stringKey("db.statement")).getKey());
5955
}
6056

6157
@Override
62-
@Nullable
6358
public String getDbOperationName(Map<String, String> map) {
6459
return map.get(
6560
SemconvStabilityUtil.getAttributeKey(AttributeKey.stringKey("db.operation")).getKey());

instrumentation-api-incubator/src/test/java/io/opentelemetry/instrumentation/api/incubator/semconv/db/SqlClientAttributesExtractorTest.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ public String getRawQueryText(Map<String, String> map) {
3333
SemconvStabilityUtil.getAttributeKey(AttributeKey.stringKey("db.statement")).getKey());
3434
}
3535

36-
@Nullable
3736
@Override
3837
public String getDbSystem(Map<String, String> map) {
3938
return map.get("db.system");
@@ -45,7 +44,6 @@ public String getUser(Map<String, String> map) {
4544
return map.get("db.user");
4645
}
4746

48-
@Nullable
4947
@Override
5048
public String getDbNamespace(Map<String, String> map) {
5149
return map.get(

instrumentation/cassandra/cassandra-3.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/cassandra/v3_0/CassandraSingletons.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ public final class CassandraSingletons {
2525

2626
static {
2727
CassandraSqlAttributesGetter attributesGetter = new CassandraSqlAttributesGetter();
28+
2829
INSTRUMENTER =
2930
Instrumenter.<CassandraRequest, ExecutionInfo>builder(
3031
GlobalOpenTelemetry.get(),

instrumentation/cassandra/cassandra-3.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/cassandra/v3_0/CassandraSqlAttributesGetter.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
final class CassandraSqlAttributesGetter implements SqlClientAttributesGetter<CassandraRequest> {
1313

1414
@Override
15-
public String getDbSystem(CassandraRequest cassandraRequest) {
15+
public String getSystem(CassandraRequest request) {
1616
return DbIncubatingAttributes.DbSystemValues.CASSANDRA;
1717
}
1818

@@ -23,8 +23,8 @@ public String getUser(CassandraRequest request) {
2323
return null;
2424
}
2525

26-
@Nullable
2726
@Override
27+
@Nullable
2828
public String getDbNamespace(CassandraRequest request) {
2929
return request.getSession().getLoggedKeyspace();
3030
}
@@ -37,6 +37,7 @@ public String getConnectionString(CassandraRequest request) {
3737
}
3838

3939
@Override
40+
@Nullable
4041
public String getRawQueryText(CassandraRequest request) {
4142
return request.getDbQueryText();
4243
}

instrumentation/cassandra/cassandra-4.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/cassandra/v4_0/CassandraRequest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@
1111
@AutoValue
1212
public abstract class CassandraRequest {
1313

14-
public static CassandraRequest create(Session session, String dbQueryText) {
15-
return new AutoValue_CassandraRequest(session, dbQueryText);
14+
public static CassandraRequest create(Session session, String queryText) {
15+
return new AutoValue_CassandraRequest(session, queryText);
1616
}
1717

1818
public abstract Session getSession();

instrumentation/cassandra/cassandra-4.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/cassandra/v4_0/CassandraSingletons.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ public final class CassandraSingletons {
2424

2525
static {
2626
CassandraSqlAttributesGetter attributesGetter = new CassandraSqlAttributesGetter();
27+
2728
INSTRUMENTER =
2829
Instrumenter.<CassandraRequest, ExecutionInfo>builder(
2930
GlobalOpenTelemetry.get(),

instrumentation/cassandra/cassandra-4.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/cassandra/v4_0/CassandraSqlAttributesGetter.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
final class CassandraSqlAttributesGetter implements SqlClientAttributesGetter<CassandraRequest> {
1414

1515
@Override
16-
public String getDbSystem(CassandraRequest cassandraRequest) {
16+
public String getSystem(CassandraRequest request) {
1717
return DbIncubatingAttributes.DbSystemValues.CASSANDRA;
1818
}
1919

@@ -24,8 +24,8 @@ public String getUser(CassandraRequest request) {
2424
return null;
2525
}
2626

27-
@Nullable
2827
@Override
28+
@Nullable
2929
public String getDbNamespace(CassandraRequest request) {
3030
return request.getSession().getKeyspace().map(CqlIdentifier::toString).orElse(null);
3131
}
@@ -38,6 +38,7 @@ public String getConnectionString(CassandraRequest request) {
3838
}
3939

4040
@Override
41+
@Nullable
4142
public String getRawQueryText(CassandraRequest request) {
4243
return request.getDbQueryText();
4344
}

instrumentation/cassandra/cassandra-4.4/library/src/main/java/io/opentelemetry/instrumentation/cassandra/v4_4/CassandraRequest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@
1111
@AutoValue
1212
public abstract class CassandraRequest {
1313

14-
public static CassandraRequest create(Session session, String dbQueryText) {
15-
return new AutoValue_CassandraRequest(session, dbQueryText);
14+
public static CassandraRequest create(Session session, String queryText) {
15+
return new AutoValue_CassandraRequest(session, queryText);
1616
}
1717

1818
public abstract Session getSession();

instrumentation/cassandra/cassandra-4.4/library/src/main/java/io/opentelemetry/instrumentation/cassandra/v4_4/CassandraSqlAttributesGetter.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,8 @@ public String getUser(CassandraRequest request) {
2525
return null;
2626
}
2727

28-
@Nullable
2928
@Override
29+
@Nullable
3030
public String getDbNamespace(CassandraRequest request) {
3131
return request.getSession().getKeyspace().map(CqlIdentifier::toString).orElse(null);
3232
}
@@ -39,6 +39,7 @@ public String getConnectionString(CassandraRequest request) {
3939
}
4040

4141
@Override
42+
@Nullable
4243
public String getRawQueryText(CassandraRequest request) {
4344
return request.getDbQueryText();
4445
}

instrumentation/clickhouse-client-0.5/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/clickhouse/ClickHouseAttributesGetter.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ public String getDbOperationName(ClickHouseDbRequest request) {
2929
return request.getSqlStatementInfo().getOperation();
3030
}
3131

32+
@Nullable
3233
@Override
3334
public String getDbSystem(ClickHouseDbRequest request) {
3435
return DbIncubatingAttributes.DbSystemValues.CLICKHOUSE;

0 commit comments

Comments
 (0)