Skip to content

Commit 81af545

Browse files
committed
fix warnings
1 parent 6104f10 commit 81af545

File tree

11 files changed

+14
-10
lines changed

11 files changed

+14
-10
lines changed

instrumentation/graphql-java/graphql-java-12.0/library/src/main/java/io/opentelemetry/instrumentation/graphql/v12_0/GraphQLTelemetry.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
import io.opentelemetry.api.OpenTelemetry;
1010
import io.opentelemetry.instrumentation.graphql.internal.OpenTelemetryInstrumentationHelper;
1111

12-
@SuppressWarnings("AbbreviationAsWordInName")
12+
@SuppressWarnings({"AbbreviationAsWordInName", "MemberName"})
1313
public final class GraphQLTelemetry {
1414
private static final String INSTRUMENTATION_NAME = "io.opentelemetry.graphql-java-12.0";
1515

instrumentation/graphql-java/graphql-java-12.0/library/src/main/java/io/opentelemetry/instrumentation/graphql/v12_0/GraphQLTelemetryBuilder.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
import io.opentelemetry.api.OpenTelemetry;
1010

1111
/** A builder of {@link GraphQLTelemetry}. */
12-
@SuppressWarnings("AbbreviationAsWordInName")
12+
@SuppressWarnings({"AbbreviationAsWordInName", "MemberName"})
1313
public final class GraphQLTelemetryBuilder {
1414

1515
private final OpenTelemetry openTelemetry;

instrumentation/graphql-java/graphql-java-20.0/library/src/main/java/io/opentelemetry/instrumentation/graphql/v20_0/GraphQLTelemetry.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
import io.opentelemetry.instrumentation.api.instrumenter.Instrumenter;
1212
import io.opentelemetry.instrumentation.graphql.internal.OpenTelemetryInstrumentationHelper;
1313

14-
@SuppressWarnings("AbbreviationAsWordInName")
14+
@SuppressWarnings({"AbbreviationAsWordInName", "MemberName"})
1515
public final class GraphQLTelemetry {
1616

1717
/** Returns a new {@link GraphQLTelemetry} configured with the given {@link OpenTelemetry}. */

instrumentation/graphql-java/graphql-java-20.0/library/src/main/java/io/opentelemetry/instrumentation/graphql/v20_0/GraphQLTelemetryBuilder.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
import io.opentelemetry.api.OpenTelemetry;
1010

1111
/** A builder of {@link GraphQLTelemetry}. */
12-
@SuppressWarnings("AbbreviationAsWordInName")
12+
@SuppressWarnings({"AbbreviationAsWordInName", "MemberName"})
1313
public final class GraphQLTelemetryBuilder {
1414

1515
private final OpenTelemetry openTelemetry;

instrumentation/jboss-logmanager/jboss-logmanager-mdc-1.1/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/jbosslogmanager/mdc/v1_1/JbossLogmanagerMdcTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,7 @@ void idsGeneratedWhenSpanProvided() throws InvocationTargetException, IllegalAcc
9797
try {
9898
getMdcCopy = logRecords.get(0).getClass().getMethod("getMdcCopy");
9999
} catch (NoSuchMethodException ignored) {
100+
// ignored
100101
}
101102

102103
assertThat(logRecords.get(0).getMessage()).isEqualTo("log message 1");

instrumentation/rabbitmq-2.7/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/rabbitmq/RabbitMqTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,7 @@ public void cleanup() throws IOException, TimeoutException {
8282
conn.close();
8383
}
8484
} catch (ShutdownSignalException ignored) {
85+
// ignored
8586
}
8687
}
8788

instrumentation/redisson/redisson-common/testing/src/main/java/io/opentelemetry/javaagent/instrumentation/redisson/AbstractRedissonAsyncClientTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ static void cleanupAll() {
7878
}
7979

8080
@BeforeEach
81-
void setup() throws NoSuchMethodException, InvocationTargetException, IllegalAccessException {
81+
void setup() throws InvocationTargetException, IllegalAccessException {
8282
String newAddress = address;
8383
if (useRedisProtocol()) {
8484
// Newer versions of redisson require scheme, older versions forbid it
@@ -95,6 +95,7 @@ void setup() throws NoSuchMethodException, InvocationTargetException, IllegalAcc
9595
.getMethod("setPingConnectionInterval", int.class)
9696
.invoke(singleServerConfig, 0);
9797
} catch (NoSuchMethodException ignored) {
98+
// ignored
9899
}
99100
redisson = Redisson.create(config);
100101
testing.clearData();

instrumentation/redisson/redisson-common/testing/src/main/java/io/opentelemetry/javaagent/instrumentation/redisson/AbstractRedissonClientTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -99,6 +99,7 @@ void setup() throws InvocationTargetException, IllegalAccessException {
9999
.getMethod("setPingConnectionInterval", int.class)
100100
.invoke(singleServerConfig, 0);
101101
} catch (NoSuchMethodException ignored) {
102+
// ignored
102103
}
103104
redisson = Redisson.create(config);
104105
testing.clearData();

instrumentation/rxjava/rxjava-1.0/library/src/main/java/io/opentelemetry/instrumentation/rxjava/v1_0/TracedOnSubscribe.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@
99
import io.opentelemetry.context.Scope;
1010
import io.opentelemetry.instrumentation.api.instrumenter.Instrumenter;
1111
import rx.Observable;
12+
import rx.OpenTelemetryTracingUtil;
1213
import rx.Subscriber;
13-
import rx.__OpenTelemetryTracingUtil;
1414

1515
public final class TracedOnSubscribe<T, REQUEST> implements Observable.OnSubscribe<T> {
1616
private final Observable.OnSubscribe<T> delegate;
@@ -20,7 +20,7 @@ public final class TracedOnSubscribe<T, REQUEST> implements Observable.OnSubscri
2020

2121
public TracedOnSubscribe(
2222
Observable<T> originalObservable, Instrumenter<REQUEST, ?> instrumenter, REQUEST request) {
23-
delegate = __OpenTelemetryTracingUtil.extractOnSubscribe(originalObservable);
23+
delegate = OpenTelemetryTracingUtil.extractOnSubscribe(originalObservable);
2424
this.instrumenter = instrumenter;
2525
this.request = request;
2626

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,10 @@
88
/**
99
* This class must be in the rx package in order to access the package accessible onSubscribe field.
1010
*/
11-
@SuppressWarnings("checkstyle:TypeName")
12-
public final class __OpenTelemetryTracingUtil {
11+
public final class OpenTelemetryTracingUtil {
1312
public static <T> Observable.OnSubscribe<T> extractOnSubscribe(Observable<T> observable) {
1413
return observable.onSubscribe;
1514
}
1615

17-
private __OpenTelemetryTracingUtil() {}
16+
private OpenTelemetryTracingUtil() {}
1817
}

0 commit comments

Comments
 (0)